projects
/
fa-stable.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Cleanup on key_in_foreign_table calls, removed obsolete $escaped argument.
[fa-stable.git]
/
gl
/
manage
/
gl_account_types.php
diff --git
a/gl/manage/gl_account_types.php
b/gl/manage/gl_account_types.php
index 3cef7a07540acdc4e051ae30c8c8665eae737ae3..fcea4dbfcc32611445e8cadf679ba780db94d78f 100644
(file)
--- a/
gl/manage/gl_account_types.php
+++ b/
gl/manage/gl_account_types.php
@@
-22,7
+22,7
@@
include($path_to_root . "/includes/ui.inc");
simple_page_mode(false);
//-----------------------------------------------------------------------------------
simple_page_mode(false);
//-----------------------------------------------------------------------------------
-function can_process()
+function can_process(
$selected_id
)
{
if (strlen(trim($_POST['id'])) == 0)
{
{
if (strlen(trim($_POST['id'])) == 0)
{
@@
-36,6
+36,13
@@
function can_process()
set_focus('name');
return false;
}
set_focus('name');
return false;
}
+ $type = get_account_type(trim($_POST['id']));
+ if ($type && ($type['id'] != $selected_id))
+ {
+ display_error( _("This account group id is already in use."));
+ set_focus('id');
+ return false;
+ }
//if (strcmp($_POST['id'], $_POST['parent']) == 0)
if ($_POST['id'] === $_POST['parent'])
//if (strcmp($_POST['id'], $_POST['parent']) == 0)
if ($_POST['id'] === $_POST['parent'])
@@
-52,7
+59,7
@@
function can_process()
if ($Mode=='ADD_ITEM' || $Mode=='UPDATE_ITEM')
{
if ($Mode=='ADD_ITEM' || $Mode=='UPDATE_ITEM')
{
- if (can_process())
+ if (can_process(
$selected_id
))
{
if ($selected_id != "")
{
if ($selected_id != "")
@@
-72,19
+79,18
@@
if ($Mode=='ADD_ITEM' || $Mode=='UPDATE_ITEM')
//-----------------------------------------------------------------------------------
//-----------------------------------------------------------------------------------
-function can_delete($
selected_id
)
+function can_delete($
type
)
{
{
- if ($
selected_id
== "")
+ if ($
type
== "")
return false;
return false;
- $type = db_escape($selected_id);
- if (key_in_foreign_table($type, 'chart_master', 'account_type'
, true
))
+ if (key_in_foreign_table($type, 'chart_master', 'account_type'))
{
display_error(_("Cannot delete this account group because GL accounts have been created referring to it."));
return false;
}
{
display_error(_("Cannot delete this account group because GL accounts have been created referring to it."));
return false;
}
- if (key_in_foreign_table($type, 'chart_types', 'parent'
, true
))
+ if (key_in_foreign_table($type, 'chart_types', 'parent'))
{
display_error(_("Cannot delete this account group because GL account groups have been created referring to it."));
return false;
{
display_error(_("Cannot delete this account group because GL account groups have been created referring to it."));
return false;