0001503: Request - fee account included in bank account table

[fa-stable.git] / admin / db / transactions_db.inc

diff --git a/admin/db/transactions_db.inc b/admin/db/transactions_db.inc
index c4f48306ce34a3d575f86e9d40ac2a33d5362b2e..293e8f4d0aad1dcec2ef45825cd603864260aa4e 100644 (file)
--- a/admin/db/transactions_db.inc
+++ b/admin/db/transactions_db.inc
@@ -25,7 +25,7 @@ function get_sql_for_view_transactions($filtertype, $from, $to, &$trans_ref)
        $trans_ref = $db_info[3];
        $trans_date = $db_info[4];
 
-       $sql = "SELECT DISTINCT t.$trans_no_name as trans_no";
+       $sql = "SELECT t.$trans_no_name as trans_no";
 
        if ($trans_ref)
                $sql .= " ,t.$trans_ref as ref ";
@@ -49,9 +49,14 @@ function get_sql_for_view_transactions($filtertype, $from, $to, &$trans_ref)
        }
        elseif ($type_name != null)
                $sql .= " AND t.`$type_name` = ".db_escape($filtertype);
-       
-       $sql .= " ORDER BY t.$trans_no_name";
 
+       // the ugly hack below is necessary to exclude old gl_trans records lasting after edition,
+       // otherwise old data transaction can be retrieved instead of current one.
+       if ($table_name==TB_PREF.'gl_trans')
+               $sql .= " AND t.`amount` <> 0";
+
+       $sql .= " GROUP BY ".($type_name ? "t.$type_name," : '')." t.$trans_no_name";
+       $sql .= " ORDER BY t.$trans_no_name";
        return $sql;
 }