Removed sparse parameter in write_customer()

[fa-stable.git] / admin / security_roles.php

diff --git a/admin/security_roles.php b/admin/security_roles.php
index 8ca8ce2d6dd67068c54df810b2cfea27de858b63..7e68d3734854b6c45f647f021bfce8f9c1fec8cb 100644 (file)
--- a/admin/security_roles.php
+++ b/admin/security_roles.php
@@ -15,7 +15,7 @@ include_once($path_to_root . "/includes/session.inc");
 
 add_access_extensions();
 
-page(_("Access setup"));
+page(_($help_context = "Access setup"));
 
 include_once($path_to_root . "/includes/ui.inc");
 include_once($path_to_root . "/includes/access_levels.inc");
@@ -85,33 +85,25 @@ if (get_post('addupdate'))
                $sections = array();
                $areas = array();
                foreach($_POST as $p =>$val) {
-                       if (substr($p,0,4) == 'Area') {
+                       if (substr($p,0,4) == 'Area' && $val == 1) {
                                $a = substr($p, 4);
                                if (($a&~0xffff) && (($a&0xff00)<(99<<8))) {
                                        $sections[] = $a&~0xff; // add extended section for plugins
                                }
-                               $areas[] = $a;
+                               $areas[] = (int)$a;
                        }
-                       if (substr($p,0,7) == 'Section')
-                               $sections[] = substr($p, 7);
+                       if (substr($p,0,7) == 'Section' && $val == 1)
+                               $sections[] = (int)substr($p, 7);
                }
 //             $areas = sort_areas($areas);
 
-               $sections = array_values($sections);
+       write_security_role($_POST['role'], $_POST['name'], $_POST['description'], 
+               $sections, $areas, get_post('inactive'));
 
-       if ($new_role) 
-               {
-                       add_security_role($_POST['name'], $_POST['description'], $sections, $areas); 
-                       display_notification(_("New security role has been added."));
-               } else
-               {
-                       update_security_role($_POST['role'], $_POST['name'], $_POST['description'], 
-                               $sections, $areas); 
-                       update_record_status($_POST['role'], get_post('inactive'),
-                               'security_roles', 'id');
-
-                       display_notification(_("Security role has been updated."));
-               }
+       if ($new_role) 
+               display_notification(_("New security role has been added."));
+       else
+               display_notification(_("Security role has been updated."));
        $new_role = true;
        clear_data();
        $Ajax->activate('_page_body');
@@ -147,9 +139,6 @@ if (!isset($_POST['role']) || get_post('clone') || list_updated('role')) {
                $row = get_security_role($id);
                $_POST['description'] = $row['description'];
                $_POST['name'] = $row['role'];
-//     if ($row['inactive']
-//             $_POST['inactive'] = 1;
-       
                $_POST['inactive'] = $row['inactive'];
                $access = $row['areas'];
                $sections = $row['sections'];
@@ -173,7 +162,7 @@ if (!isset($_POST['role']) || get_post('clone') || list_updated('role')) {
 
 start_form();
 
-start_table("class='tablestyle_noborder'");
+start_table(TABLESTYLE_NOBORDER);
 start_row();
 security_roles_list_cells(_("Role:"). "&nbsp;", 'role', null, true, true, check_value('show_inactive'));
 $new_role = get_post('role')=='';
@@ -191,13 +180,13 @@ if (find_submit('_Section')) {
 }
 //-----------------------------------------------------------------------------------------------
 div_start('details');
-start_table($table_style2);
+start_table(TABLESTYLE2);
        text_row(_("Role name:"), 'name', null, 20, 22);
        text_row(_("Role description:"), 'description', null, 50, 52);
        record_status_list_row(_("Current status:"), 'inactive');
 end_table(1);
 
-       start_table("$table_style width=40%");
+       start_table(TABLESTYLE, "width='40%'");
 
        $k = $j = 0; //row colour counter
        $ext = $sec = $m = -1;
@@ -214,8 +203,6 @@ end_table(1);
                        $ext = $newext; 
                        $sec = $newsec;
                        $m = $parms[0] & ~0xff;
-//                     if(!isset($security_sections[$m]))
-//                      display_error(sprintf("Bad section %X:", $m));
                        label_row($security_sections[$m].':', 
                                checkbox( null, 'Section'.$m, null, true, 
                                        _("On/off set of features")),
@@ -254,4 +241,3 @@ div_end();
 end_form();
 end_page();
 
-?>