Moving bugfixes from 2.3 to 2.4 and updated install languages for Denmark and Sweden.
[fa-stable.git] / gl / manage / gl_accounts.php
index 718be9bd872f692f7b257154933e348a60c8fe65..5bda0dcdff4047d4e6daa5d6b1886fc0b3e8556c 100644 (file)
@@ -13,10 +13,15 @@ $page_security = 'SA_GLACCOUNT';
 $path_to_root = "../..";
 include($path_to_root . "/includes/session.inc");
 
-page(_("Chart of Accounts"));
+$js = "";
+if ($SysPrefs->use_popup_windows && $SysPrefs->use_popup_search)
+       $js .= get_js_open_window(900, 500);
+
+page(_($help_context = "Chart of Accounts"), false, false, "", $js);
 
 include($path_to_root . "/includes/ui.inc");
 include($path_to_root . "/gl/includes/gl_db.inc");
+include($path_to_root . "/admin/db/tags_db.inc");
 include_once($path_to_root . "/includes/data_checks.inc");
 
 check_db_has_gl_account_groups(_("There are no account groups defined. Please define at least one account group before entering accounts."));
@@ -39,7 +44,6 @@ elseif (isset($_GET['selected_account']))
 }
 else
        $selected_account = "";
-
 //-------------------------------------------------------------------------------------
 
 if (isset($_POST['add']) || isset($_POST['update'])) 
@@ -47,35 +51,44 @@ if (isset($_POST['add']) || isset($_POST['update']))
 
        $input_error = 0;
 
-       if (strlen($_POST['account_code']) == 0) 
+       if (strlen(trim($_POST['account_code'])) == 0) 
        {
                $input_error = 1;
                display_error( _("The account code must be entered."));
                set_focus('account_code');
        } 
-       elseif (strlen($_POST['account_name']) == 0) 
+       elseif (strlen(trim($_POST['account_name'])) == 0) 
        {
                $input_error = 1;
                display_error( _("The account name cannot be empty."));
                set_focus('account_name');
        } 
-       elseif (!$accounts_alpha && !is_numeric($_POST['account_code'])) 
+       elseif (!$SysPrefs->accounts_alpha() && !preg_match("/^[0-9.]+$/",$_POST['account_code'])) // we only allow 0-9 and a dot
        {
            $input_error = 1;
            display_error( _("The account code must be numeric."));
                set_focus('account_code');
        }
-
        if ($input_error != 1)
        {
-               if ($accounts_alpha == 2)
+               if ($SysPrefs->accounts_alpha() == 2)
                        $_POST['account_code'] = strtoupper($_POST['account_code']);
+
+               if (!isset($_POST['account_tags']))
+                       $_POST['account_tags'] = array();
+
        if ($selected_account) 
                {
-               if (update_gl_account($_POST['account_code'], $_POST['account_name'], 
+                       if (get_post('inactive') == 1 && is_bank_account($_POST['account_code']))
+                       {
+                               display_error(_("The account belongs to a bank account and cannot be inactivated."));
+                       }
+               elseif (update_gl_account($_POST['account_code'], $_POST['account_name'], 
                                $_POST['account_type'], $_POST['account_code2'])) {
                                update_record_status($_POST['account_code'], $_POST['inactive'],
                                        'chart_master', 'account_code');
+                               update_tag_associations(TAG_ACCOUNT, $_POST['account_code'], 
+                                       $_POST['account_tags']);
                                $Ajax->activate('account_code'); // in case of status change
                                display_notification(_("Account data has been updated."));
                        }
@@ -85,9 +98,12 @@ if (isset($_POST['add']) || isset($_POST['update']))
                if (add_gl_account($_POST['account_code'], $_POST['account_name'], 
                                $_POST['account_type'], $_POST['account_code2']))
                                {
+                                       add_tag_associations($_POST['account_code'], $_POST['account_tags']);
                                        display_notification(_("New account has been added."));
                                        $selected_account = $_POST['AccountList'] = $_POST['account_code'];
                                }
+                       else
+                 display_error(_("Account not added, possible duplicate Account Code."));
                }
                $Ajax->activate('_page_body');
        }
@@ -99,108 +115,59 @@ function can_delete($selected_account)
 {
        if ($selected_account == "")
                return false;
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."gl_trans WHERE account='$selected_account'";
-       $result = db_query($sql,"Couldn't test for existing transactions");
 
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0) 
+       if (key_in_foreign_table($selected_account, 'gl_trans', 'account'))
        {
                display_error(_("Cannot delete this account because transactions have been created using this account."));
                return false;
        }
 
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."company WHERE debtors_act='$selected_account' 
-               OR pyt_discount_act='$selected_account' 
-               OR creditors_act='$selected_account' 
-               OR freight_act='$selected_account'
-               OR default_sales_act='$selected_account' 
-               OR default_sales_discount_act='$selected_account'
-               OR default_prompt_payment_act='$selected_account'
-               OR default_inventory_act='$selected_account'
-               OR default_cogs_act='$selected_account'
-               OR default_adj_act='$selected_account'
-               OR default_inv_sales_act='$selected_account'
-               OR default_assembly_act='$selected_account'";
-       $result = db_query($sql,"Couldn't test for default company GL codes");
-
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0) 
+       if (gl_account_in_company_defaults($selected_account))
        {
                display_error(_("Cannot delete this account because it is used as one of the company default GL accounts."));
                return false;
        }
-       
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."bank_accounts WHERE account_code='$selected_account'";
-       $result = db_query($sql,"Couldn't test for bank accounts");
 
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0) 
+       if (key_in_foreign_table($selected_account, 'bank_accounts', 'account_code'))
        {
                display_error(_("Cannot delete this account because it is used by a bank account."));
                return false;
-       }       
+       }
 
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."stock_master WHERE 
-               inventory_account='$selected_account' 
-               OR cogs_account='$selected_account'
-               OR adjustment_account='$selected_account' 
-               OR sales_account='$selected_account'";
-       $result = db_query($sql,"Couldn't test for existing stock GL codes");
+       if (gl_account_in_stock_category($selected_account))
+       {
+               display_error(_("Cannot delete this account because it is used by one or more Item Categories."));
+               return false;
+       }
 
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0) 
+       if (gl_account_in_stock_master($selected_account))
        {
                display_error(_("Cannot delete this account because it is used by one or more Items."));
                return false;
-       }       
-       
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."tax_types WHERE sales_gl_code='$selected_account' OR purchasing_gl_code='$selected_account'";
-       $result = db_query($sql,"Couldn't test for existing tax GL codes");
+       }
 
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0) 
+       if (gl_account_in_tax_types($selected_account))
        {
                display_error(_("Cannot delete this account because it is used by one or more Taxes."));
                return false;
-       }       
-       
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."cust_branch WHERE 
-               sales_account='$selected_account' 
-               OR sales_discount_account='$selected_account'
-               OR receivables_account='$selected_account'
-               OR payment_discount_account='$selected_account'";
-       $result = db_query($sql,"Couldn't test for existing cust branch GL codes");
-
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0) 
+       }
+
+       if (gl_account_in_cust_branch($selected_account))
        {
                display_error(_("Cannot delete this account because it is used by one or more Customer Branches."));
                return false;
-       }               
-       
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."suppliers WHERE 
-               purchase_account='$selected_account' 
-               OR payment_discount_account='$selected_account' 
-               OR payable_account='$selected_account'";
-       $result = db_query($sql,"Couldn't test for existing suppliers GL codes");
-
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0) 
+       }
+       if (gl_account_in_suppliers($selected_account))
        {
                display_error(_("Cannot delete this account because it is used by one or more suppliers."));
                return false;
-       }                                                                       
-       
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."quick_entry_lines WHERE 
-               dest_id='$selected_account' AND UPPER(LEFT(action, 1)) <> 'T'";
-       $result = db_query($sql,"Couldn't test for existing suppliers GL codes");
+       }
 
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0) 
+       if (gl_account_in_quick_entry_lines($selected_account))
        {
                display_error(_("Cannot delete this account because it is used by one or more Quick Entry Lines."));
                return false;
-       }                                                                       
+       }
 
        return true;
 }
@@ -214,6 +181,8 @@ if (isset($_POST['delete']))
        {
                delete_gl_account($selected_account);
                $selected_account = $_POST['AccountList'] = '';
+               delete_tag_associations(TAG_ACCOUNT,$selected_account, true);
+               $selected_account = $_POST['AccountList'] = '';
                display_notification(_("Selected account has been deleted"));
                unset($_POST['account_code']);
                $Ajax->activate('_page_body');
@@ -226,7 +195,7 @@ start_form();
 
 if (db_has_gl_accounts()) 
 {
-       start_table("class = 'tablestyle_noborder'");
+       start_table(TABLESTYLE_NOBORDER);
        start_row();
     gl_all_accounts_list_cells(null, 'AccountList', null, false, false,
                _('New account'), true, check_value('show_inactive'));
@@ -240,7 +209,7 @@ if (db_has_gl_accounts())
 }
        
 br(1);
-start_table($table_style2);
+start_table(TABLESTYLE2);
 
 if ($selected_account != "") 
 {
@@ -252,6 +221,12 @@ if ($selected_account != "")
        $_POST['account_name']  = $myrow["account_name"];
        $_POST['account_type'] = $myrow["account_type"];
        $_POST['inactive'] = $myrow["inactive"];
+       
+       $tags_result = get_tags_associated_with_record(TAG_ACCOUNT, $selected_account);
+       $tagids = array();
+       while ($tag = db_fetch($tags_result)) 
+               $tagids[] = $tag['id'];
+       $_POST['account_tags'] = $tagids;
 
        hidden('account_code', $_POST['account_code']);
        hidden('selected_account', $selected_account);
@@ -261,19 +236,22 @@ if ($selected_account != "")
 else
 {
        if (!isset($_POST['account_code'])) {
+               $_POST['account_tags'] = array();
                $_POST['account_code'] = $_POST['account_code2'] = '';
                $_POST['account_name']  = $_POST['account_type'] = '';
                $_POST['inactive'] = 0;
        }
-       text_row_ex(_("Account Code:"), 'account_code', 11);
+       text_row_ex(_("Account Code:"), 'account_code', 15);
 }
 
-text_row_ex(_("Account Code 2:"), 'account_code2', 11);
+text_row_ex(_("Account Code 2:"), 'account_code2', 15);
 
 text_row_ex(_("Account Name:"), 'account_name', 60);
 
 gl_account_types_list_row(_("Account Group:"), 'account_type', null);
 
+tag_list_row(_("Account Tags:"), 'account_tags', 5, TAG_ACCOUNT, true);
+
 record_status_list_row(_("Account status:"), 'inactive');
 end_table(1);
 
@@ -290,4 +268,3 @@ end_form();
 
 end_page();
 
-?>