Mysqli errors: Trying to access array offset on value of type bool. Fixed. Please...

[fa-stable.git] / sales / includes / db / sales_types_db.inc

diff --git a/sales/includes/db/sales_types_db.inc b/sales/includes/db/sales_types_db.inc
index 2257ad5e6b1c89525376013c3a04315038b2c5df..6007eb257d1655e10280c1fd152e203ce7e88483 100644 (file)
--- a/sales/includes/db/sales_types_db.inc
+++ b/sales/includes/db/sales_types_db.inc
@@ -1,17 +1,18 @@
 <?php
 /**********************************************************************
     Copyright (C) FrontAccounting, LLC.
-       Released under the terms of the GNU Affero General Public License,
-       AGPL, as published by the Free Software Foundation, either version 
-       3 of the License, or (at your option) any later version.
+       Released under the terms of the GNU General Public License, GPL, 
+       as published by the Free Software Foundation, either version 3 
+       of the License, or (at your option) any later version.
     This program is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  
-    See the License here <http://www.gnu.org/licenses/agpl-3.0.html>.
+    See the License here <http://www.gnu.org/licenses/gpl-3.0.html>.
 ***********************************************************************/
 function add_sales_type($name, $tax_included, $factor)
 {
-       $sql = "INSERT INTO ".TB_PREF."sales_types (sales_type,tax_included,factor) VALUES (".db_escape($name).",'$tax_included',$factor)";
+       $sql = "INSERT INTO ".TB_PREF."sales_types (sales_type,tax_included,factor) VALUES (".db_escape($name).","
+               .db_escape($tax_included).",".db_escape($factor).")";
        db_query($sql, "could not add sales type");             
 }
 
@@ -19,21 +20,23 @@ function update_sales_type($id, $name, $tax_included, $factor)
 {
 
        $sql = "UPDATE ".TB_PREF."sales_types SET sales_type = ".db_escape($name).",
-       tax_included =$tax_included, factor=$factor WHERE id = $id";
+       tax_included =".db_escape($tax_included).", factor=".db_escape($factor)." WHERE id = ".db_escape($id);
        
        db_query($sql, "could not update sales type");                  
 }
 
-function get_all_sales_types()
+function get_all_sales_types($all=false)
 {
        $sql = "SELECT * FROM ".TB_PREF."sales_types";
+       if (!$all)
+               $sql .= " WHERE !inactive";
        
        return db_query($sql, "could not get all sales types");
 } 
 
 function get_sales_type($id)
 {
-       $sql = "SELECT * FROM ".TB_PREF."sales_types WHERE id=$id";
+       $sql = "SELECT * FROM ".TB_PREF."sales_types WHERE id=".db_escape($id);
        
        $result = db_query($sql, "could not get sales type");
        
@@ -42,21 +45,20 @@ function get_sales_type($id)
 
 function get_sales_type_name($id)
 {
-       $sql = "SELECT sales_type FROM ".TB_PREF."sales_types WHERE id=$id";
+       $sql = "SELECT sales_type FROM ".TB_PREF."sales_types WHERE id=".db_escape($id);
        
        $result = db_query($sql, "could not get sales type");
        
        $row = db_fetch_row($result);
-       return $row[0];
+       return is_array($row) ? $row[0] : false;
 }
 
 function delete_sales_type($id)
 {
-       $sql="DELETE FROM ".TB_PREF."sales_types WHERE id=$id";
+       $sql="DELETE FROM ".TB_PREF."sales_types WHERE id=".db_escape($id);
        db_query($sql,"The Sales type record could not be deleted");
 
-       $sql ="DELETE FROM ".TB_PREF."prices WHERE sales_type_id='$id'";
+       $sql ="DELETE FROM ".TB_PREF."prices WHERE sales_type_id=".db_escape($id);
        db_query($sql,"The Sales type prices could not be deleted");
 }
 
-?>
\ No newline at end of file