Fixed many issues in output HTML code according to HTML 4.01 Transitional format.

[fa-stable.git] / sales / manage / sales_people.php

diff --git a/sales/manage/sales_people.php b/sales/manage/sales_people.php
index 731c552287527fcbf12e617631f8b1dcd9cd3bde..0fd8e1d68a7812d1faa2ae0fc1a7f525fbb47f75 100644 (file)
--- a/sales/manage/sales_people.php
+++ b/sales/manage/sales_people.php
@@ -9,11 +9,11 @@
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  
     See the License here <http://www.gnu.org/licenses/gpl-3.0.html>.
 ***********************************************************************/
-$page_security = 3;
-$path_to_root="../..";
+$page_security = 'SA_SALESMAN';
+$path_to_root = "../..";
 include($path_to_root . "/includes/session.inc");
 
-page(_("Sales Persons"));
+page(_($help_context = "Sales Persons"));
 
 include($path_to_root . "/includes/ui.inc");
 
@@ -48,31 +48,16 @@ if ($Mode=='ADD_ITEM' || $Mode=='UPDATE_ITEM')
        if ($selected_id != -1) 
        {
                /*selected_id could also exist if submit had not been clicked this code would not run in this case cos submit is false of course  see the delete code below*/
-
-               $sql = "UPDATE ".TB_PREF."salesman SET salesman_name=".db_escape($_POST['salesman_name']) . ",
-                       salesman_phone=".db_escape($_POST['salesman_phone']) . ",
-                       salesman_fax=".db_escape($_POST['salesman_fax']) . ",
-                       salesman_email=".db_escape($_POST['salesman_email']) . ",
-                       provision=".input_num('provision').",
-                       break_pt=".input_num('break_pt').",
-                       provision2=".input_num('provision2')."
-                       WHERE salesman_code = ".db_escape($selected_id);
+                       update_salesman($selected_id, $_POST['salesman_name'], $_POST['salesman_phone'], $_POST['salesman_fax'],
+                               $_POST['salesman_email'], input_num('provision'), input_num('break_pt'), input_num('provision2'));
        }
        else
        {
                /*Selected group is null cos no item selected on first time round so must be adding a record must be submitting new entries in the new Sales-person form */
-               $sql = "INSERT INTO ".TB_PREF."salesman (salesman_name, salesman_phone, salesman_fax, salesman_email,
-                       provision, break_pt, provision2)
-                       VALUES (".db_escape($_POST['salesman_name']) . ", "
-                                 .db_escape($_POST['salesman_phone']) . ", "
-                                 .db_escape($_POST['salesman_fax']) . ", "
-                                 .db_escape($_POST['salesman_email']) . ", ".
-                       input_num('provision').", ".input_num('break_pt').", "
-                               .input_num('provision2').")";
+                       add_salesman($_POST['salesman_name'], $_POST['salesman_phone'], $_POST['salesman_fax'],
+                               $_POST['salesman_email'], input_num('provision'), input_num('break_pt'), input_num('provision2'));
        }
 
-       //run the sql from either of the above possibilites
-       db_query($sql,"The insert or update of the sales person failed");
        if ($selected_id != -1) 
                        display_notification(_('Selected sales person data have been updated'));
                else
@@ -86,17 +71,13 @@ if ($Mode == 'Delete')
 
        // PREVENT DELETES IF DEPENDENT RECORDS IN 'debtors_master'
 
-       $sql= "SELECT COUNT(*) FROM ".TB_PREF."cust_branch WHERE salesman=".db_escape($selected_id);
-       $result = db_query($sql,"check failed");
-       $myrow = db_fetch_row($result);
-       if ($myrow[0] > 0)
+       if (key_in_foreign_table($selected_id, 'cust_branch', 'salesman'))
        {
-               display_error("Cannot delete this sales-person because branches are set up referring to this sales-person - first alter the branches concerned.");
+               display_error(_("Cannot delete this sales-person because branches are set up referring to this sales-person - first alter the branches concerned."));
        }
        else
        {
-               $sql="DELETE FROM ".TB_PREF."salesman WHERE salesman_code=".db_escape($selected_id);
-               db_query($sql,"The sales-person could not be deleted");
+               delete_salesman($selected_id);
                display_notification(_('Selected sales person data have been deleted'));
        }
        $Mode = 'RESET';
@@ -105,16 +86,18 @@ if ($Mode == 'Delete')
 if ($Mode == 'RESET')
 {
        $selected_id = -1;
+       $sav = get_post('show_inactive');
        unset($_POST);
+       $_POST['show_inactive'] = $sav;
 }
 //------------------------------------------------------------------------------------------------
 
-$sql = "SELECT * FROM ".TB_PREF."salesman";
-$result = db_query($sql,"could not get sales persons");
+$result = get_salesmen(check_value('show_inactive'));
 
 start_form();
-start_table("$table_style width=60%");
+start_table(TABLESTYLE, "width='60%'");
 $th = array(_("Name"), _("Phone"), _("Fax"), _("Email"), _("Provision"), _("Break Pt."), _("Provision")." 2", "", "");
+inactive_control_column($th);
 table_header($th);
 
 $k = 0;
@@ -131,30 +114,26 @@ while ($myrow = db_fetch($result))
        label_cell(percent_format($myrow["provision"])." %", "nowrap align=right");
        amount_cell($myrow["break_pt"]);
        label_cell(percent_format($myrow["provision2"])." %", "nowrap align=right");
+       inactive_control_cell($myrow["salesman_code"], $myrow["inactive"],
+               'salesman', 'salesman_code');
        edit_button_cell("Edit".$myrow["salesman_code"], _("Edit"));
        delete_button_cell("Delete".$myrow["salesman_code"], _("Delete"));
        end_row();
 
 } //END WHILE LIST LOOP
 
+inactive_control_row($th);
 end_table();
-end_form();
 echo '<br>';
 
 //------------------------------------------------------------------------------------------------
 
-start_form();
-
-
 $_POST['salesman_email'] = "";
 if ($selected_id != -1) 
 {
        if ($Mode == 'Edit') {
                //editing an existing Sales-person
-               $sql = "SELECT *  FROM ".TB_PREF."salesman WHERE salesman_code=".db_escape($selected_id);
-
-               $result = db_query($sql,"could not get sales person");
-               $myrow = db_fetch($result);
+               $myrow = get_salesman($selected_id);
 
                $_POST['salesman_name'] = $myrow["salesman_name"];
                $_POST['salesman_phone'] = $myrow["salesman_phone"];
@@ -171,7 +150,7 @@ if ($selected_id != -1)
                $_POST['provision2'] = percent_format(0);       
 }
 
-start_table($table_style2);
+start_table(TABLESTYLE2);
 
 text_row_ex(_("Sales person name:"), 'salesman_name', 30);
 text_row_ex(_("Telephone number:"), 'salesman_phone', 20);
@@ -182,7 +161,7 @@ amount_row(_("Break Pt.:"), 'break_pt');
 percent_row(_("Provision")." 2:", 'provision2');
 end_table(1);
 
-submit_add_or_update_center($selected_id == -1, '', true);
+submit_add_or_update_center($selected_id == -1, '', 'both');
 
 end_form();