X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;ds=inline;f=sales%2Fcustomer_delivery.php;h=df8bad06d9ebd4016d13e8f24174a1cf90420c50;hb=9a98bb3bc7a94f1a8e47f8dab45a87c8b4212080;hp=2c0991ab4f68a5a8bc401c4a8d55d34a0838441d;hpb=de3a75773afa86df1739d14f24399d6f7a46f809;p=fa-stable.git
diff --git a/sales/customer_delivery.php b/sales/customer_delivery.php
index 2c0991ab..df8bad06 100644
--- a/sales/customer_delivery.php
+++ b/sales/customer_delivery.php
@@ -1,10 +1,20 @@
.
+***********************************************************************/
//-----------------------------------------------------------------------------
//
// Entry/Modify Delivery Note against Sales Order
//
-$page_security = 2;
-$path_to_root="..";
+$page_security = 'SA_SALESDELIVERY';
+$path_to_root = "..";
include_once($path_to_root . "/sales/includes/cart_class.inc");
include_once($path_to_root . "/includes/session.inc");
@@ -25,10 +35,10 @@ if ($use_date_picker) {
if (isset($_GET['ModifyDelivery'])) {
$_SESSION['page_title'] = sprintf(_("Modifying Delivery Note # %d."), $_GET['ModifyDelivery']);
- $help_page_title = _("Modifying Delivery Note");
+ $help_context = "Modifying Delivery Note";
processing_start();
} elseif (isset($_GET['OrderNumber'])) {
- $_SESSION['page_title'] = _("Deliver Items for a Sales Order");
+ $_SESSION['page_title'] = _($help_context = "Deliver Items for a Sales Order");
processing_start();
}
@@ -36,13 +46,15 @@ page($_SESSION['page_title'], false, false, "", $js);
if (isset($_GET['AddedID'])) {
$dispatch_no = $_GET['AddedID'];
- print_hidden_script(13);
- display_notification(_("Dispatch processed:") . ' '.$_GET['AddedID'], true);
+ display_notification_centered(sprintf(_("Delivery # %d has been entered."),$dispatch_no));
- display_note(get_customer_trans_view_str(13, $dispatch_no, _("View this dispatch")), 0, 1);
+ display_note(get_customer_trans_view_str(ST_CUSTDELIVERY, $dispatch_no, _("&View This Delivery")), 0, 1);
- display_note(print_document_link($dispatch_no, _("Print this delivery"), true, 13));
+ display_note(print_document_link($dispatch_no, _("&Print Delivery Note"), true, ST_CUSTDELIVERY));
+ display_note(print_document_link($dispatch_no, _("&Email Delivery Note"), true, ST_CUSTDELIVERY, false, "printlink", "", 1), 1, 1);
+ display_note(print_document_link($dispatch_no, _("P&rint as Packing Slip"), true, ST_CUSTDELIVERY, false, "printlink", "", 0, 1));
+ display_note(print_document_link($dispatch_no, _("E&mail as Packing Slip"), true, ST_CUSTDELIVERY, false, "printlink", "", 1, 1), 1);
display_note(get_gl_view_str(13, $dispatch_no, _("View the GL Journal Entries for this Dispatch")),1);
@@ -55,13 +67,15 @@ if (isset($_GET['AddedID'])) {
} elseif (isset($_GET['UpdatedID'])) {
$delivery_no = $_GET['UpdatedID'];
- print_hidden_script(13);
display_notification_centered(sprintf(_('Delivery Note # %d has been updated.'),$delivery_no));
- display_note(get_trans_view_str(13, $delivery_no, _("View this delivery")));
- echo '
';
- display_note(print_document_link($delivery_no, _("Print this delivery"), true, 13));
+ display_note(get_trans_view_str(ST_CUSTDELIVERY, $delivery_no, _("View this delivery")), 0, 1);
+
+ display_note(print_document_link($delivery_no, _("&Print Delivery Note"), true, ST_CUSTDELIVERY));
+ display_note(print_document_link($delivery_no, _("&Email Delivery Note"), true, ST_CUSTDELIVERY, false, "printlink", "", 1), 1, 1);
+ display_note(print_document_link($delivery_no, _("P&rint as Packing Slip"), true, ST_CUSTDELIVERY, false, "printlink", "", 0, 1));
+ display_note(print_document_link($delivery_no, _("E&mail as Packing Slip"), true, ST_CUSTDELIVERY, false, "printlink", "", 1, 1), 1);
hyperlink_params($path_to_root . "/sales/customer_invoice.php", _("Confirm Delivery and Invoice"), "DeliveryNumber=$delivery_no");
@@ -73,9 +87,7 @@ if (isset($_GET['AddedID'])) {
if (isset($_GET['OrderNumber']) && $_GET['OrderNumber'] > 0) {
- $ord = new Cart(30,$_GET['OrderNumber'], true);
-
- /*read in all the selected order into the Items cart */
+ $ord = new Cart(ST_SALESORDER, $_GET['OrderNumber'], true);
if ($ord->count_items() == 0) {
hyperlink_params($path_to_root . "/sales/inquiry/sales_orders_view.php",
@@ -83,17 +95,16 @@ if (isset($_GET['OrderNumber']) && $_GET['OrderNumber'] > 0) {
die ("
" . _("This order has no items. There is nothing to delivery.") . "");
}
- $ord->trans_type = 13;
- $ord->src_docs = $ord->trans_no;
- $ord->order_no = key($ord->trans_no);
- $ord->trans_no = 0;
- $ord->reference = references::get_next(13);
+ // Adjust Shipping Charge based upon previous deliveries TAM
+ adjust_shipping_charge($ord, $_GET['OrderNumber']);
+
$_SESSION['Items'] = $ord;
copy_from_cart();
} elseif (isset($_GET['ModifyDelivery']) && $_GET['ModifyDelivery'] > 0) {
- $_SESSION['Items'] = new Cart(13,$_GET['ModifyDelivery']);
+ check_is_closed(ST_CUSTDELIVERY, $_GET['ModifyDelivery']);
+ $_SESSION['Items'] = new Cart(ST_CUSTDELIVERY,$_GET['ModifyDelivery']);
if ($_SESSION['Items']->count_items() == 0) {
hyperlink_params($path_to_root . "/sales/inquiry/sales_orders_view.php",
@@ -104,7 +115,7 @@ if (isset($_GET['OrderNumber']) && $_GET['OrderNumber'] > 0) {
}
copy_from_cart();
-
+
} elseif ( !processing_active() ) {
/* This page can only be called with an order number for invoicing*/
@@ -115,41 +126,52 @@ if (isset($_GET['OrderNumber']) && $_GET['OrderNumber'] > 0) {
end_page();
exit;
-} elseif (!check_quantities()) {
- display_error(_("Selected quantity cannot be less than quantity invoiced nor more than quantity
- not dispatched on sales order."));
+} else {
+ check_edit_conflicts();
-} elseif(!check_num('ChargeFreightCost', 0))
- display_error(_("Freight cost cannot be less than zero"));
+ if (!check_quantities()) {
+ display_error(_("Selected quantity cannot be less than quantity invoiced nor more than quantity not dispatched on sales order."));
+ } elseif(!check_num('ChargeFreightCost', 0)) {
+ display_error(_("Freight cost cannot be less than zero"));
+ set_focus('ChargeFreightCost');
+ }
+}
//-----------------------------------------------------------------------------
function check_data()
{
+ global $Refs;
+
if (!isset($_POST['DispatchDate']) || !is_date($_POST['DispatchDate'])) {
display_error(_("The entered date of delivery is invalid."));
+ set_focus('DispatchDate');
return false;
}
if (!is_date_in_fiscalyear($_POST['DispatchDate'])) {
- display_error(_("The entered date of delivery is not in fiscal year."));
+ display_error(_("The entered date is out of fiscal year or is closed for further data entry."));
+ set_focus('DispatchDate');
return false;
}
if (!isset($_POST['due_date']) || !is_date($_POST['due_date'])) {
display_error(_("The entered dead-line for invoice is invalid."));
+ set_focus('due_date');
return false;
}
if ($_SESSION['Items']->trans_no==0) {
- if (!references::is_valid($_POST['ref'])) {
+ if (!$Refs->is_valid($_POST['ref'])) {
display_error(_("You must enter a reference."));
+ set_focus('ref');
return false;
}
- if ($_SESSION['Items']->trans_no==0 && !is_new_reference($_POST['ref'], 13)) {
+ if ($_SESSION['Items']->trans_no==0 && !is_new_reference($_POST['ref'], ST_CUSTDELIVERY)) {
display_error(_("The entered reference is already in use."));
+ set_focus('ref');
return false;
}
}
@@ -159,6 +181,7 @@ function check_data()
if (!check_num('ChargeFreightCost',0)) {
display_error(_("The entered shipping value is not numeric."));
+ set_focus('ChargeFreightCost');
return false;
}
@@ -168,8 +191,6 @@ function check_data()
}
if (!check_quantities()) {
- display_error(_("Selected quantity cannot be less than quantity invoiced nor more than quantity
- not dispatched on sales order."));
return false;
}
@@ -181,12 +202,14 @@ function copy_to_cart()
$cart = &$_SESSION['Items'];
$cart->ship_via = $_POST['ship_via'];
$cart->freight_cost = input_num('ChargeFreightCost');
- $cart->document_date = $_POST['DispatchDate'];
+ $cart->document_date = $_POST['DispatchDate'];
$cart->due_date = $_POST['due_date'];
$cart->Location = $_POST['Location'];
$cart->Comments = $_POST['Comments'];
+ $cart->dimension_id = $_POST['dimension_id'];
+ $cart->dimension2_id = $_POST['dimension2_id'];
if ($cart->trans_no == 0)
- $dn->ref = $_POST['ref'];
+ $cart->reference = $_POST['ref'];
}
//------------------------------------------------------------------------------
@@ -196,10 +219,14 @@ function copy_from_cart()
$cart = &$_SESSION['Items'];
$_POST['ship_via'] = $cart->ship_via;
$_POST['ChargeFreightCost'] = price_format($cart->freight_cost);
- $_POST['DispatchDate']= $cart->document_date;
+ $_POST['DispatchDate'] = $cart->document_date;
$_POST['due_date'] = $cart->due_date;
- $_POST['Location']= $cart->Location;
- $_POST['Comments']= $cart->Comments;
+ $_POST['Location'] = $cart->Location;
+ $_POST['Comments'] = $cart->Comments;
+ $_POST['dimension_id'] = $cart->dimension_id;
+ $_POST['dimension2_id'] = $cart->dimension2_id;
+ $_POST['cart_id'] = $cart->cart_id;
+ $_POST['ref'] = $cart->reference;
}
//------------------------------------------------------------------------------
@@ -209,10 +236,19 @@ function check_quantities()
// Update cart delivery quantities/descriptions
foreach ($_SESSION['Items']->line_items as $line=>$itm) {
if (isset($_POST['Line'.$line])) {
- if (!check_num('Line'.$line, $itm->qty_done, $itm->quantity) == 0) {
- $_SESSION['Items']->line_items[$line]->qty_dispatched =
+ if($_SESSION['Items']->trans_no) {
+ $min = $itm->qty_done;
+ $max = $itm->quantity;
+ } else {
+ $min = 0;
+ $max = $itm->quantity - $itm->qty_done;
+ }
+
+ if (check_num('Line'.$line, $min, $max)) {
+ $_SESSION['Items']->line_items[$line]->qty_dispatched =
input_num('Line'.$line);
} else {
+ set_focus('Line'.$line);
$ok = 0;
}
@@ -234,22 +270,35 @@ function check_quantities()
function check_qoh()
{
- if (!sys_prefs::allow_negative_stock()) {
- foreach ($_SESSION['Items']->line_items as $itm) {
-
- if ($itm->qty_dispatched && has_stock_holding($itm->mb_flag)) {
- $qoh = get_qoh_on_date($itm->stock_id, $_POST['Location'], $_POST['DispatchDate']);
-
- if ($itm->qty_dispatched > $qoh) {
- display_error(_("The delivery cannot be processed because there is an insufficient quantity for item:") .
- " " . $itm->stock_id . " - " . $itm->item_description);
- return false;
- }
- }
- }
- }
- return true;
+ global $SysPrefs;
+ $dn = &$_SESSION['Items'];
+ $newdelivery = ($dn->trans_no==0);
+ if (!$SysPrefs->allow_negative_stock()) {
+ foreach ($_SESSION['Items']->line_items as $itm) {
+
+ if ($itm->qty_dispatched && has_stock_holding($itm->mb_flag)) {
+ $qoh_by_date = get_qoh_on_date($itm->stock_id, $_POST['Location'], $_POST['DispatchDate']);
+ $qoh_abs = get_qoh_on_date($itm->stock_id, $_POST['Location'], null);
+ //If editing current delivery delivered qty should be added
+ if (!$newdelivery)
+ {
+ $delivered = get_already_delivered($itm->stock_id, $_POST['Location'], key($dn->trans_no));
+
+ $qoh_abs = $qoh_abs - $delivered;
+ $qoh_by_date = $qoh_by_date - $delivered;
+ }
+ $qoh = ($qoh_by_date < $qoh_abs ? $qoh_by_date : $qoh_abs);
+ if ($itm->qty_dispatched > $qoh) {
+ display_error(_("The delivery cannot be processed because there is an insufficient quantity for item:") .
+ " " . $itm->stock_id . " - " . $itm->item_description);
+ return false;
+ }
+ }
+ }
+ }
+ return true;
}
+
//------------------------------------------------------------------------------
if (isset($_POST['process_delivery']) && check_data() && check_qoh()) {
@@ -264,6 +313,7 @@ if (isset($_POST['process_delivery']) && check_data() && check_qoh()) {
$newdelivery = ($dn->trans_no == 0);
copy_to_cart();
+ if ($newdelivery) new_doc_date($dn->document_date);
$delivery_no = $dn->write($bo_policy);
processing_end();
@@ -274,13 +324,17 @@ if (isset($_POST['process_delivery']) && check_data() && check_qoh()) {
}
}
+if (isset($_POST['Update']) || isset($_POST['_Location_update'])) {
+ $Ajax->activate('Items');
+}
//------------------------------------------------------------------------------
-start_form(false, true);
+start_form();
+hidden('cart_id');
-start_table("$table_style2 width=80%", 5);
+start_table(TABLESTYLE2, "width=80%", 5);
echo "