X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;ds=sidebyside;f=inventory%2Ftransfers.php;h=12f19d28f8682c635cc91d957e5750c7f220e4e5;hb=d735235be078e107597bad3fbcfef25943076a5f;hp=b76557a0fb6aa9e27ccdbdb45eb7d8b220e2f97f;hpb=5cae8206ae7eaf4df4b95b7f2184e2332f85ec8d;p=fa-stable.git

diff --git a/inventory/transfers.php b/inventory/transfers.php
index b76557a0..12f19d28 100644
--- a/inventory/transfers.php
+++ b/inventory/transfers.php
@@ -1,7 +1,16 @@
 <?php
-
-$page_security = 3;
-$path_to_root="..";
+/**********************************************************************
+    Copyright (C) FrontAccounting, LLC.
+	Released under the terms of the GNU General Public License, GPL, 
+	as published by the Free Software Foundation, either version 3 
+	of the License, or (at your option) any later version.
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  
+    See the License here <http://www.gnu.org/licenses/gpl-3.0.html>.
+***********************************************************************/
+$page_security = 'SA_LOCATIONTRANSFER';
+$path_to_root = "..";
 include_once($path_to_root . "/includes/ui/items_cart.inc");
 
 include_once($path_to_root . "/includes/session.inc");
@@ -12,29 +21,27 @@ include_once($path_to_root . "/includes/data_checks.inc");
 include_once($path_to_root . "/inventory/includes/stock_transfers_ui.inc");
 include_once($path_to_root . "/inventory/includes/inventory_db.inc");
 $js = "";
-if ($use_popup_windows)
+if ($SysPrefs->use_popup_windows)
 	$js .= get_js_open_window(800, 500);
-if ($use_date_picker)
+if (user_use_date_picker())
 	$js .= get_js_date_picker();
-page(_("Inventory Location Transfers"), false, false, "", $js);
+page(_($help_context = "Inventory Location Transfers"), false, false, "", $js);
 
 //-----------------------------------------------------------------------------------------------
 
 check_db_has_costable_items(_("There are no inventory items defined in the system (Purchased or manufactured items)."));
 
-check_db_has_movement_types(_("There are no inventory movement types defined in the system. Please define at least one inventory adjustment type."));
-
 //-----------------------------------------------------------------------------------------------
 
 if (isset($_GET['AddedID'])) 
 {
 	$trans_no = $_GET['AddedID'];
-	$trans_type = systypes::location_transfer();
+	$trans_type = ST_LOCTRANSFER;
 
 	display_notification_centered(_("Inventory transfer has been processed"));
-	display_note(get_trans_view_str($trans_type, $trans_no, _("View this transfer")));
+	display_note(get_trans_view_str($trans_type, $trans_no, _("&View this transfer")));
 
-	hyperlink_no_params($_SERVER['PHP_SELF'], _("Enter Another Inventory Transfer"));
+	hyperlink_no_params($_SERVER['PHP_SELF'], _("Enter &Another Inventory Transfer"));
 
 	display_footer_exit();
 }
@@ -46,27 +53,6 @@ function line_start_focus() {
   $Ajax->activate('items_table');
   set_focus('_stock_id_edit');
 }
-//--------------------------------------------------------------------------------------------------
-
-function copy_to_st()
-{
-	$_SESSION['transfer_items']->from_loc = $_POST['FromStockLocation'];
-	$_SESSION['transfer_items']->to_loc = $_POST['ToStockLocation'];
-	$_SESSION['transfer_items']->tran_date = $_POST['AdjDate'];
-	$_SESSION['transfer_items']->transfer_type = $_POST['type'];
-	$_SESSION['transfer_items']->memo_ = $_POST['memo_'];
-}
-//--------------------------------------------------------------------------------------------------
-
-function copy_from_st()
-{
-	$_POST['FromStockLocation'] = $_SESSION['transfer_items']->from_loc;
-	$_POST['ToStockLocation'] = $_SESSION['transfer_items']->to_loc;
-	$_POST['AdjDate'] = $_SESSION['transfer_items']->tran_date;
-	$_POST['type'] = $_SESSION['transfer_items']->transfer_type;
-	$_POST['memo_'] = $_SESSION['transfer_items']->memo_;
-}
-
 //-----------------------------------------------------------------------------------------------
 
 function handle_new_order()
@@ -77,10 +63,8 @@ function handle_new_order()
 		unset ($_SESSION['transfer_items']);
 	}
 
-    session_register("transfer_items");
-
-	$_SESSION['transfer_items'] = new items_cart;
-	$_POST['AdjDate'] = Today();
+	$_SESSION['transfer_items'] = new items_cart(ST_LOCTRANSFER);
+	$_POST['AdjDate'] = new_doc_date();
 	if (!is_date_in_fiscalyear($_POST['AdjDate']))
 		$_POST['AdjDate'] = end_fiscalyear();
 	$_SESSION['transfer_items']->tran_date = $_POST['AdjDate'];	
@@ -97,29 +81,22 @@ if (isset($_POST['Process']))
 	if (count($tr->line_items) == 0)	{
 		display_error(_("You must enter at least one non empty item line."));
 		set_focus('stock_id');
-		return false;
-	}
-	if (!references::is_valid($_POST['ref'])) 
-	{
-		display_error(_("You must enter a reference."));
-		set_focus('ref');
 		$input_error = 1;
-	} 
-	elseif (!is_new_reference($_POST['ref'], systypes::location_transfer())) 
+	}
+	if (!check_reference($_POST['ref'], ST_LOCTRANSFER))
 	{
-		display_error(_("The entered reference is already in use."));
 		set_focus('ref');
 		$input_error = 1;
 	} 
 	elseif (!is_date($_POST['AdjDate'])) 
 	{
-		display_error(_("The entered date for the adjustment is invalid."));
+		display_error(_("The entered transfer date is invalid."));
 		set_focus('AdjDate');
 		$input_error = 1;
 	} 
 	elseif (!is_date_in_fiscalyear($_POST['AdjDate'])) 
 	{
-		display_error(_("The entered date is not in fiscal year."));
+		display_error(_("The entered date is out of fiscal year or is closed for further data entry."));
 		set_focus('AdjDate');
 		$input_error = 1;
 	} 
@@ -128,17 +105,14 @@ if (isset($_POST['Process']))
 		display_error(_("The locations to transfer from and to must be different."));
 		set_focus('FromStockLocation');
 		$input_error = 1;
-	} 
-	else 
+	}
+	elseif (!$SysPrefs->allow_negative_stock())
 	{
-		$failed_item = $tr->check_qoh($_POST['FromStockLocation'], $_POST['AdjDate'], true);
-		if ($failed_item >= 0) 
+		$low_stock = $tr->check_qoh($_POST['FromStockLocation'], $_POST['AdjDate'], true);
+
+		if ($low_stock)
 		{
-			$line = $tr->line_items[$failed_item];
-        	display_error(_("The quantity entered is greater than the available quantity for this item at the source location :") .
-        		" " . $line->stock_id . " - " .  $line->item_description);
-        	echo "<br>";
-			$_POST['Edit'.$failed_item] = 1; // enter edit mode
+    		display_error(_("The transfer cannot be processed because it would cause negative inventory balance in source location for marked items as of document date or later."));
 			$input_error = 1;
 		}
 	}
@@ -154,8 +128,8 @@ if (isset($_POST['Process']))
 
 	$trans_no = add_stock_transfer($_SESSION['transfer_items']->line_items,
 		$_POST['FromStockLocation'], $_POST['ToStockLocation'],
-		$_POST['AdjDate'], $_POST['type'], $_POST['ref'], $_POST['memo_']);
-
+		$_POST['AdjDate'], $_POST['ref'], $_POST['memo_']);
+	new_doc_date($_POST['AdjDate']);
 	$_SESSION['transfer_items']->clear_items();
 	unset($_SESSION['transfer_items']);
 
@@ -166,7 +140,7 @@ if (isset($_POST['Process']))
 
 function check_item_data()
 {
-	if (!check_num('qty', 0))
+	if (!check_num('qty', 0) || input_num('qty') == 0)
 	{
 		display_error(_("The quantity entered must be a positive number."));
 		set_focus('qty');
@@ -179,13 +153,10 @@ function check_item_data()
 
 function handle_update_item()
 {
-    if($_POST['UpdateItem'] != "" && check_item_data())
-    {
-		$id = $_POST['LineNo'];
-    	if (!isset($_POST['std_cost']))
-    		$_POST['std_cost'] = $_SESSION['transfer_items']->line_items[$id]->standard_cost;
-    	$_SESSION['transfer_items']->update_cart_item($id, input_num('qty'), $_POST['std_cost']);
-    }
+	$id = $_POST['LineNo'];
+   	if (!isset($_POST['std_cost']))
+   		$_POST['std_cost'] = $_SESSION['transfer_items']->line_items[$id]->standard_cost;
+   	$_SESSION['transfer_items']->update_cart_item($id, input_num('qty'), $_POST['std_cost']);
 	line_start_focus();
 }
 
@@ -201,8 +172,6 @@ function handle_delete_item($id)
 
 function handle_new_item()
 {
-	if (!check_item_data())
-		return;
 	if (!isset($_POST['std_cost']))
    		$_POST['std_cost'] = 0;
 	add_to_order($_SESSION['transfer_items'], $_POST['stock_id'], input_num('qty'), $_POST['std_cost']);
@@ -213,19 +182,11 @@ function handle_new_item()
 $id = find_submit('Delete');
 if ($id != -1)
 	handle_delete_item($id);
-
-//if (isset($_GET['Delete']) || isset($_GET['Edit']))
-//	copy_from_st();
-
-if (isset($_POST['AddItem']) || isset($_POST['UpdateItem'])) {
-  	copy_to_st();
-	line_start_focus();
-}
 	
-if (isset($_POST['AddItem']))
+if (isset($_POST['AddItem']) && check_item_data())
 	handle_new_item();
 
-if (isset($_POST['UpdateItem']))
+if (isset($_POST['UpdateItem']) && check_item_data())
 	handle_update_item();
 
 if (isset($_POST['CancelItemChanges'])) {
@@ -239,11 +200,11 @@ if (isset($_GET['NewTransfer']) || !isset($_SESSION['transfer_items']))
 }
 
 //-----------------------------------------------------------------------------------------------
-start_form(false, true);
+start_form();
 
 display_order_header($_SESSION['transfer_items']);
 
-start_table("$table_style width=70%", 10);
+start_table(TABLESTYLE, "width='70%'", 10);
 start_row();
 echo "<td>";
 display_transfer_items(_("Items"), $_SESSION['transfer_items']);
@@ -252,10 +213,9 @@ echo "</td>";
 end_row();
 end_table(1);
 
-submit_center_first('Update', _("Update"), '', true);
-submit_center_last('Process', _("Process Transfer"), '', true);
+submit_center_first('Update', _("Update"), '', null);
+submit_center_last('Process', _("Process Transfer"), '',  'default');
 
 end_form();
 end_page();
 
-?>