X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=admin%2Fvoid_transaction.php;h=3016e88d9bf2643dfffe35eaa487ac10109be939;hb=f425362379fe66e2b0f17b6e4f09d8d9bdf6c5f2;hp=110516072153c1e09b54562f54c022a5177dd508;hpb=17b390efcf904072b02ec866b2a427490471a260;p=fa-stable.git diff --git a/admin/void_transaction.php b/admin/void_transaction.php index 11051607..3016e88d 100644 --- a/admin/void_transaction.php +++ b/admin/void_transaction.php @@ -73,7 +73,7 @@ function exist_transaction($type, $type_no) return false; case ST_SUPPRECEIVE : // it's a GRN - if (exists_grn_on_invoices($type_no)) + if (!exists_grn($type_no)) return false; break; @@ -104,7 +104,6 @@ function exist_transaction($type, $type_no) return false; case ST_COSTUPDATE : // it's a stock cost update return false; - break; } return true; @@ -241,7 +240,7 @@ function check_valid_entries() { display_error(_("The selected transaction was closed for edition and cannot be voided.")); set_focus('trans_no'); - return; + return false; } if (!is_date($_POST['date_'])) { @@ -251,7 +250,7 @@ function check_valid_entries() } if (!is_date_in_fiscalyear($_POST['date_'])) { - display_error(_("The entered date is not in fiscal year.")); + display_error(_("The entered date is out of fiscal year or is closed for further data entry.")); set_focus('date_'); return false; } @@ -283,10 +282,10 @@ function handle_void_transaction() return; } - $ret = void_transaction($_POST['filterType'], $_POST['trans_no'], + $msg = void_transaction($_POST['filterType'], $_POST['trans_no'], $_POST['date_'], $_POST['memo_']); - if ($ret) + if (!$msg) { display_notification_centered(_("Selected transaction has been voided.")); unset($_POST['trans_no']); @@ -294,7 +293,7 @@ function handle_void_transaction() unset($_POST['date_']); } else { - display_error(_("The entered transaction does not exist or cannot be voided.")); + display_error($msg); set_focus('trans_no'); }