X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=gl%2Fincludes%2Fdb%2Fgl_db_bank_trans.inc;h=de2ce4862920f121b5d256b89b5c79c63855f6d9;hb=19b77e12bf5c056e3141032c62cc8d9ad7a21d6e;hp=88cdc5557037a8209e52afec5fa448cad79591e9;hpb=da8311619dd73feae101d246a1957b972e00cbd2;p=fa-stable.git

diff --git a/gl/includes/db/gl_db_bank_trans.inc b/gl/includes/db/gl_db_bank_trans.inc
index 88cdc555..de2ce486 100644
--- a/gl/includes/db/gl_db_bank_trans.inc
+++ b/gl/includes/db/gl_db_bank_trans.inc
@@ -1,40 +1,49 @@
 <?php
-
+/**********************************************************************
+    Copyright (C) FrontAccounting, LLC.
+	Released under the terms of the GNU General Public License, GPL, 
+	as published by the Free Software Foundation, either version 3 
+	of the License, or (at your option) any later version.
+    This program is distributed in the hope that it will be useful,
+    but WITHOUT ANY WARRANTY; without even the implied warranty of
+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  
+    See the License here <http://www.gnu.org/licenses/gpl-3.0.html>.
+***********************************************************************/
 //----------------------------------------------------------------------------------
 
 // add a bank transaction
 // $amount is in $currency
 // $date_ is display date (non-sql)
 
-function add_bank_trans($type, $trans_no, $bank_act, $ref, $date_, $bank_trans_type_id, 
+function add_bank_trans($type, $trans_no, $bank_act, $ref, $date_,
 	$amount, $person_type_id, $person_id, $currency="", $err_msg="")
 {
 	$sqlDate = date2sql($date_);
-	
+
 	// convert $amount to the bank's currency
-	if ($currency != "") 
+	if ($currency != "")
 	{
     	$bank_account_currency = get_bank_account_currency($bank_act);
     	$to_bank_currency = get_exchange_rate_from_to($currency, $bank_account_currency, $date_);
     	$amount_bank = ($amount / $to_bank_currency);
-	} 
+	}
 	else
-		$amount_bank = $amount;		
-	
-	
+		$amount_bank = $amount;
+
+
 	// Also store the rate to the home
 	//$BankToHomeCurrencyRate = get_exchange_rate_to_home_currency($bank_account_currency, $date_);
-		
-	$sql = "INSERT INTO ".TB_PREF."bank_trans (type, trans_no, bank_act, ref,  
-		trans_date, bank_trans_type_id, amount, person_type_id, person_id) ";
-	
-	$sql .= "VALUES ($type, $trans_no, $bank_act, '$ref', '$sqlDate', '$bank_trans_type_id', 
-		$amount_bank, $person_type_id, '$person_id')";
-						
+
+	$sql = "INSERT INTO ".TB_PREF."bank_trans (type, trans_no, bank_act, ref,
+		trans_date, amount, person_type_id, person_id) ";
+
+	$sql .= "VALUES ($type, $trans_no, '$bank_act', ".db_escape($ref).", '$sqlDate',
+		$amount_bank, $person_type_id, ". db_escape($person_id).")";
+
 	if ($err_msg == "")
 		$err_msg = "The bank transaction could not be inserted";
-		
-	db_query($sql, $err_msg);		
+
+	db_query($sql, $err_msg);
 }
 
 //----------------------------------------------------------------------------------------
@@ -43,29 +52,28 @@ function exists_bank_trans($type, $type_no)
 {
 	$sql = "SELECT trans_no FROM ".TB_PREF."bank_trans WHERE type=$type
 		AND trans_no=$type_no";
-	$result = db_query($sql, "Cannot retreive a bank transaction");	
-	
-    return (db_num_rows($result) > 0);				
+	$result = db_query($sql, "Cannot retreive a bank transaction");
+
+    return (db_num_rows($result) > 0);
 }
 
 //----------------------------------------------------------------------------------------
 
 function get_bank_trans($type, $trans_no=null, $person_type_id=null, $person_id=null)
 {
-	$sql = "SELECT *, bank_account_name, account_code, bank_curr_code, name AS BankTransType 
-		FROM ".TB_PREF."bank_trans, ".TB_PREF."bank_accounts, ".TB_PREF."bank_trans_types 
-		WHERE ".TB_PREF."bank_trans_types.id = ".TB_PREF."bank_trans.bank_trans_type_id
-		AND ".TB_PREF."bank_accounts.account_code=".TB_PREF."bank_trans.bank_act ";
-	if ($type != null)				
+	$sql = "SELECT *, bank_account_name, account_code, bank_curr_code
+		FROM ".TB_PREF."bank_trans, ".TB_PREF."bank_accounts
+		WHERE ".TB_PREF."bank_accounts.id=".TB_PREF."bank_trans.bank_act ";
+	if ($type != null)
 		$sql .= " AND type=$type ";
 	if ($trans_no != null)
-		$sql .= " AND ".TB_PREF."bank_trans.trans_no = $trans_no ";				
+		$sql .= " AND ".TB_PREF."bank_trans.trans_no = $trans_no ";
 	if ($person_type_id != null)
 		$sql .= " AND ".TB_PREF."bank_trans.person_type_id = $person_type_id ";
 	if ($person_id != null)
-		$sql .= " AND ".TB_PREF."bank_trans.person_id = '$person_id'";					
+		$sql .= " AND ".TB_PREF."bank_trans.person_id = '$person_id'";
 	$sql .= " ORDER BY trans_date, ".TB_PREF."bank_trans.id";
-			
+
 	return db_query($sql, "query for bank transaction");
 }
 
@@ -73,10 +81,10 @@ function get_bank_trans($type, $trans_no=null, $person_type_id=null, $person_id=
 
 function get_gl_trans_value($account, $type, $trans_no)
 {
-	$sql = "SELECT SUM(amount) FROM ".TB_PREF."gl_trans WHERE account=$account AND type=$type AND type_no=$trans_no";
-	
+	$sql = "SELECT SUM(amount) FROM ".TB_PREF."gl_trans WHERE account='$account' AND type=$type AND type_no=$trans_no";
+
 	$result = db_query($sql, "query for gl trans value");
-	
+
 	$row = db_fetch_row($result);
 	return $row[0];
 }
@@ -87,22 +95,24 @@ function void_bank_trans($type, $type_no, $nested=false)
 {
 	if (!$nested)
 		begin_transaction();
-	
-	$sql = "UPDATE ".TB_PREF."bank_trans SET amount=0 
+
+	$sql = "UPDATE ".TB_PREF."bank_trans SET amount=0
 		WHERE type=$type AND trans_no=$type_no";
-				
+
 	$result = db_query($sql, "could not void bank transactions for type=$type and trans_no=$type_no");
-	
+
 	void_gl_trans($type, $type_no, true);
-	
+
 	// in case it's a customer trans - probably better to check first
 	void_cust_allocations($type, $type_no);
 	void_customer_trans($type, $type_no);
-	
+
 	// in case it's a supplier trans - probably better to check first
 	void_supp_allocations($type, $type_no);
 	void_supp_trans($type, $type_no);
-	
+
+	void_trans_tax_details($type, $type_no);
+
 	if (!$nested)
 		commit_transaction();
 }