X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=includes%2Fdb%2Faudit_trail_db.inc;h=6aa91d9833689c0fdfd4db3a70f2f653f747ab08;hb=443214a800fa66cd1473b48f6fadd1b09144a5d4;hp=c25fdc5111526228c42f858afa8ed8756123b524;hpb=fbf51ab0febfd0885620abcab8738339d156ff45;p=fa-stable.git

diff --git a/includes/db/audit_trail_db.inc b/includes/db/audit_trail_db.inc
index c25fdc51..6aa91d98 100644
--- a/includes/db/audit_trail_db.inc
+++ b/includes/db/audit_trail_db.inc
@@ -12,6 +12,8 @@
 
 function add_audit_trail($trans_type, $trans_no, $trans_date, $descr='')
 {
+	begin_transaction();
+
 	$date = date2sql($trans_date);
 	$sql = "INSERT INTO ".TB_PREF."audit_trail"
 		. " (type, trans_no, user, gl_date, description)
@@ -29,6 +31,7 @@ function add_audit_trail($trans_type, $trans_no, $trans_date, $descr='')
 		. db_escape($trans_no);
 
 	db_query($sql, "Cannot update audit gl_seq");
+	commit_transaction();
 }
 
 function get_audit_trail_all($trans_type, $trans_no)
@@ -104,26 +107,33 @@ function close_transactions($todate) {
 	return $errors;
 }
 
-/*
-	Closed transactions have gl_seq number assigned.
-*/
-function is_closed_trans($type, $trans_no) {
+function get_journal_number($type, $trans_no) {
 
 	$cdate = get_company_pref('gl_closing_date');
 	if (!$cdate)
 		return false;
 
 // FIXME: gl_date can be badly entered for some transactions due to bug in previous FA versions 
-	$sql = "SELECT	gl_seq  FROM ".TB_PREF."audit_trail"
+	$sql = "SELECT	MAX(gl_seq) as gl_seq  FROM ".TB_PREF."audit_trail"
 		. " WHERE type=".db_escape($type)
 		." AND trans_no=".db_escape($trans_no)
 		." AND gl_date<='$cdate'"; // date is stored in sql format
 //		." AND (gl_date<='$cdate'" // some transaction can be not sequenced due to 0 amount, however after edition this could change
 //		." OR gl_seq>0)";
-
 	$res = db_query($sql, "Cannot check transaction");
+	if (db_num_rows($res))
+	{
+		$myrow =db_fetch($res);
+		return $myrow['gl_seq'] ? $myrow['gl_seq'] : _('None');
+	}
+	return "-";
+}
+
+/*
+	Closed transactions have gl_seq number assigned.
+*/
+function is_closed_trans($type, $trans_no) {
 
-	return db_num_rows($res);
+	return get_journal_number($type, $trans_no) > 0;
 }
 
-?>