X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=includes%2Fdb%2Finventory_db.inc;h=96d7b8acfca864eb85efee533b1092ca03c507b6;hb=22486f7826944e00937e7ccceab1a927c94d8f6a;hp=244cf93c2e14769838f1fd949bbe31b8f35c196c;hpb=19d08aef75bd8960f1f0452303750ed0387fb1b8;p=fa-stable.git diff --git a/includes/db/inventory_db.inc b/includes/db/inventory_db.inc index 244cf93c..96d7b8ac 100644 --- a/includes/db/inventory_db.inc +++ b/includes/db/inventory_db.inc @@ -9,43 +9,75 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the License here . ***********************************************************************/ -function get_qoh_on_date($stock_id, $location=null, $date_=null, $exclude=0) +function get_qoh_on_date($stock_id, $location=null, $date_=null) { if ($date_ == null) - { - $sql = "SELECT SUM(qty) FROM ".TB_PREF."stock_moves - WHERE stock_id=".db_escape($stock_id); $date_ = Today(); - $date = date2sql($date_); - } - else - { - $date = date2sql($date_); - $sql = "SELECT SUM(qty) FROM ".TB_PREF."stock_moves + + $date = date2sql($date_); + + $sql = "SELECT SUM(qty) FROM ".TB_PREF."stock_moves WHERE stock_id=".db_escape($stock_id)." AND tran_date <= '$date'"; - } - + if ($location != null) $sql .= " AND loc_code = ".db_escape($location); - $result = db_query($sql, "QOH calulcation failed"); + $result = db_query($sql, "QOH calculation failed"); $myrow = db_fetch_row($result); - if ($exclude > 0) - { - $sql = "SELECT SUM(qty) FROM ".TB_PREF."stock_moves - WHERE stock_id=".db_escape($stock_id) - ." AND type=".db_escape($exclude) - ." AND tran_date = '$date'"; - - $result = db_query($sql, "QOH calulcation failed"); - $myrow2 = db_fetch_row($result); - if ($myrow2 !== false) - $myrow[0] -= $myrow2[0]; - } - return $myrow[0]; + $qoh = $myrow[0]; + return $qoh ? $qoh : 0; +} + +/** +* Check whether change in stock on date would not cause negative qoh in stock history. +* Returns null on success or max. available quantity with respective date otherwise. +* Running balance is checked on daily basis only, as we do not control time of transaction. +* +* $delta_qty - tested change in stock qty at $date. +* $date - check date; when set to null checks all the stock history. +**/ + +function check_negative_stock($stock_id, $delta_qty, $location=null, $date=null) +{ + + if ($delta_qty >= 0) + return null; // qty increese is always safe + + if (!isset($date)) + $date = Today(); + + $date = date2sql($date); + + // check stock status on date + $sql = "SELECT SUM(qty) qty, '$date' tran_date FROM ".TB_PREF."stock_moves + WHERE stock_id=".db_escape($stock_id)." + AND tran_date <= '$date'"; + + if ($location) + $sql .= " AND loc_code = ".db_escape($location); + + $result = db_query($sql, "QOH calculation failed"); + $qos = db_fetch_assoc($result); + + // check also all stock changes after the date to avoid negative stock in future + $sql = TB_PREF."stock_moves WHERE stock_id=".db_escape($stock_id) . " AND tran_date > '$date'"; + + if ($location) + $sql .= " AND loc_code=".db_escape($location); + + $rt = running_total_sql($sql, 'qty', 'tran_date'); + + $sql = "SELECT {$qos['qty']}+total qty, tran_date FROM ($rt) stock_status ORDER by total, tran_date"; + $history = db_query($sql, 'cannot check stock history'); + $min_qos = db_fetch($history); + + if ($min_qos && ($min_qos['qty'] < $qos['qty'])) + $qos = $min_qos; + + return -$delta_qty > $qos['qty'] ? $qos : null; } //-------------------------------------------------------------------------------------- @@ -65,7 +97,6 @@ function get_item_edit_info($stock_id) function get_standard_cost($stock_id) { - //Chaitanya : Compatibility with service items $sql = "SELECT (material_cost + labour_cost + overhead_cost) AS std_cost FROM ".TB_PREF."stock_master s WHERE stock_id=".db_escape($stock_id); $result = db_query($sql, "The standard cost cannot be retrieved"); @@ -107,7 +138,6 @@ function last_negative_stock_begin_date($stock_id, $to) } //------------------------------------------------------------------- -// Newly written function get_already_delivered($stock_id, $location, $trans_no) { @@ -131,7 +161,7 @@ function last_negative_stock_trans_id($stock_id, $to) $qty = 0; $flag = 0; - $negative_trans_id = 1; + $negative_trans_id = -1; while ($myrow = db_fetch($result)) { @@ -145,7 +175,10 @@ function last_negative_stock_trans_id($stock_id, $to) $flag = 0; } - return $negative_trans_id; + if ($flag == 1) + return $negative_trans_id; + else + return false; } //------------------------------------------------------------------- @@ -162,39 +195,23 @@ function get_deliveries_between($stock_id, $from, $to) return db_fetch_row($result); } -//Newly written function get_deliveries_from_trans($stock_id, $from) { // -ve qty is delivery either by ST_CUSTDELIVERY or inventory adjustment - $sql = "SELECT SUM(-qty), SUM(-qty*standard_cost) FROM ".TB_PREF."stock_moves - WHERE stock_id=".db_escape($stock_id)." AND qty < 0 AND - trans_id>='$from' GROUP BY stock_id"; + //Price for GRN and SUPPCREDIT and std_cost for other trans_types + $sql = "SELECT SUM(-qty), SUM(-qty*IF(type=".ST_SUPPRECEIVE." OR type=".ST_SUPPCREDIT.", price, standard_cost)) + FROM ".TB_PREF."stock_moves + WHERE stock_id=".db_escape($stock_id)." AND qty < 0 AND + trans_id>='$from' GROUP BY stock_id"; $result = db_query($sql, "The deliveries could not be updated"); $row = db_fetch_row($result); - display_notification('Row0 - '.$row[0].' Row1- '.$row[1]); - - //return $row; - - // Get Std cost of previsous transaction before the cut-over delivery - // This is useful to get inventory valuation - //Chaitanya : Corrected - /*$sql = "SELECT max( `trans_id` ) - FROM ".TB_PREF."stock_moves - WHERE stock_id = ".db_escape($stock_id)." - AND trans_id<'$from'"; - $result = db_query($sql, "The deliveries could not be updated"); - $trans = db_fetch_row($result); - $prev_trans = $trans[0];*/ - - display_notification('From - '.$from); - $sql = "SELECT standard_cost FROM ".TB_PREF."stock_moves - WHERE stock_id=".db_escape($stock_id) - ." AND trans_id ='$from'"; - $result = db_query($sql, "The deliveries could not be updated"); - $cost = db_fetch_row($result); - - display_notification('Last Delivery Cost - '.$cost[0]); + $sql = "SELECT IF(type=".ST_SUPPRECEIVE." OR type=".ST_SUPPCREDIT.", price, standard_cost) + FROM ".TB_PREF."stock_moves + WHERE stock_id=".db_escape($stock_id) + ." AND trans_id ='$from'"; + $result = db_query($sql, "The deliveries could not be updated"); + $cost = db_fetch_row($result); // Adjusting QOH valuation $sql = "SELECT SUM(qty) FROM ".TB_PREF."stock_moves @@ -203,75 +220,33 @@ function get_deliveries_from_trans($stock_id, $from) $result = db_query($sql, "The deliveries could not be updated"); $qoh = db_fetch_row($result); - display_notification('QOH before last delivery - '.$qoh[0]); - - $qty = $row[0] - $qoh[0]; //Qoh is minus from delivered in -ve + $qty = $row[0] - $qoh[0]; //QOH prior to -ve stock is subtracted $final_cost = $row[1] - $qoh[0]*$cost[0]; - display_notification('Qty - '.$qty.' cost- '.$final_cost); - return array($qty,$final_cost); } -//Newly written function get_purchases_from_trans($stock_id, $from) { // Calculate All inward stock moves i.e. qty > 0 $sql = "SELECT SUM(qty), SUM(qty*standard_cost) FROM ".TB_PREF."stock_moves WHERE stock_id=".db_escape($stock_id)." AND qty > 0 AND trans_id>'$from' GROUP BY stock_id"; - display_notification($sql); $result = db_query($sql, "Could not get get_purchases_from_trans"); $row = db_fetch_row($result); - display_notification('Purchase Qty - '.$row[0].' Cost- '.$row[1]); - return $row; } //------------------------------------------------------------------- -/* Original Code V0 Leave as is a while -function adjust_deliveries_v0($stock_id, $material_cost, $to) -{ - if (!is_inventory_item($stock_id)) - return; - $from = last_negative_stock_begin_date($stock_id, $to); - if ($from == false || $from == "") - return; - $from = sql2date($from); - $row = get_deliveries_between($stock_id, $from, $to); - if ($row == false) - return; - $old_cost = $row[1]; - $new_cost = $row[0] * $material_cost; - $diff = $new_cost - $old_cost; - if ($diff != 0) - { - $update_no = get_next_trans_no(ST_COSTUPDATE); - if (!is_date_in_fiscalyear($to)) - $to = end_fiscalyear(); - - $stock_gl_code = get_stock_gl_code($stock_id); - - $memo_ = sprintf(_("Cost was %s changed to %s for item '%s'"), - $old_cost, $new_cost, $stock_id); - add_gl_trans_std_cost(ST_COSTUPDATE, $update_no, $to, $stock_gl_code["cogs_account"], - $stock_gl_code["dimension_id"], $stock_gl_code["dimension2_id"], $memo_, $diff); - add_gl_trans_std_cost(ST_COSTUPDATE, $update_no, $to, $stock_gl_code["inventory_account"], - 0, 0, $memo_, -$diff); - add_audit_trail(ST_COSTUPDATE, $update_no, $to); - } -} -*/ -//New written function function adjust_deliveries($stock_id, $material_cost, $to) { if (!is_inventory_item($stock_id)) return; $from = last_negative_stock_trans_id($stock_id, $to); - if ($from == false || $from == "") + if ($from == false || $from == -1) return; $row = get_deliveries_from_trans($stock_id, $from); @@ -282,10 +257,6 @@ function adjust_deliveries($stock_id, $material_cost, $to) $new_sales_cost = $row[0] * $material_cost; $sales_diff = $new_sales_cost - $old_sales_cost; - display_notification(_("new_sales_cost").' - '.$row[0] .' * '. $material_cost); - display_notification(_("new_sales_cost").' - '.$new_sales_cost.' old_sales_cost- '.$old_sales_cost); - display_notification(_("Sales Diff").' - '.$sales_diff); - $row = get_purchases_from_trans($stock_id, $from); $purchase_diff = 0; $old_purchase_cost = 0; @@ -296,13 +267,8 @@ function adjust_deliveries($stock_id, $material_cost, $to) $purchase_diff = $new_purchase_cost - $old_purchase_cost; } - display_notification(_("new_purchase_cost").' - '.$new_purchase_cost.' old_purchase_cost- '.$old_purchase_cost); - display_notification(_("purchase_diff").' - '.$purchase_diff); - $diff = $sales_diff - $purchase_diff; - display_notification(_("Final diff").' - '.$diff); - if ($diff != 0) { $update_no = get_next_trans_no(ST_COSTUPDATE); @@ -314,8 +280,9 @@ function adjust_deliveries($stock_id, $material_cost, $to) $dec = user_price_dec(); $old_cost = -round2($old_sales_cost-$old_purchase_cost,$dec); $new_cost = -round2($new_sales_cost-$new_purchase_cost,$dec); - - $memo_ = _("Cost was ") . $old_cost. _(" changed to ") . $new_cost . _(" for item ")."'$stock_id'"; + + $memo_ = sprintf(_("Cost was %s changed to %s x quantity on hand for item '%s'"), + number_format2($old_cost, 2), number_format2($new_cost, 2), $stock_id); add_gl_trans_std_cost(ST_COSTUPDATE, $update_no, $to, $stock_gl_code["cogs_account"], $stock_gl_code["dimension_id"], $stock_gl_code["dimension2_id"], $memo_, $diff); @@ -328,7 +295,6 @@ function adjust_deliveries($stock_id, $material_cost, $to) function get_stock_gl_code($stock_id) { /*Gets the GL Codes relevant to the item account */ - //Chaitanya : Updated to also provide mb_flag $sql = "SELECT mb_flag, inventory_account, cogs_account, adjustment_account, sales_account, assembly_account, dimension_id, dimension2_id FROM ".TB_PREF."stock_master WHERE stock_id = ".db_escape($stock_id); @@ -338,23 +304,22 @@ function get_stock_gl_code($stock_id) } //----------------------------------------------------------------------------------------- -//Chaitanya : New Function handle negative stock effect -//Called in add_stock_move + function handle_negative_inventory($stock_id, $quantity, $standard_cost, $date_) { - //Chaitanya : If negative adjustment result in negative or zero inventory + //If negative adjustment result in negative or zero inventory //then difference should be adjusted $qoh = get_qoh_on_date($stock_id); - display_notification($qoh." : ".$quantity); + if ($qoh + $quantity <= 0 && $qoh > 0) //Positive inventory turning zero/negative { global $Refs; $id = get_next_trans_no(ST_JOURNAL); $ref = $Refs->get_next(ST_JOURNAL); - $diff = get_standard_cost($stock_id) - $standard_cost; - - if ($diff !=0) + $diff = round($qoh*get_standard_cost($stock_id) + $quantity*$standard_cost, user_price_dec()); + + if ($diff != 0) { $stock_gl_code = get_stock_gl_code($stock_id); $memo = _("Zero/negative inventory handling"); @@ -362,13 +327,13 @@ function handle_negative_inventory($stock_id, $quantity, $standard_cost, $date_) add_gl_trans_std_cost(ST_JOURNAL, $id, $date_, $stock_gl_code["inventory_account"], $stock_gl_code['dimension_id'], $stock_gl_code['dimension2_id'], $memo, - -$qoh * $diff); + -$diff); //GL Posting to inventory adjustment account add_gl_trans_std_cost(ST_JOURNAL, $id, $date_, $stock_gl_code["adjustment_account"], $stock_gl_code['dimension_id'], $stock_gl_code['dimension2_id'], $memo, - $qoh * $diff); - + $diff); + add_audit_trail(ST_JOURNAL, $id, $date_); add_comments(ST_JOURNAL, $id, $date_, $memo); $Refs->save(ST_JOURNAL, $id, $ref); @@ -387,13 +352,6 @@ function add_stock_move($type, $stock_id, $trans_no, $location, $date_, $reference, $quantity, $std_cost, $person_id=0, $show_or_hide=1, $price=0, $discount_percent=0, $error_msg="") { - // Chaitanya : Removed following restriction considering WO issues - // Voiding issues and productions with Service items can not get the - // Service items compatibility - // do not add a stock move if it's a non-inventory item - //if (!is_inventory_item($stock_id)) - //return null; - $date = date2sql($date_); $sql = "INSERT INTO ".TB_PREF."stock_moves (stock_id, trans_no, type, loc_code, @@ -414,7 +372,6 @@ function add_stock_move($type, $stock_id, $trans_no, $location, return db_insert_id(); } -//Chaitanya : Added function function update_stock_move($type, $trans_no, $stock_id, $cost) { $sql = "UPDATE ".TB_PREF."stock_moves SET standard_cost=".db_escape($cost) @@ -457,38 +414,29 @@ function get_stock_moves($type, $type_no, $visible=false) function void_stock_move($type, $type_no) { - //Chaitanya : Reversing stock move rather than voiding as it is hazardous to lose stock movement trail with respect to costing - /*$sql = "UPDATE ".TB_PREF."stock_moves SET qty=0, price=0, discount_percent=0, - standard_cost=0 WHERE type=".db_escape($type)." AND trans_no=".db_escape($type_no); - - db_query($sql, "Could not void stock moves"); */ - $sql = "SELECT * from ".TB_PREF."stock_moves WHERE type=".db_escape($type)." AND trans_no=".db_escape($type_no); $result = db_query($sql, "Could not void stock moves"); while ($row = db_fetch($result)) { //Skip cost averaging of service items if (is_inventory_item($row["stock_id"])) - { + { // The cost has to be adjusted. - //Chaitanya : Transaction rates are stored either as price or standard_cost depending - //on types - $types = array(ST_SUPPCREDIT); - if (in_array($type,$types)) - $trans_rate = $row["price"]; + // Transaction rates are stored either as price or standard_cost depending on types + $types = array(ST_SUPPCREDIT, ST_SUPPRECEIVE); + if (in_array($type, $types)) + $unit_cost = $row["price"]; else - $trans_rate = $row["standard_cost"]; + $unit_cost = $row["standard_cost"]; - update_average_material_cost(0, $row["stock_id"], - $trans_rate, -$row["qty"], sql2date($row["tran_date"])); + update_average_material_cost($row["person_id"], $row["stock_id"], + $unit_cost, -$row["qty"], sql2date($row["tran_date"])); } - - //Post stock move for service items also - add_stock_move($type, $row["stock_id"], $type_no, $row["loc_code"], - sql2date($row["tran_date"]), $row["reference"], -$row["qty"] - , $row["standard_cost"], $row["person_id"], $row["visible"], - $row["price"], $row["discount_percent"]); + } + $sql = "DELETE FROM ".TB_PREF."stock_moves WHERE type=".db_escape($type) + ." AND trans_no=".db_escape($type_no); + db_query($sql, "The stock movement cannot be delated"); } //-------------------------------------------------------------------------------------------------- @@ -512,4 +460,4 @@ function get_location_name($loc_code) //-------------------------------------------------------------------------------------------------- -?> \ No newline at end of file +?>