X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=includes%2Ferrors.inc;h=c584d175f79e831d3855d0fb672910e55c8df844;hb=b9c390e62949efc04b016a87631c18eb70e7870e;hp=160d41e5100dce8fe0d84bda8dd4d55b9c516f8f;hpb=c6f1621249a53faada39629a9ba958a6a5837262;p=fa-stable.git
diff --git a/includes/errors.inc b/includes/errors.inc
index 160d41e5..c584d175 100644
--- a/includes/errors.inc
+++ b/includes/errors.inc
@@ -17,12 +17,25 @@ $before_box = ''; // temporary container for output html data before error box
// display in message box.
function error_handler($errno, $errstr, $file, $line) {
- global $messages;
+ global $messages, $go_debug, $SysPrefs;
- // error_reporting==0 when messages are set off with @
- if ($errno & error_reporting()) {
- $messages[] = array($errno, $errstr, $file, $line);
+ // skip well known warnings we don't care about.
+ // Please use restrainedly to not risk loss of important messages
+ $excluded_warnings = array('html_entity_decode', 'htmlspecialchars');
+ foreach($excluded_warnings as $ref) {
+ if (strpos($errstr, $ref) !== false) {
+ return true;
+ }
}
+
+ // error_reporting==0 when messages are set off with @
+ if ($errno & error_reporting())
+ $messages[] = array($errno, $errstr, $file, $line);
+ else if($errno&~E_NOTICE)// log all not displayed messages
+ error_log(user_company() . ':' . $_SESSION["wa_current_user"]->loginname.':'
+ . basename($file) .":$line:" . ( $SysPrefs->db_ok ? '':'[before upgrade]')
+ . " $errstr");
+
return true;
}
//------------------------------------------------------------------------------
@@ -38,7 +51,7 @@ function fmt_errors($center=false) {
$type = E_USER_NOTICE;
$content = '';
- $class = 'no_msg';
+// $class = 'no_msg';
if (count($messages)) {
foreach($messages as $cnt=>$msg) {
if ($msg[0]>$type) continue;
@@ -59,11 +72,10 @@ function fmt_errors($center=false) {
$content .= ($cnt ? '
' : '').$str;
}
$class = $msg_class[$type];
+ $content = "$content
";
} else
- if ($path_to_root=='.')
- return '';
-
- $content = "$content
";
+ if ($path_to_root=='.')
+ return '';
return $content;
}
//-----------------------------------------------------------------------------
@@ -73,19 +85,39 @@ function error_box() {
global $before_box;
echo "";
- $before_box = ob_get_clean(); // save html content before error box
+
// Necessary restart instead of get_contents/clean calls due to a bug in php 4.3.2
- register_shutdown_function('ob_end_flush');
+ $before_box = ob_get_clean(); // save html content before error box
ob_start('output_html');
echo "
";
}
+/*
+ Helper to avoid sparse log notices.
+*/
+function end_flush() {
+ global $Ajax, $transaction_level;
+
+ if (isset($Ajax))
+ $Ajax->run();
+ // flush all output buffers (works also with exit inside any div levels)
+ while(ob_get_level()) ob_end_flush();
+
+ // if any transaction was aborted unexpectedly rollback changes
+ cancel_transaction();
+}
function display_db_error($msg, $sql_statement=null, $exit=true)
{
- global $db, $debug;
+ global $db, $debug, $go_debug, $db_connections;
+
+ $warning = $msg==null;
$db_error = db_error_no();
- $str = "" . _("DATABASE ERROR :") . " $msg
";
+// $str = "" . _("DATABASE ERROR :") . " $msg
";
+ if($warning)
+ $str = "" . _("Debug mode database warning:") . "
";
+ else
+ $str = "" . _("DATABASE ERROR :") . " $msg
";
if ($db_error != 0)
{
@@ -95,13 +127,17 @@ function display_db_error($msg, $sql_statement=null, $exit=true)
if ($debug == 1)
{
- $str .= "sql that failed was : " . $sql_statement . "
";
+ $cur_prefix = $db_connections[$_SESSION["wa_current_user"]->cur_con]['tbpref'];
+
+ $str .= "sql that failed was : ".str_replace(TB_PREF, $cur_prefix, $sql_statement)."
";
+ if ($go_debug > 1) display_backtrace();
}
$str .= "
";
-
- trigger_error($str, E_USER_ERROR);
-
+ if($msg)
+ trigger_error($str, E_USER_ERROR);
+ else // $msg can be null here only in debug mode, otherwise the error is ignored
+ trigger_error($str, E_USER_WARNING);
if ($exit)
exit;
}
@@ -111,7 +147,7 @@ function frindly_db_error($db_error)
global $db_duplicate_error_code;
if ($db_error == $db_duplicate_error_code)
- {
+ {
display_error(_("The entered information is a duplicate. Please go back and enter different values."));
return true;
}
@@ -121,24 +157,24 @@ function frindly_db_error($db_error)
function check_db_error($msg, $sql_statement, $exit_if_error=true, $rollback_if_error=true)
{
- global $db;
+ global $db, $go_debug;
$db_error = db_error_no();
if ($db_error != 0)
{
- if (!frindly_db_error($db_error))
- display_db_error($msg, $sql_statement, false);
+ if ($go_debug || !frindly_db_error($db_error)) {
+ display_db_error($msg, $sql_statement, false);
+ }
if ($rollback_if_error)
{
- $rollback_result = db_query("rollback","could not rollback");
+ $rollback_result = db_query("rollback");
}
if ($exit_if_error)
{
- echo "
";
- exit;
+ end_page(); exit;
}
}
return $db_error;