X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=manufacturing%2Fwork_order_entry.php;h=9abac4df3f9dc4dc2ab9a08f3ae3bbf4046a8d71;hb=0eadb0e7549a8e90af92dac51b560f57918084ac;hp=b26ed9cce0d653bc8ddf04e0976a301a1c4a3105;hpb=431531eebf3ba494002cfbf7ea36f9e82d4975c0;p=fa-stable.git diff --git a/manufacturing/work_order_entry.php b/manufacturing/work_order_entry.php index b26ed9cc..9abac4df 100644 --- a/manufacturing/work_order_entry.php +++ b/manufacturing/work_order_entry.php @@ -27,7 +27,7 @@ check_db_has_locations(("There are no inventory locations defined in the system. if (isset($_GET['trans_no'])) { $selected_id = $_GET['trans_no']; -} +} elseif(isset($_POST['selected_id'])) { $selected_id = $_POST['selected_id']; @@ -35,7 +35,7 @@ elseif(isset($_POST['selected_id'])) //--------------------------------------------------------------------------------------- -if (isset($_GET['AddedID'])) +if (isset($_GET['AddedID'])) { $id = $_GET['AddedID']; @@ -46,7 +46,7 @@ if (isset($_GET['AddedID'])) //--------------------------------------------------------------------------------------- -if (isset($_GET['UpdatedID'])) +if (isset($_GET['UpdatedID'])) { $id = $_GET['UpdatedID']; @@ -56,7 +56,7 @@ if (isset($_GET['UpdatedID'])) //--------------------------------------------------------------------------------------- -if (isset($_GET['DeletedID'])) +if (isset($_GET['DeletedID'])) { $id = $_GET['DeletedID']; @@ -66,7 +66,7 @@ if (isset($_GET['DeletedID'])) //--------------------------------------------------------------------------------------- -if (isset($_GET['ClosedID'])) +if (isset($_GET['ClosedID'])) { $id = $_GET['ClosedID']; @@ -94,36 +94,30 @@ if (!isset($_POST['date_'])) $_POST['date_'] = Today(); if (!is_date_in_fiscalyear($_POST['date_'])) $_POST['date_'] = end_fiscalyear(); -} +} function can_process() { global $selected_id; - if (!isset($selected_id)) + if (!isset($selected_id)) { - if (!references::is_valid($_POST['wo_ref'])) + if (!references::is_valid($_POST['wo_ref'])) { display_error(_("You must enter a reference.")); return false; } - if (!is_new_reference($_POST['wo_ref'], systypes::work_order())) + if (!is_new_reference($_POST['wo_ref'], systypes::work_order())) { display_error(_("The entered reference is already in use.")); return false; } } - if (!is_numeric($_POST['quantity'])) - { - display_error( _("The quantity entered must be numeric.")); - return false; - } - - if ($_POST['quantity'] <= 0) + if (!check_num('quantity', 0)) { - display_error( _("The quantity entered must be a positive number greater than zero.")); + display_error( _("The quantity entered is invalid or less than zero.")); return false; } @@ -131,50 +125,46 @@ function can_process() { display_error( _("The date entered is in an invalid format.")); return false; - } - elseif (!is_date_in_fiscalyear($_POST['date_'])) + } + elseif (!is_date_in_fiscalyear($_POST['date_'])) { display_error(_("The entered date is not in fiscal year.")); return false; } // only check bom and quantites if quick assembly - if (!($_POST['type'] == wo_types::advanced())) + if (!($_POST['type'] == wo_types::advanced())) { - if (!has_bom($_POST['stock_id'])) + if (!has_bom($_POST['stock_id'])) { display_error(_("The selected item to manufacture does not have a bom.")); return false; } - if (!is_numeric($_POST['Costs'])) - { - display_error( _("The cost entered must be numeric.")); - return false; - } - - if ($_POST['Costs'] < 0) + if ($_POST['Costs'] == "") + $_POST['Costs'] = price_format(0); + if (!check_num('Costs', 0)) { - display_error( _("The cost entered cannot be negative.")); + display_error( _("The cost entered is invalid or less than zero.")); return false; } - if (!sys_prefs::allow_negative_stock()) + if (!sys_prefs::allow_negative_stock()) { - if ($_POST['type'] == wo_types::assemble()) + if ($_POST['type'] == wo_types::assemble()) { // check bom if assembling $result = get_bom($_POST['stock_id']); - while ($bom_item = db_fetch($result)) + while ($bom_item = db_fetch($result)) { - if (has_stock_holding($bom_item["ResourceType"])) + if (has_stock_holding($bom_item["ResourceType"])) { - $quantity = $bom_item["quantity"] * $_POST['quantity']; + $quantity = $bom_item["quantity"] * input_num('quantity'); $qoh = get_qoh_on_date($bom_item["component"], $bom_item["loc_code"], $_POST['date_']); - if (-$quantity + $qoh < 0) + if (-$quantity + $qoh < 0) { display_error(_("The work order cannot be processed because there is an insufficient quantity for component:") . " " . $bom_item["component"] . " - " . $bom_item["description"] . ". " . _("Location:") . " " . $bom_item["location_name"]); @@ -182,36 +172,36 @@ function can_process() } } } - } - elseif ($_POST['type'] == wo_types::unassemble()) + } + elseif ($_POST['type'] == wo_types::unassemble()) { // if unassembling, check item to unassemble $qoh = get_qoh_on_date($_POST['stock_id'], $_POST['StockLocation'], $_POST['date_']); - if (-$_POST['quantity'] + $qoh < 0) + if (-input_num('quantity') + $qoh < 0) { display_error(_("The selected item cannot be unassembled because there is insufficient stock.")); return false; } } } - } - else + } + else { if (!is_date($_POST['RequDate'])) { display_error( _("The date entered is in an invalid format.")); return false; - } - //elseif (!is_date_in_fiscalyear($_POST['RequDate'])) + } + //elseif (!is_date_in_fiscalyear($_POST['RequDate'])) //{ // display_error(_("The entered date is not in fiscal year.")); // return false; //} - if (isset($selected_id)) + if (isset($selected_id)) { $myrow = get_work_order($selected_id, true); - if ($_POST['units_issued'] > $_POST['quantity']) + if ($_POST['units_issued'] > input_num('quantity')) { display_error(_("The quantity cannot be changed to be less than the quantity already manufactured for this order.")); return false; @@ -224,22 +214,22 @@ function can_process() //------------------------------------------------------------------------------------- -if (isset($_POST['ADD_ITEM']) && can_process()) +if (isset($_POST['ADD_ITEM']) && can_process()) { - $id = add_work_order($_POST['wo_ref'], $_POST['StockLocation'], $_POST['quantity'], + $id = add_work_order($_POST['wo_ref'], $_POST['StockLocation'], input_num('quantity'), $_POST['stock_id'], $_POST['type'], $_POST['date_'], - $_POST['RequDate'], $_POST['Costs'], $_POST['memo_']); + $_POST['RequDate'], input_num('Costs'), $_POST['memo_']); meta_forward($_SERVER['PHP_SELF'], "AddedID=$id"); } //------------------------------------------------------------------------------------- -if (isset($_POST['UPDATE_ITEM']) && can_process()) +if (isset($_POST['UPDATE_ITEM']) && can_process()) { - update_work_order($selected_id, $_POST['StockLocation'], $_POST['quantity'], + update_work_order($selected_id, $_POST['StockLocation'], input_num('quantity'), $_POST['stock_id'], $_POST['date_'], $_POST['RequDate'], $_POST['memo_']); meta_forward($_SERVER['PHP_SELF'], "UpdatedID=$selected_id"); @@ -247,22 +237,22 @@ if (isset($_POST['UPDATE_ITEM']) && can_process()) //-------------------------------------------------------------------------------------- -if (isset($_POST['delete'])) +if (isset($_POST['delete'])) { //the link to delete a selected record was clicked instead of the submit button $cancel_delete = false; // can't delete it there are productions or issues - if (work_order_has_productions($selected_id) || - work_order_has_issues($selected_id) || + if (work_order_has_productions($selected_id) || + work_order_has_issues($selected_id) || work_order_has_payments($selected_id)) { display_error(_("This work order cannot be deleted because it has already been processed.")); $cancel_delete = true; } - if ($cancel_delete == false) + if ($cancel_delete == false) { //ie not cancelled the delete as a result of above tests // delete the actual work order @@ -273,7 +263,7 @@ if (isset($_POST['delete'])) //------------------------------------------------------------------------------------- -if (isset($_POST['close'])) +if (isset($_POST['close'])) { // update the closed flag in the work order @@ -293,14 +283,14 @@ if (isset($selected_id)) { $myrow = get_work_order($selected_id); - if (strlen($myrow[0]) == 0) + if (strlen($myrow[0]) == 0) { echo _("The order number sent is not valid."); safe_exit(); } // if it's a closed work order can't edit it - if ($myrow["closed"] == 1) + if ($myrow["closed"] == 1) { echo "