X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=manufacturing%2Fwork_order_issue.php;h=025a91258c2dcfb7f76c398c90927b23c7ea9951;hb=6bcd87642330092910f5d6977845a76ac59350ac;hp=dc2a4380737d304d4c1062768f13907ad6ffe31c;hpb=79f6e6f96a709611021434df0073e0d3f4ce5790;p=fa-stable.git

diff --git a/manufacturing/work_order_issue.php b/manufacturing/work_order_issue.php
index dc2a4380..025a9125 100644
--- a/manufacturing/work_order_issue.php
+++ b/manufacturing/work_order_issue.php
@@ -11,6 +11,7 @@
 ***********************************************************************/
 $page_security = 'SA_MANUFISSUE';
 $path_to_root = "..";
+
 include_once($path_to_root . "/includes/ui/items_cart.inc");
 
 include_once($path_to_root . "/includes/session.inc");
@@ -22,10 +23,11 @@ include_once($path_to_root . "/manufacturing/includes/manufacturing_db.inc");
 include_once($path_to_root . "/manufacturing/includes/manufacturing_ui.inc");
 include_once($path_to_root . "/manufacturing/includes/work_order_issue_ui.inc");
 $js = "";
-if ($use_popup_windows)
+if ($SysPrefs->use_popup_windows)
 	$js .= get_js_open_window(800, 500);
-if ($use_date_picker)
+if (user_use_date_picker())
 	$js .= get_js_date_picker();
+
 page(_($help_context = "Issue Items to Work Order"), false, false, "", $js);
 
 //-----------------------------------------------------------------------------------------------
@@ -62,49 +64,35 @@ function handle_new_order()
 		unset ($_SESSION['issue_items']);
 	}
 
-     Session_register("issue_items");
-
-     $_SESSION['issue_items'] = new items_cart(28);
+     $_SESSION['issue_items'] = new items_cart(ST_MANUISSUE);
      $_SESSION['issue_items']->order_id = $_GET['trans_no'];
 }
 
 //-----------------------------------------------------------------------------------------------
-
 function can_process()
 {
-	global $Refs;
-
-	if (!is_date($_POST['date_'])) 
+	if (!is_date($_POST['date_']))
 	{
 		display_error(_("The entered date for the issue is invalid."));
 		set_focus('date_');
 		return false;
 	} 
-	elseif (!is_date_in_fiscalyear($_POST['date_'])) 
+	elseif (!is_date_in_fiscalyear($_POST['date_']))
 	{
-		display_error(_("The entered date is not in fiscal year."));
+		display_error(_("The entered date is out of fiscal year or is closed for further data entry."));
 		set_focus('date_');
 		return false;
 	}
-	if (!$Refs->is_valid($_POST['ref'])) 
-	{
-		display_error(_("You must enter a reference."));
-		set_focus('ref');
-		return false;
-	}
-
-	if (!is_new_reference($_POST['ref'], 28)) 
+	if (!check_reference($_POST['ref'], ST_MANUISSUE))
 	{
-		display_error(_("The entered reference is already in use."));
 		set_focus('ref');
 		return false;
 	}
 
 	$failed_item = $_SESSION['issue_items']->check_qoh($_POST['Location'], $_POST['date_'], !$_POST['IssueType']);
-	if ($failed_item != -1) 
+	if ($failed_item)
 	{
-    	display_error( _("The issue cannot be processed because an entered item would cause a negative inventory balance :") .
-    		" " . $failed_item->stock_id . " - " .  $failed_item->item_description);
+   		display_error(_("The issue cannot be processed because it would cause negative inventory balance for marked items as of document date or later."));
 		return false;
 	}
 
@@ -136,7 +124,7 @@ if (isset($_POST['Process']) && can_process())
 
 function check_item_data()
 {
-	if (!check_num('qty', 0))
+	if (input_num('qty') == 0 || !check_num('qty', 0))
 	{
 		display_error(_("The quantity entered is negative or invalid."));
 		set_focus('qty');
@@ -214,7 +202,7 @@ echo "<br>";
 
 start_form();
 
-start_table(TABLESTYLE, "width=90%", 10);
+start_table(TABLESTYLE, "width='90%'", 10);
 echo "<tr><td>";
 display_issue_items(_("Items to Issue"), $_SESSION['issue_items']);
 issue_options_controls();
@@ -230,4 +218,3 @@ end_form();
 
 end_page();
 
-?>