X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=purchasing%2Fpo_receive_items.php;h=14a017be94d95278fee23d703bb623e8682e1a26;hb=2aab14aed5938bc674997cff83c319bdf40490d6;hp=d58e2aabfaca8a6e6972b44693709d4d2e1fb132;hpb=68372f2a08f5a862375c04862c8ccb56df830b4b;p=fa-stable.git

diff --git a/purchasing/po_receive_items.php b/purchasing/po_receive_items.php
index d58e2aab..14a017be 100644
--- a/purchasing/po_receive_items.php
+++ b/purchasing/po_receive_items.php
@@ -90,8 +90,7 @@ function display_po_receive_items()
 			if ($qty_outstanding > 0)
 				qty_cells(null, $ln_itm->line_no, number_format2($ln_itm->receive_qty, $dec), "align=right", null, $dec);
 			else
-				qty_cells(null, $ln_itm->line_no, number_format2($ln_itm->receive_qty, $dec), "align=right",
-					"disabled", $dec);
+				label_cell(number_format2($ln_itm->receive_qty, $dec), "align=right");
 
 			amount_cell($ln_itm->price);
 			amount_cell($line_total);
@@ -115,9 +114,8 @@ function check_po_changed()
 	// Otherwise if you try to fullfill item quantities separately will give error.
 	$sql = "SELECT item_code, quantity_ordered, quantity_received, qty_invoiced
 		FROM ".TB_PREF."purch_order_details
-		WHERE order_no=" . $_SESSION['PO']->order_no . "
-		AND (quantity_ordered > quantity_received)
-		ORDER BY po_detail_item";
+		WHERE order_no=" . $_SESSION['PO']->order_no 
+		." ORDER BY po_detail_item";
 
 	$result = db_query($sql, "could not query purch order details");
     check_db_error("Could not check that the details of the purchase order had not been changed by another user ", $sql);
@@ -126,7 +124,6 @@ function check_po_changed()
 	while ($myrow = db_fetch($result))
 	{
 		$ln_item = $_SESSION['PO']->line_items[$line_no];
-
 		// only compare against items that are outstanding
 		$qty_outstanding = $ln_item->quantity - $ln_item->qty_received;
 		if ($qty_outstanding > 0)
@@ -139,7 +136,7 @@ function check_po_changed()
     			return true;
     		}
 		}
-		$line_no++;
+	 	$line_no++;
 	} /*loop through all line items of the order to ensure none have been invoiced */
 
 	return false;
@@ -225,15 +222,17 @@ function process_receive_po()
 
 	if (check_po_changed())
 	{
-		echo "<br> " . _("This order has been changed or invoiced since this delivery was started to be actioned. Processing halted. To enter a delivery against this purchase order, it must be re-selected and re-read again to update the changes made by the other user.") . "<BR>";
-
-		echo "<center><a href='$path_to_root/purchasing/inquiry/po_search.php?" . SID . "'>" . _("Select a different purchase order for receiving goods against") . "</a></center>";
-		echo "<center><a href='$path_to_root/po_receive_items.php?" . SID . "PONumber=" . $_SESSION['PO']->OrderNumber . "'>" . _("Re-Read the updated purchase order for receiving goods against") . "</a></center>";
+		display_error(_("This order has been changed or invoiced since this delivery was started to be actioned. Processing halted. To enter a delivery against this purchase order, it must be re-selected and re-read again to update the changes made by the other user."));
+		hyperlink_no_params("$path_to_root/purchasing/inquiry/po_search.php",
+		 _("Select a different purchase order for receiving goods against"));
+		hyperlink_params("$path_to_root/purchasing/po_receive_items.php", 
+			 _("Re-Read the updated purchase order for receiving goods against"),
+			 "PONumber=" . $_SESSION['PO']->order_no);
 		unset($_SESSION['PO']->line_items);
 		unset($_SESSION['PO']);
 		unset($_POST['ProcessGoodsReceived']);
 		$Ajax->activate('_page_body');
-		exit;
+		display_footer_exit();
 	}
 
 	$grn = add_grn($_SESSION['PO'], $_POST['DefaultReceivedDate'],
@@ -265,7 +264,7 @@ if (isset($_POST['Update']) || isset($_POST['ProcessGoodsReceived']))
  	set from the post to the quantity to be received in this receival*/
 	foreach ($_SESSION['PO']->line_items as $line)
 	{
-
+	 if( ($line->quantity - $line->qty_received)>0) {
 		$_POST[$line->line_no] = max($_POST[$line->line_no], 0);
 		if (!check_num($line->line_no))
 			$_POST[$line->line_no] = number_format2(0, get_qty_dec($line->stock_id));
@@ -279,6 +278,7 @@ if (isset($_POST['Update']) || isset($_POST['ProcessGoodsReceived']))
 		{
 			$_SESSION['PO']->line_items[$line->line_no]->item_description = $_POST[$line->stock_id . "Desc"];
 		}
+	 }
 	}
 	$Ajax->activate('grn_items');
 }