X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=blobdiff_plain;f=purchasing%2Fsupplier_credit.php;h=4bfc235e52f4cd581b4e9be4de6bf2884929a570;hb=4888cf51abf175a0ed4645e6adb2a326ce7e0e5f;hp=102184b03b48fd3364f2f9414dafd5a8ca374f6e;hpb=902f1015d874c33bd7946b17de2ad80b4f2144b6;p=fa-stable.git diff --git a/purchasing/supplier_credit.php b/purchasing/supplier_credit.php index 102184b0..4bfc235e 100644 --- a/purchasing/supplier_credit.php +++ b/purchasing/supplier_credit.php @@ -21,14 +21,50 @@ include_once($path_to_root . "/includes/data_checks.inc"); include_once($path_to_root . "/purchasing/includes/purchasing_db.inc"); include_once($path_to_root . "/purchasing/includes/purchasing_ui.inc"); $js = ""; -if ($use_popup_windows) +if ($SysPrefs->use_popup_windows) $js .= get_js_open_window(900, 500); -if ($use_date_picker) +if (user_use_date_picker()) $js .= get_js_date_picker(); -page(_("Supplier Credit Note"), false, false, "", $js); //---------------------------------------------------------------------------------------- +if (isset($_GET['ModifyCredit'])) { + check_is_editable(ST_SUPPCREDIT, $_GET['ModifyCredit']); + $_SESSION['page_title'] = sprintf( _("Modifying Supplier Credit # %d"), $_GET['ModifyCredit']); + $_SESSION['supp_trans'] = new supp_trans(ST_SUPPCREDIT, $_GET['ModifyCredit']); +} + +//--------------------------------------------------------------------------------------------------- + +if (isset($_GET['New'])) +{ + if (isset( $_SESSION['supp_trans'])) + { + unset ($_SESSION['supp_trans']->grn_items); + unset ($_SESSION['supp_trans']->gl_codes); + unset ($_SESSION['supp_trans']); + } + + if (isset($_GET['invoice_no'])) + { + $_SESSION['supp_trans'] = new supp_trans(ST_SUPPINVOICE, $_GET['invoice_no']); + $_SESSION['supp_trans']->src_docs = array( $_GET['invoice_no'] => $_SESSION['supp_trans']->supp_reference); + + + $_SESSION['supp_trans']->trans_type = ST_SUPPCREDIT; + $_SESSION['supp_trans']->trans_no = 0; + $_SESSION['supp_trans']->supp_reference = ''; + $help_context = "Supplier Credit Note"; + $_SESSION['page_title'] = _("Supplier Credit Note"); + + } else { + $help_context = "Supplier Credit Note"; + $_SESSION['page_title'] = _("Supplier Credit Note"); + $_SESSION['supp_trans'] = new supp_trans(ST_SUPPCREDIT); + } +} +page($_SESSION['page_title'], false, false, "", $js); + check_db_has_suppliers(_("There are no suppliers defined in the system.")); //--------------------------------------------------------------------------------------------------------------- @@ -36,7 +72,7 @@ check_db_has_suppliers(_("There are no suppliers defined in the system.")); if (isset($_GET['AddedID'])) { $invoice_no = $_GET['AddedID']; - $trans_type = 21; + $trans_type = ST_SUPPCREDIT; echo "
"; @@ -47,27 +83,8 @@ if (isset($_GET['AddedID'])) hyperlink_params($_SERVER['PHP_SELF'], _("Enter Another Credit Note"), "New=1"); hyperlink_params("$path_to_root/admin/attachments.php", _("Add an Attachment"), "filterType=$trans_type&trans_no=$invoice_no"); - - display_footer_exit(); -} - -//--------------------------------------------------------------------------------------------------- -if (isset($_GET['New'])) -{ - if (isset( $_SESSION['supp_trans'])) - { - unset ($_SESSION['supp_trans']->grn_items); - unset ($_SESSION['supp_trans']->gl_codes); - unset ($_SESSION['supp_trans']); - } - - $_SESSION['supp_trans'] = new supp_trans; - $_SESSION['supp_trans']->is_invoice = false; - if (isset($_GET['invoice_no'])) - { - $_SESSION['supp_trans']->supp_reference = $_POST['invoice_no'] = $_GET['invoice_no']; - } + display_footer_exit(); } function clear_fields() @@ -83,6 +100,15 @@ function clear_fields() $Ajax->activate('gl_items'); set_focus('gl_code'); } + +function reset_tax_input() +{ + global $Ajax; + + unset($_POST['mantax']); + $Ajax->activate('inv_tot'); +} + //------------------------------------------------------------------------------------------------ // GL postings are often entered in the same form to two accounts // so fileds are cleared only on user demand. @@ -92,13 +118,12 @@ if (isset($_POST['ClearFields'])) clear_fields(); } -if (isset($_POST['AddGLCodeToTrans'])){ +if (isset($_POST['AddGLCodeToTrans'])) { $Ajax->activate('gl_items'); $input_error = false; - $sql = "SELECT account_code, account_name FROM ".TB_PREF."chart_master WHERE account_code='" . $_POST['gl_code'] . "'"; - $result = db_query($sql,"get account information"); + $result = get_gl_account_info($_POST['gl_code']); if (db_num_rows($result) == 0) { display_error(_("The account code entered is not a valid code, this line cannot be added to the transaction.")); @@ -128,6 +153,7 @@ if (isset($_POST['AddGLCodeToTrans'])){ $_SESSION['supp_trans']->add_gl_codes_to_trans($_POST['gl_code'], $gl_act_name, $_POST['dimension_id'], $_POST['dimension2_id'], input_num('amount'), $_POST['memo_']); + reset_tax_input(); set_focus('gl_code'); } } @@ -137,33 +163,25 @@ if (isset($_POST['AddGLCodeToTrans'])){ function check_data() { - global $total_grn_value, $total_gl_value; - - if (!$_SESSION['supp_trans']->is_valid_trans_to_post()) - { - display_error(_("The credit note cannot be processed because the there are no items or values on the invoice. Credit notes are expected to have a charge.")); - set_focus(''); - return false; - } + global $SysPrefs; - if (!references::is_valid($_SESSION['supp_trans']->reference)) + if (!get_post('supplier_id')) { - display_error(_("You must enter an credit note reference.")); - set_focus('reference'); + display_error(_("There is no supplier selected.")); + set_focus('supplier_id'); return false; - } + } - if (!is_new_reference($_SESSION['supp_trans']->reference, 21)) + if (!$_SESSION['supp_trans']->is_valid_trans_to_post()) { - display_error(_("The entered reference is already in use.")); - set_focus('reference'); + display_error(_("The credit note cannot be processed because the there are no items or values on the invoice. Credit notes are expected to have a charge.")); + set_focus(''); return false; } - if (!references::is_valid($_SESSION['supp_trans']->supp_reference)) + if (!check_reference($_SESSION['supp_trans']->reference, ST_SUPPCREDIT, $_SESSION['supp_trans']->trans_no)) { - display_error(_("You must enter a supplier's credit note reference.")); - set_focus('supp_reference'); + set_focus('reference'); return false; } @@ -175,7 +193,7 @@ function check_data() } elseif (!is_date_in_fiscalyear($_SESSION['supp_trans']->tran_date)) { - display_error(_("The entered date is not in fiscal year.")); + display_error(_("The entered date is out of fiscal year or is closed for further data entry.")); set_focus('tran_date'); return false; } @@ -186,12 +204,36 @@ function check_data() return false; } - if ($_SESSION['supp_trans']->ov_amount < ($total_gl_value + $total_grn_value)) + if (trim(get_post('supp_reference')) == false) { - display_error(_("The credit note total as entered is less than the sum of the the general ledger entires (if any) and the charges for goods received. There must be a mistake somewhere, the credit note as entered will not be processed.")); + display_error(_("You must enter a supplier's invoice reference.")); + set_focus('supp_reference'); return false; } + if (is_reference_already_there($_SESSION['supp_trans']->supplier_id, $_POST['supp_reference'], $_SESSION['supp_trans']->trans_no)) + { /*Transaction reference already entered */ + display_error(_("This invoice number has already been entered. It cannot be entered again.") . " (" . $_POST['supp_reference'] . ")"); + set_focus('supp_reference'); + return false; + } + + if (!$SysPrefs->allow_negative_stock()) { + foreach ($_SESSION['supp_trans']->grn_items as $n => $item) { + if (is_inventory_item($item->item_code)) + { + if (check_negative_stock($item->item_code, -$item->this_quantity_inv, null, $_SESSION['supp_trans']->tran_date)) + { + $stock = get_item($item->item_code); + display_error(_("The return cannot be processed because there is an insufficient quantity for item:") . + " " . $stock['stock_id'] . " - " . $stock['description'] . " - " . + _("Quantity On Hand") . " = " . number_format2(get_qoh_on_date($stock['stock_id'], null, + $_SESSION['supp_trans']->tran_date), get_qty_dec($stock['stock_id']))); + return false; + } + } + } + } return true; } @@ -224,6 +266,7 @@ if (isset($_POST['PostCreditNote'])) function check_item_data($n) { + if (!check_num('This_QuantityCredited'.$n, 0)) { display_error(_("The quantity to credit must be numeric and greater than zero.")); @@ -245,14 +288,12 @@ function commit_item_data($n) { if (check_item_data($n)) { - $complete = False; - $_SESSION['supp_trans']->add_grn_to_trans($n, $_POST['po_detail_item'.$n], $_POST['item_code'.$n], $_POST['item_description'.$n], $_POST['qty_recd'.$n], $_POST['prev_quantity_inv'.$n], input_num('This_QuantityCredited'.$n), - $_POST['order_price'.$n], input_num('ChgPrice'.$n), $complete, - $_POST['std_cost_unit'.$n], ""); + $_POST['order_price'.$n], input_num('ChgPrice'.$n)); + reset_tax_input(); } } @@ -284,7 +325,7 @@ if ($id3 != -1) { $_SESSION['supp_trans']->remove_grn_from_trans($id3); $Ajax->activate('grn_items'); - $Ajax->activate('inv_tot'); + reset_tax_input(); } $id4 = find_submit('Delete2'); @@ -292,13 +333,13 @@ if ($id4 != -1) { $_SESSION['supp_trans']->remove_gl_codes_from_trans($id4); clear_fields(); + reset_tax_input(); $Ajax->activate('gl_items'); - $Ajax->activate('inv_tot'); } if (isset($_POST['RefreshInquiry'])) { $Ajax->activate('grn_items'); - $Ajax->activate('inv_tot'); + reset_tax_input(); } if (isset($_POST['go'])) @@ -306,7 +347,7 @@ if (isset($_POST['go'])) $Ajax->activate('gl_items'); display_quick_entries($_SESSION['supp_trans'], $_POST['qid'], input_num('totamount'), QE_SUPPINV); $_POST['totamount'] = price_format(0); $Ajax->activate('totamount'); - $Ajax->activate('inv_tot'); + reset_tax_input(); } @@ -318,17 +359,13 @@ invoice_header($_SESSION['supp_trans']); if ($_POST['supplier_id']=='') display_error('No supplier found for entered search text'); else { - start_outer_table("$table_style2 width=98%", 5); + display_grn_items($_SESSION['supp_trans'], 1); - $total_grn_value = display_grn_items($_SESSION['supp_trans'], 1); - - $total_gl_value = display_gl_items($_SESSION['supp_trans'], 1); + display_gl_items($_SESSION['supp_trans'], 1); div_start('inv_tot'); invoice_totals($_SESSION['supp_trans']); div_end(); - - end_outer_table(0, false); } if ($id != -1) @@ -346,4 +383,3 @@ br(); end_form(); end_page(); -?>