projects
/
fa-stable.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
0c7e075
)
Security cleanup on 'where' parameter in a couple of list helpers.
author
Janusz Dobrowolski
<janusz@frontaccouting.eu>
Sat, 8 Sep 2012 11:25:38 +0000
(13:25 +0200)
committer
Janusz Dobrowolski
<janusz@frontaccouting.eu>
Sat, 8 Sep 2012 11:25:38 +0000
(13:25 +0200)
includes/ui/ui_lists.inc
patch
|
blob
|
history
diff --git
a/includes/ui/ui_lists.inc
b/includes/ui/ui_lists.inc
index 0240b9536c92882cc57294d77143ba8f77bd1fb9..47d7d7e06536d9ea46b9d88ff7b1e549a53d9e7c 100644
(file)
--- a/
includes/ui/ui_lists.inc
+++ b/
includes/ui/ui_lists.inc
@@
-709,7
+709,7
@@
$options = array(
if (!$showclosed)
$options['where'][] = "closed=0";
if($showtype)
if (!$showclosed)
$options['where'][] = "closed=0";
if($showtype)
- $options['where'][] = "type_=
$showtype"
;
+ $options['where'][] = "type_=
".db_escape($showtype)
;
return combo_input($name, $selected_id, $sql, 'id', 'ref', $options);
}
return combo_input($name, $selected_id, $sql, 'id', 'ref', $options);
}
@@
-889,7
+889,7
@@
function stock_component_items_list($name, $parent_stock_id, $selected_id=null,
$all_option=false, $submit_on_change=false, $editkey = false)
{
return stock_items_list($name, $selected_id, $all_option, $submit_on_change,
$all_option=false, $submit_on_change=false, $editkey = false)
{
return stock_items_list($name, $selected_id, $all_option, $submit_on_change,
- array('where'=>array("stock_id !=
'$parent_stock_id'"
)), $editkey);
+ array('where'=>array("stock_id !=
".db_escape($parent_stock_id)
)), $editkey);
}
function stock_component_items_list_cells($label, $name, $parent_stock_id,
}
function stock_component_items_list_cells($label, $name, $parent_stock_id,
@@
-898,7
+898,7
@@
function stock_component_items_list_cells($label, $name, $parent_stock_id,
if ($label != null)
echo "<td>$label</td>\n";
echo stock_items_list($name, $selected_id, $all_option, $submit_on_change,
if ($label != null)
echo "<td>$label</td>\n";
echo stock_items_list($name, $selected_id, $all_option, $submit_on_change,
- array('where'=>array("stock_id !=
'$parent_stock_id'"
), 'cells'=>true),
+ array('where'=>array("stock_id !=
".db_escape($parent_stock_id)
), 'cells'=>true),
$editkey);
}
//------------------------------------------------------------------------------------
$editkey);
}
//------------------------------------------------------------------------------------