When retrieving work centres id's there was a database error. Fixed by casting string...

diff --git a/CHANGELOG.txt b/CHANGELOG.txt
index 976ae83df65b69472c7e97457bbeab03f1ffd280..090d3bc7994cb68cf489d1528e9ddac1b41902eb 100644 (file)
--- a/CHANGELOG.txt
+++ b/CHANGELOG.txt
@@ -21,10 +21,14 @@ $ -> Affected files
 
 28-Apr-2007 Joe Hunt
  # When saving work order entries a lot of debug boxes appeared. Fixed
- # When clicking on the link Issue on work order inquires an empty screen appeared. Fixed
- $ /manufacturing/work_order_entry.php
+ # When clicking on the link, Issue, on work order inquires an empty screen appeared. Fixed
+ # When retrieving work centres id's there was a database error. Fixed by casting string to unsigned
+ $ /includes/db/manufacturing_db.inc
+   /manufacturing/work_order_entry.php
    /manufacturing/includes/work_order_issue_ui.inc
+   /manufacturing/includes/db/work_order_requirements_db.inc
    /manufacturing/includes/db/work_orders_quick_db.inc
+   /manufacturing/inquiry/where_used_inquiry.php
    
 25-Apr-2007 Joe Hunt
  # Missing Date Picker

diff --git a/includes/db/manufacturing_db.inc b/includes/db/manufacturing_db.inc
index fa63bbf86254035088878f43237fa3789c3495a8..0c91583723d5250005f52111013ee178a4689eb0 100644 (file)
--- a/includes/db/manufacturing_db.inc
+++ b/includes/db/manufacturing_db.inc
@@ -22,7 +22,7 @@ function get_bom($item)
        ".TB_PREF."bom.quantity * (".TB_PREF."stock_master.material_cost+ ".TB_PREF."stock_master.labour_cost+ ".TB_PREF."stock_master.overhead_cost) AS ComponentCost 
        FROM ".TB_PREF."workcentres, ".TB_PREF."locations, ".TB_PREF."bom INNER JOIN ".TB_PREF."stock_master ON ".TB_PREF."bom.component = ".TB_PREF."stock_master.stock_id 
        WHERE ".TB_PREF."bom.parent = '" . $item . "'
-               AND ".TB_PREF."workcentres.id=".TB_PREF."bom.workcentre_added
+               AND ".TB_PREF."workcentres.id=CAST(".TB_PREF."bom.workcentre_added AS UNSIGNED) 
                AND ".TB_PREF."bom.loc_code = ".TB_PREF."locations.loc_code ORDER BY ".TB_PREF."bom.id";
        
        return db_query($sql, "The bill of material could not be retrieved");

diff --git a/manufacturing/includes/db/work_order_requirements_db.inc b/manufacturing/includes/db/work_order_requirements_db.inc
index 9c528db90a83df33ff81fba231d1557d21457081..b96507d23e88a2ace6c48d4b328d847b4b8e41d1 100644 (file)
--- a/manufacturing/includes/db/work_order_requirements_db.inc
+++ b/manufacturing/includes/db/work_order_requirements_db.inc
@@ -10,7 +10,7 @@ function get_wo_requirements($woid)
                ".TB_PREF."wo_requirements.stock_id = ".TB_PREF."stock_master.stock_id 
                WHERE workorder_id=$woid
                AND ".TB_PREF."locations.loc_code = ".TB_PREF."wo_requirements.loc_code
-               AND ".TB_PREF."workcentres.id=workcentre";      
+               AND ".TB_PREF."workcentres.id=CAST(workcentre AS UNSIGNED)";    
 
        return db_query($sql, "The work order requirements could not be retrieved");    
 }

diff --git a/manufacturing/includes/db/work_orders_quick_db.inc b/manufacturing/includes/db/work_orders_quick_db.inc
index aec2ee896599b33289dea45f5300583637184df9..054eee23525c6bf2fd06b1f5c8a46245d8ff2ca8 100644 (file)
--- a/manufacturing/includes/db/work_orders_quick_db.inc
+++ b/manufacturing/includes/db/work_orders_quick_db.inc
@@ -36,7 +36,7 @@ function add_work_order_quick($wo_ref, $loc_code, $units_reqd, $stock_id, $type,
                
                $sql = "INSERT INTO ".TB_PREF."wo_requirements (workorder_id, stock_id, workcentre, units_req, units_issued, loc_code)
                        VALUES ($woid, " . "'" . $bom_item["component"] . "'" . ", 
-                       ". $bom_item["workcentre_added"] . ", 
+                       '". $bom_item["workcentre_added"] . "', 
                        $unit_quantity, $item_quantity, '" . $bom_item["loc_code"] . "')";
                        
         db_query($sql, "The work order requirements could not be added");

diff --git a/manufacturing/inquiry/where_used_inquiry.php b/manufacturing/inquiry/where_used_inquiry.php
index 9304c197a7ea2ab4bd5c4f2c4b7c94f63ee50c3d..d7f8877de6a875d3fde4daf96dd08c0ba29b1793 100644 (file)
--- a/manufacturing/inquiry/where_used_inquiry.php
+++ b/manufacturing/inquiry/where_used_inquiry.php
@@ -27,7 +27,7 @@ if (isset($_POST['stock_id']))
 {
     $sql = "SELECT ".TB_PREF."bom.*,".TB_PREF."stock_master.description,".TB_PREF."workcentres.name As WorkCentreName, ".TB_PREF."locations.location_name
                FROM ".TB_PREF."bom, ".TB_PREF."stock_master, ".TB_PREF."workcentres, ".TB_PREF."locations
-               WHERE ".TB_PREF."bom.parent = ".TB_PREF."stock_master.stock_id AND ".TB_PREF."bom.workcentre_added = ".TB_PREF."workcentres.id
+               WHERE ".TB_PREF."bom.parent = ".TB_PREF."stock_master.stock_id AND CAST(".TB_PREF."bom.workcentre_added AS UNSIGNED) = ".TB_PREF."workcentres.id
                AND ".TB_PREF."bom.loc_code = ".TB_PREF."locations.loc_code
                AND ".TB_PREF."bom.component='" . $_POST['stock_id'] . "'";