From: Joe Hunt <joe.hunt.consulting@gmail.com>
Date: Thu, 23 Aug 2007 23:01:25 +0000 (+0000)
Subject: Unnecessary parameter ($db) in check_for_recursive_bom
X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=commitdiff_plain;h=19e3ababaa8c089e66e779b5e995576f9eb61d04;p=textcart.git

Unnecessary parameter ($db) in check_for_recursive_bom
---

diff --git a/CHANGELOG.txt b/CHANGELOG.txt
index ed03cdf..8e9e7b2 100644
--- a/CHANGELOG.txt
+++ b/CHANGELOG.txt
@@ -19,28 +19,32 @@ Legend:
 ! -> Note
 $ -> Affected files
 
-21-Aug-2007
+23-Aug-2007 Joe Hunt
+ # Unnecessary parameter ($db) in check_for_recursive_bom
+ $ /manufacturing/manage/bom_edit.php
+ 
+21-Aug-2007 Joe Hunt
  # Bug in /includes/lang/gettext.php (249) affecting changing language!
  $ /includes/lang/gettext.php
  
-08-Aug-2007
+08-Aug-2007 Joe Hunt
  # Minor adjustments
  $ config.php
    /access/login.php
    /admin/create_coy.php
    /reporting/includes/pdf_report.inc
    
-04-Aug-2007
+04-Aug-2007 Joe Hunt
  + Added a default fiscal year in the en_US-new.sql and start references.
  $ /sql/en_US-new.sql
  ! Changed some specific text strings in en_US.po (E.g. TAX instead of VAT)
  $ /lang/en_US/LC_MESSAGES/en_US.mo
  
-03-Aug-2007
+03-Aug-2007 Joe Hunt
  # A bug in Direct Invoicing (wrong Invoice Date) has been fixed.
  $ /sales/includes/db/sales_order_db.inc
  
-23-Jul-2007
+23-Jul-2007 Joe Hunt
  # Changed <? in front of 2 files to <?php.
  $ /purchasing/includes/purchasing_ui.inc
    /reporting/includes/class.mail.inc
diff --git a/manufacturing/manage/bom_edit.php b/manufacturing/manage/bom_edit.php
index 559b79a..2069f86 100644
--- a/manufacturing/manage/bom_edit.php
+++ b/manufacturing/manage/bom_edit.php
@@ -50,7 +50,7 @@ elseif (isset($_POST["selected_component"]))
 
 //--------------------------------------------------------------------------------------------------
 
-function check_for_recursive_bom($ultimate_parent, $component_to_check, $db) 
+function check_for_recursive_bom($ultimate_parent, $component_to_check) 
 {
 
 	/* returns true ie 1 if the bom contains the parent part as a component
@@ -68,7 +68,7 @@ function check_for_recursive_bom($ultimate_parent, $component_to_check, $db)
 				return 1;
 			}
 
-			if (check_for_recursive_bom($ultimate_parent, $myrow[0], &$db))
+			if (check_for_recursive_bom($ultimate_parent, $myrow[0]))
 			{
 				return 1;
 			}
@@ -116,8 +116,6 @@ function display_bom_items($selected_parent)
 
 function on_submit($selected_parent, $selected_component)
 {
-	global $db;
-
 	if (!is_numeric($_POST['quantity'])) 
 	{
 		display_error(_("The quantity entered must be numeric."));
@@ -150,7 +148,7 @@ function on_submit($selected_parent, $selected_component)
 		/*Selected component is null cos no item selected on first time round so must be				adding a record must be Submitting new entries in the new component form */
 
 		//need to check not recursive bom component of itself!
-		If (!check_for_recursive_bom($selected_parent, $_POST['component'], &$db)) 
+		If (!check_for_recursive_bom($selected_parent, $_POST['component'])) 
 		{
 
 			/*Now check to see that the component is not already on the bom */