From: Joe Hunt <joe.hunt.consulting@gmail.com>
Date: Wed, 18 Nov 2009 09:54:04 +0000 (+0000)
Subject: Allow null references in trans to show up in gl_trans_view
X-Git-Tag: v2.4.2~19^2~1018
X-Git-Url: https://delta.frontaccounting.com/gitweb/?a=commitdiff_plain;h=88b2cfb623b090cc8b9be1c555df754105aaa4aa;p=fa-stable.git

Allow null references in trans to show up in gl_trans_view
---

diff --git a/CHANGELOG.txt b/CHANGELOG.txt
index bd9c0697..93fc3841 100644
--- a/CHANGELOG.txt
+++ b/CHANGELOG.txt
@@ -23,6 +23,8 @@ $ -> Affected files
 18-Nov-2009
 ! Release 2.2
 $ config.default.php
+# Allow null references in trans to show up in gl_trans_view
+$ /gl/view/gl_trans_view.php
 
 17-Nov-2009 Joe Hunt/Tom Hallman
 ! Moved payment terms in documents for better view. Increased
diff --git a/gl/view/gl_trans_view.php b/gl/view/gl_trans_view.php
index 295e551a..32276c3a 100644
--- a/gl/view/gl_trans_view.php
+++ b/gl/view/gl_trans_view.php
@@ -47,13 +47,12 @@ function display_gl_heading($myrow)
 
     end_table(1);
 }
-
-$sql = "SELECT gl.*, cm.account_name, refs.reference FROM "
-	.TB_PREF."gl_trans as gl, ".TB_PREF."chart_master as cm, ".TB_PREF."refs as refs"
-	." WHERE gl.account = cm.account_code"
-	." AND gl.type= ".db_escape($_GET['type_id']) 
+$sql = "SELECT gl.*, cm.account_name, IF(ISNULL(refs.reference), '', refs.reference) AS reference FROM "
+	.TB_PREF."gl_trans as gl
+	LEFT JOIN ".TB_PREF."chart_master as cm ON gl.account = cm.account_code
+	LEFT JOIN ".TB_PREF."refs as refs ON (gl.type=refs.type AND gl.type_no=refs.id)"
+	." WHERE gl.type= ".db_escape($_GET['type_id']) 
 	." AND gl.type_no = ".db_escape($_GET['trans_no'])
-	." AND gl.type=refs.type AND gl.type_no=refs.id"
 	." ORDER BY counter";
 $result = db_query($sql,"could not get transactions");
 //alert("sql = ".$sql);