From 9437de4193bde74b4a77e6ddcafede09b500c241 Mon Sep 17 00:00:00 2001 From: Joe Hunt Date: Tue, 27 Oct 2009 13:44:24 +0000 Subject: [PATCH] Removed unneeded double forms in scripts with db_pager. Missing $_POST variables. --- CHANGELOG.txt | 14 ++++++++++++++ dimensions/inquiry/search_dimensions.php | 3 --- manufacturing/search_work_orders.php | 3 --- .../allocations/supplier_allocation_main.php | 2 -- purchasing/inquiry/po_search.php | 2 -- purchasing/inquiry/po_search_completed.php | 2 -- purchasing/inquiry/supplier_allocation_inquiry.php | 2 -- purchasing/inquiry/supplier_inquiry.php | 2 -- sales/inquiry/customer_allocation_inquiry.php | 2 -- sales/inquiry/customer_inquiry.php | 3 +-- sales/inquiry/sales_deliveries_view.php | 3 --- sales/inquiry/sales_orders_view.php | 2 -- 12 files changed, 15 insertions(+), 25 deletions(-) diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 59635d77..c4f9cdb1 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -19,6 +19,20 @@ Legend: ! -> Note $ -> Affected files +27-Oct-2009 Joe Hunt +# Removed unneeded double forms in scripts with db_pager. Missing $_POST variables. +$ /dimensions/inquiry/search_dimensions.php + /manufacturing/search_work_orders.php + /purchasing/allocations/supplier_allocation_main.php + /purchasing/inquiry/po_search_completed.php + /purchasing/inquiry/po_search.php + /purchasing/inquiry/supplier_inquiry.php + /purchasing/inquiry/supplier_allocation_inquiry.php + /sales/inquiry/customer_allocation_inquiry.php + /sales/inquiry/sales_deliveries_view.php + /sales/inquiry/sales_orders_view.php + /sales/inquiry/customer_inquiry.php + 26-Oct-2009 Janusz Dobrowolski # [0000177] Fixed error during gl class update. $ /gl/includes/db/gl_db_account_types.inc diff --git a/dimensions/inquiry/search_dimensions.php b/dimensions/inquiry/search_dimensions.php index 752b5507..1c63c2fc 100644 --- a/dimensions/inquiry/search_dimensions.php +++ b/dimensions/inquiry/search_dimensions.php @@ -90,8 +90,6 @@ submit_cells('SearchOrders', _("Search"), '', '', 'default'); end_row(); end_table(); -end_form(); - $dim = get_company_pref('use_dimension'); function view_link($row) @@ -188,7 +186,6 @@ $table =& new_db_pager('dim_tbl', $sql, $cols); $table->set_marker('is_overdue', _("Marked dimensions are overdue.")); $table->width = "80%"; -start_form(); display_db_pager($table); diff --git a/manufacturing/search_work_orders.php b/manufacturing/search_work_orders.php index cf93441c..a088786c 100644 --- a/manufacturing/search_work_orders.php +++ b/manufacturing/search_work_orders.php @@ -79,8 +79,6 @@ submit_cells('SearchOrders', _("Search"),'',_('Select documents'), 'default'); end_row(); end_table(); -end_form(); - //----------------------------------------------------------------------------- function check_overdue($row) { @@ -226,7 +224,6 @@ $table =& new_db_pager('orders_tbl', $sql, $cols); $table->set_marker('check_overdue', _("Marked orders are overdue.")); $table->width = "90%"; -start_form(); display_db_pager($table); diff --git a/purchasing/allocations/supplier_allocation_main.php b/purchasing/allocations/supplier_allocation_main.php index 47360922..a3b04a53 100644 --- a/purchasing/allocations/supplier_allocation_main.php +++ b/purchasing/allocations/supplier_allocation_main.php @@ -38,7 +38,6 @@ start_form(); echo "
"; check(_("Show Settled Items:"), 'ShowSettled', null, true); echo "

"; - end_form(); set_global_supplier($_POST['supplier_id']); if (isset($_POST['supplier_id']) && ($_POST['supplier_id'] == ALL_TEXT)) @@ -112,7 +111,6 @@ $table =& new_db_pager('alloc_tbl', $sql, $cols); $table->set_marker('check_settled', _("Marked items are settled."), 'settledbg', 'settledfg'); $table->width = "80%"; -start_form(); display_db_pager($table); diff --git a/purchasing/inquiry/po_search.php b/purchasing/inquiry/po_search.php index a82a3743..a455e56c 100644 --- a/purchasing/inquiry/po_search.php +++ b/purchasing/inquiry/po_search.php @@ -71,7 +71,6 @@ stock_items_list_cells(_("Item:"), 'SelectStockFromList', null, true); submit_cells('SearchOrders', _("Search"),'',_('Select documents'), 'default'); end_row(); end_table(); -end_form(); //--------------------------------------------------------------------------------------------- function trans_view($trans) { @@ -188,7 +187,6 @@ $table =& new_db_pager('orders_tbl', $sql, $cols); $table->set_marker('check_overdue', _("Marked orders have overdue items.")); $table->width = "80%"; -start_form(); display_db_pager($table); diff --git a/purchasing/inquiry/po_search_completed.php b/purchasing/inquiry/po_search_completed.php index 23053bae..a7672f99 100644 --- a/purchasing/inquiry/po_search_completed.php +++ b/purchasing/inquiry/po_search_completed.php @@ -69,7 +69,6 @@ stock_items_list_cells(_("for item:"), 'SelectStockFromList', null, true); submit_cells('SearchOrders', _("Search"),'',_('Select documents'), 'default'); end_row(); end_table(); -end_form(); //--------------------------------------------------------------------------------------------- if (isset($_POST['order_number'])) { @@ -171,7 +170,6 @@ if (get_post('StockLocation') != $all_items) { $table =& new_db_pager('orders_tbl', $sql, $cols); $table->width = "80%"; -start_form(); display_db_pager($table); diff --git a/purchasing/inquiry/supplier_allocation_inquiry.php b/purchasing/inquiry/supplier_allocation_inquiry.php index 0a5c65d8..2f80b49c 100644 --- a/purchasing/inquiry/supplier_allocation_inquiry.php +++ b/purchasing/inquiry/supplier_allocation_inquiry.php @@ -60,7 +60,6 @@ set_global_supplier($_POST['supplier_id']); end_row(); end_table(); -end_form(); //------------------------------------------------------------------------------------------------ function check_overdue($row) { @@ -198,7 +197,6 @@ $table =& new_db_pager('doc_tbl', $sql, $cols); $table->set_marker('check_overdue', _("Marked items are overdue.")); $table->width = "90%"; -start_form(); display_db_pager($table); diff --git a/purchasing/inquiry/supplier_inquiry.php b/purchasing/inquiry/supplier_inquiry.php index 0ff50984..3a785659 100644 --- a/purchasing/inquiry/supplier_inquiry.php +++ b/purchasing/inquiry/supplier_inquiry.php @@ -54,7 +54,6 @@ submit_cells('RefreshInquiry', _("Search"),'',_('Refresh Inquiry'), 'default'); end_row(); end_table(); -end_form(); set_global_supplier($_POST['supplier_id']); //------------------------------------------------------------------------------------------------ @@ -234,7 +233,6 @@ $table =& new_db_pager('trans_tbl', $sql, $cols); $table->set_marker('check_overdue', _("Marked items are overdue.")); $table->width = "85%"; -start_form(); display_db_pager($table); diff --git a/sales/inquiry/customer_allocation_inquiry.php b/sales/inquiry/customer_allocation_inquiry.php index fae2ad0f..badd4b18 100644 --- a/sales/inquiry/customer_allocation_inquiry.php +++ b/sales/inquiry/customer_allocation_inquiry.php @@ -54,7 +54,6 @@ set_global_customer($_POST['customer_id']); end_row(); end_table(); -end_form(); //------------------------------------------------------------------------------------------------ function check_overdue($row) { @@ -225,7 +224,6 @@ $table =& new_db_pager('doc_tbl', $sql, $cols); $table->set_marker('check_overdue', _("Marked items are overdue.")); $table->width = "80%"; -start_form(); display_db_pager($table); diff --git a/sales/inquiry/customer_inquiry.php b/sales/inquiry/customer_inquiry.php index b076faad..9d397b94 100644 --- a/sales/inquiry/customer_inquiry.php +++ b/sales/inquiry/customer_inquiry.php @@ -54,7 +54,7 @@ cust_allocations_list_cells(null, 'filterType', $_POST['filterType'], true); submit_cells('RefreshInquiry', _("Search"),'',_('Refresh Inquiry'), 'default'); end_row(); end_table(); -end_form(); + set_global_customer($_POST['customer_id']); //------------------------------------------------------------------------------------------------ @@ -300,7 +300,6 @@ $table->set_marker('check_overdue', _("Marked items are overdue.")); $table->width = "85%"; -start_form(); display_db_pager($table); end_form(); diff --git a/sales/inquiry/sales_deliveries_view.php b/sales/inquiry/sales_deliveries_view.php index 72e6d132..aaa3421f 100644 --- a/sales/inquiry/sales_deliveries_view.php +++ b/sales/inquiry/sales_deliveries_view.php @@ -115,7 +115,6 @@ hidden('OutstandingOnly', $_POST['OutstandingOnly']); end_row(); end_table(); -end_form(); //--------------------------------------------------------------------------------------------- if (isset($_POST['SelectStockFromList']) && ($_POST['SelectStockFromList'] != "") && @@ -258,8 +257,6 @@ $table->set_marker('check_overdue', _("Marked items are overdue.")); //$table->width = "92%"; -start_form(); - display_db_pager($table); end_form(); diff --git a/sales/inquiry/sales_orders_view.php b/sales/inquiry/sales_orders_view.php index dac158ea..50a23276 100644 --- a/sales/inquiry/sales_orders_view.php +++ b/sales/inquiry/sales_orders_view.php @@ -242,7 +242,6 @@ hidden('type', $trans_type); end_row(); end_table(1); -end_form(); //--------------------------------------------------------------------------------------------- // Orders inquiry table // @@ -373,7 +372,6 @@ $table =& new_db_pager('orders_tbl', $sql, $cols); $table->set_marker('check_overdue', _("Marked items are overdue.")); $table->width = "80%"; -start_form(); display_db_pager($table); submit_center('Update', _("Update"), true, '', null); -- 2.30.2