From c92ce8dfc5b132d8168f8d60bc059cf1880e3ab9 Mon Sep 17 00:00:00 2001 From: Janusz Dobrowolski Date: Thu, 16 May 2013 12:39:10 +0200 Subject: [PATCH] Payments, Bank Transfer: Fixed payment limit checking bug. --- gl/bank_transfer.php | 2 +- gl/gl_bank.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gl/bank_transfer.php b/gl/bank_transfer.php index 439d6b6e..2ef0e4f6 100644 --- a/gl/bank_transfer.php +++ b/gl/bank_transfer.php @@ -139,7 +139,7 @@ function check_valid_entries() $amnt_tr = input_num('charge') + input_num('amount'); - if ($limit != null && ($limit < $amnt_tr)) + if ($limit != null && floatcmp($limit, $amnt_tr) < 0) { display_error(sprintf(_("The total bank amount exceeds allowed limit (%s) for source account."), price_format($limit))); set_focus('amount'); diff --git a/gl/gl_bank.php b/gl/gl_bank.php index 17547fb2..a0a2d11c 100644 --- a/gl/gl_bank.php +++ b/gl/gl_bank.php @@ -231,7 +231,7 @@ if (isset($_POST['Process'])) $amnt_chg = -$_SESSION['pay_items']->gl_items_total()-$_SESSION['pay_items']->original_amount; - if ($limit != null && ($limit + $amnt_chg < 0)) + if ($limit != null && floatcmp($limit, -$amnt_chg) < 0) { display_error(sprintf(_("The total bank amount exceeds allowed limit (%s)."), price_format($limit-$_SESSION['pay_items']->original_amount))); set_focus('code_id'); -- 2.30.2