Stock goes negative even, the negative inventory is turned off. Fix by kvvaradha.

[fa-stable.git] / admin / void_transaction.php

diff --git a/admin/void_transaction.php b/admin/void_transaction.php
index a77cbce983571970a3629fcecc9a048179bc0f6a..32d3a038e57cf1c12d250407f2c66402de5277f7 100644 (file)
--- a/admin/void_transaction.php
+++ b/admin/void_transaction.php
@@ -23,7 +23,7 @@ include_once($path_to_root . "/admin/db/voiding_db.inc");
 $js = "";
 if (user_use_date_picker())
        $js .= get_js_date_picker();
-if ($use_popup_windows)
+if ($SysPrefs->use_popup_windows)
        $js .= get_js_open_window(800, 500);
        
 page(_($help_context = "Void a Transaction"), false, false, "", $js);
@@ -73,7 +73,7 @@ function exist_transaction($type, $type_no)
                        return false;
 
                case ST_SUPPRECEIVE : // it's a GRN
-                       if (exists_grn_on_invoices($type_no))
+                       if (!exists_grn($type_no))
                                return false;
                        break;
 
@@ -104,7 +104,6 @@ function exist_transaction($type, $type_no)
                        return false;
                case ST_COSTUPDATE : // it's a stock cost update
                        return false;
-                       break;
        }
 
        return true;
@@ -223,7 +222,24 @@ function voiding_controls()
                }       
                else
                {
-               display_warning(_("Are you sure you want to void this transaction ? This action cannot be undone."), 0, 1);
+               if ($_POST['filterType'] == ST_SUPPRECEIVE) { 
+                $result = get_grn_items($_POST['trans_no']);
+                if (db_num_rows($result) > 0) {
+                    while ($myrow = db_fetch($result)) {
+                        if (is_inventory_item($myrow["item_code"])) {
+                            if (check_negative_stock($myrow["item_code"], -$myrow["qty_recd"], null, $_POST['date_'])) {
+                                $stock = get_item($myrow["item_code"]);
+                                display_error(_("The void cannot be processed because there is an insufficient quantity for item:") .
+                                    " " . $stock['stock_id'] . " - " . $stock['description'] . " - " .
+                                    _("Quantity On Hand") . " = " . number_format2(get_qoh_on_date($stock['stock_id'], null, 
+                                    $_POST['date_']), get_qty_dec($stock['stock_id'])));
+                                return false;
+                            }
+                        }
+                    }
+                }
+            }
+                       display_warning(_("Are you sure you want to void this transaction ? This action cannot be undone."), 0, 1);
                        br();
                submit_center_first('ConfirmVoiding', _("Proceed"), '', true);
                submit_center_last('CancelVoiding', _("Cancel"), '', 'cancel');
@@ -241,7 +257,7 @@ function check_valid_entries()
        {
                display_error(_("The selected transaction was closed for edition and cannot be voided."));
                set_focus('trans_no');
-               return;
+               return false;
        }
        if (!is_date($_POST['date_']))
        {
@@ -251,7 +267,7 @@ function check_valid_entries()
        }
        if (!is_date_in_fiscalyear($_POST['date_']))
        {
-               display_error(_("The entered date is not in fiscal year."));
+               display_error(_("The entered date is out of fiscal year or is closed for further data entry."));
                set_focus('date_');
                return false;
        }
@@ -283,18 +299,17 @@ function handle_void_transaction()
                        return;
                }
 
-               $ret = void_transaction($_POST['filterType'], $_POST['trans_no'],
+               $msg = void_transaction($_POST['filterType'], $_POST['trans_no'],
                        $_POST['date_'], $_POST['memo_']);
 
-               if ($ret) 
+               if (!$msg) 
                {
                        display_notification_centered(_("Selected transaction has been voided."));
                        unset($_POST['trans_no']);
                        unset($_POST['memo_']);
-                       unset($_POST['date_']);
                }
                else {
-                       display_error(_("The entered transaction does not exist or cannot be voided."));
+                       display_error($msg);
                        set_focus('trans_no');
 
                }
@@ -320,6 +335,7 @@ if (isset($_POST['ProcessVoiding']))
 if (isset($_POST['ConfirmVoiding']))
 {
        handle_void_transaction();
+       $selected_id = '';
        $Ajax->activate('_page_body');
 }