Credit note can be posted without customer selected when search customer List is...
[fa-stable.git] / purchasing / supplier_credit.php
index 0d1e6c9fd75455983b2a322037187d08a3cfdc12..4bfc235e52f4cd581b4e9be4de6bf2884929a570 100644 (file)
@@ -21,17 +21,18 @@ include_once($path_to_root . "/includes/data_checks.inc");
 include_once($path_to_root . "/purchasing/includes/purchasing_db.inc");
 include_once($path_to_root . "/purchasing/includes/purchasing_ui.inc");
 $js = "";
-if ($use_popup_windows)
+if ($SysPrefs->use_popup_windows)
        $js .= get_js_open_window(900, 500);
-if ($use_date_picker)
+if (user_use_date_picker())
        $js .= get_js_date_picker();
 
 //----------------------------------------------------------------------------------------
 
-check_db_has_suppliers(_("There are no suppliers defined in the system."));
-
-if (isset($_GET['ModifyCredit']))
-       check_is_editable(ST_SUPPINVOICE, $_GET['ModifyCredit']);
+if (isset($_GET['ModifyCredit'])) {
+    check_is_editable(ST_SUPPCREDIT, $_GET['ModifyCredit']);
+    $_SESSION['page_title'] = sprintf( _("Modifying Supplier Credit # %d"), $_GET['ModifyCredit']);
+    $_SESSION['supp_trans'] = new supp_trans(ST_SUPPCREDIT, $_GET['ModifyCredit']);
+}
 
 //---------------------------------------------------------------------------------------------------
 
@@ -47,13 +48,12 @@ if (isset($_GET['New']))
        if (isset($_GET['invoice_no']))
        {
                $_SESSION['supp_trans'] = new supp_trans(ST_SUPPINVOICE, $_GET['invoice_no']);
-               $_SESSION['supp_trans']->src_doc = $_GET['invoice_no'];
+               $_SESSION['supp_trans']->src_docs = array( $_GET['invoice_no'] => $_SESSION['supp_trans']->supp_reference);
 
 
                $_SESSION['supp_trans']->trans_type = ST_SUPPCREDIT;
                $_SESSION['supp_trans']->trans_no = 0;
                $_SESSION['supp_trans']->supp_reference = '';
-               //              $_SESSION['supp_trans']->supp_reference = $_POST['invoice_no'] = $_GET['invoice_no'];
                $help_context = "Supplier Credit Note";
                $_SESSION['page_title'] = _("Supplier Credit Note");
 
@@ -65,6 +65,8 @@ if (isset($_GET['New']))
 }
 page($_SESSION['page_title'], false, false, "", $js);
 
+check_db_has_suppliers(_("There are no suppliers defined in the system."));
+
 //---------------------------------------------------------------------------------------------------------------
 
 if (isset($_GET['AddedID'])) 
@@ -161,36 +163,28 @@ if (isset($_POST['AddGLCodeToTrans'])) {
 
 function check_data()
 {
-       global $total_grn_value, $total_gl_value, $Refs, $SysPrefs;
+       global $SysPrefs;
 
-       if (!$_SESSION['supp_trans']->is_valid_trans_to_post())
+       if (!get_post('supplier_id')) 
        {
-               display_error(_("The credit note cannot be processed because the there are no items or values on the invoice.  Credit notes are expected to have a charge."));
-               set_focus('');
+               display_error(_("There is no supplier selected."));
+               set_focus('supplier_id');
                return false;
-       }
+       } 
 
-       if (!$Refs->is_valid($_SESSION['supp_trans']->reference)) 
+       if (!$_SESSION['supp_trans']->is_valid_trans_to_post())
        {
-               display_error(_("You must enter an credit note reference."));
-               set_focus('reference');
+               display_error(_("The credit note cannot be processed because the there are no items or values on the invoice.  Credit notes are expected to have a charge."));
+               set_focus('');
                return false;
        }
 
-       if (!is_new_reference($_SESSION['supp_trans']->reference, ST_SUPPCREDIT, $_SESSION['supp_trans']->trans_no))
+       if (!check_reference($_SESSION['supp_trans']->reference, ST_SUPPCREDIT, $_SESSION['supp_trans']->trans_no))
        {
-               display_error(_("The entered reference is already in use."));
                set_focus('reference');
                return false;
        }
 
-       if (!$Refs->is_valid($_SESSION['supp_trans']->supp_reference)) 
-       {
-               display_error(_("You must enter a supplier's credit note reference."));
-               set_focus('supp_reference');
-               return false;
-       }
-
        if (!is_date($_SESSION['supp_trans']->tran_date))
        {
                display_error(_("The credit note as entered cannot be processed because the date entered is not valid."));
@@ -210,9 +204,17 @@ function check_data()
                return false;
        }
 
-       if ($_SESSION['supp_trans']->ov_amount < ($total_gl_value + $total_grn_value))
+       if (trim(get_post('supp_reference')) == false)
        {
-               display_error(_("The credit note total as entered is less than the sum of the the general ledger entires (if any) and the charges for goods received. There must be a mistake somewhere, the credit note as entered will not be processed."));
+               display_error(_("You must enter a supplier's invoice reference."));
+               set_focus('supp_reference');
+               return false;
+       }
+
+       if (is_reference_already_there($_SESSION['supp_trans']->supplier_id, $_POST['supp_reference'], $_SESSION['supp_trans']->trans_no))
+       {       /*Transaction reference already entered */
+               display_error(_("This invoice number has already been entered. It cannot be entered again.") . " (" . $_POST['supp_reference'] . ")");
+               set_focus('supp_reference');
                return false;
        }
 
@@ -225,7 +227,8 @@ function check_data()
                                        $stock = get_item($item->item_code);
                                        display_error(_("The return cannot be processed because there is an insufficient quantity for item:") .
                                                " " . $stock['stock_id'] . " - " . $stock['description'] . " - " .
-                                               _("Quantity On Hand") . " = " . number_format2($qoh, get_qty_dec($stock['stock_id'])));
+                                               _("Quantity On Hand") . " = " . number_format2(get_qoh_on_date($stock['stock_id'], null, 
+                                               $_SESSION['supp_trans']->tran_date), get_qty_dec($stock['stock_id'])));
                                        return false;
                                }
                        }
@@ -289,8 +292,8 @@ function commit_item_data($n)
                $_POST['po_detail_item'.$n], $_POST['item_code'.$n],
                $_POST['item_description'.$n], $_POST['qty_recd'.$n],
                $_POST['prev_quantity_inv'.$n], input_num('This_QuantityCredited'.$n),
-               $_POST['order_price'.$n], input_num('ChgPrice'.$n),
-               $_POST['std_cost_unit'.$n], "");
+               $_POST['order_price'.$n], input_num('ChgPrice'.$n));
+               reset_tax_input();
        }
 }
 
@@ -356,9 +359,9 @@ invoice_header($_SESSION['supp_trans']);
 if ($_POST['supplier_id']=='') 
        display_error('No supplier found for entered search text');
 else {
-       $total_grn_value = display_grn_items($_SESSION['supp_trans'], 1);
+       display_grn_items($_SESSION['supp_trans'], 1);
 
-       $total_gl_value = display_gl_items($_SESSION['supp_trans'], 1);
+       display_gl_items($_SESSION['supp_trans'], 1);
 
        div_start('inv_tot');
        invoice_totals($_SESSION['supp_trans']);
@@ -380,4 +383,3 @@ br();
 
 end_form();
 end_page();
-?>