Fixed error creating customer credit note: Undefined index: sales_gl_code. @notrinos.

[fa-stable.git] / taxes / tax_calc.inc

diff --git a/taxes/tax_calc.inc b/taxes/tax_calc.inc
index dbb7999e46f0548cf576ac9380755533abf13f37..3ef685aef1cda24d34d4ea9c5f58d34c3cd0edb1 100644 (file)
--- a/taxes/tax_calc.inc
+++ b/taxes/tax_calc.inc
@@ -18,7 +18,6 @@ include_once($path_to_root . "/taxes/db/item_tax_types_db.inc");
 // returns the price of a given item minus any included taxes
 // for item $stock_id with line price $price,
 // with applicable tax rates $tax_group_array or group id $tax_group
-//
 
 function get_tax_free_price_for_item($stock_id, $price, $tax_group, $tax_included, $tax_group_array=null)
 {
@@ -34,23 +33,25 @@ function get_tax_free_price_for_item($stock_id, $price, $tax_group, $tax_include
        else
                $ret_tax_array = get_tax_group_items_as_array($tax_group);
        
-       //print_r($ret_tax_array);
-
        $tax_array = get_taxes_for_item($stock_id, $ret_tax_array);
+
        // if no exemptions or taxgroup is empty, then no included/excluded taxes
        if ($tax_array == null)
                return $price;
-       
-       $tax_multiplier = 0;
-
-       // loop for all taxes
 
+       // to avoid rounding errors we have to just subtract taxes from tax_included price.
+       $tax_multiplier = 0;
        foreach ($tax_array as $taxitem) 
        {
                $tax_multiplier += $taxitem["rate"];
        }
 
-       return round($price / (1 + ($tax_multiplier / 100)),  user_price_dec());
+       $tax = 0;
+       foreach ($tax_array as $taxitem)
+       {
+               $tax += round($price*$taxitem['rate']/(100+$tax_multiplier), user_price_dec());
+       }
+       return $price-$tax;
 }
 //
 //     Full price (incl. VAT) for item $stock_id with line price $price,
@@ -77,7 +78,7 @@ function get_full_price_for_item($stock_id, $price, $tax_group, $tax_included, $
        if ($tax_array == null)
                return $price;
        
-       $tax_multiplier = 0;    
+       $tax_multiplier = 0;
 
        // loop for all items
 
@@ -116,7 +117,7 @@ function get_taxes_for_item($stock_id, $tax_group_items_array)
        foreach ($tax_group_items_array as $tax_group_item) 
        { 
                
-               $skip = false;                  
+               $skip = false;
                
                // if it's in the exemptions, skip
                foreach ($item_tax_type_exemptions as $exemption) 
@@ -146,38 +147,53 @@ function get_tax_for_items($items, $prices, $shipping_cost, $tax_group, $tax_inc
                $tax_algorithm = get_company_pref('tax_algorithm');
        // first create and set an array with all the tax types of the tax group
        if($tax_items_array!=null)
-         $ret_tax_array = $tax_items_array;
+               $ret_tax_array = $tax_items_array;
        else
-         $ret_tax_array = get_tax_group_items_as_array($tax_group);
+               $ret_tax_array = get_tax_group_items_as_array($tax_group);
 
+       $dec = user_price_dec();
+
+       $fully_exempt = true;
        foreach($ret_tax_array as $k=>$t)
+       {
+               if ($t['rate'] !== null)
+                       $fully_exempt = false;
                $ret_tax_array[$k]['Net'] = 0;
-
+       }
+       
+       $ret_tax_array['exempt'] = array('Value'=>0, 'Net'=>0, 'rate' => null, 'tax_type_id' => '', 'sales_gl_code' => '');
        $dec = user_price_dec();
        // loop for all items
        for ($i = 0; $i < count($items); $i++)
        {
                $item_taxes = get_taxes_for_item($items[$i], $ret_tax_array);
-
-               if ($item_taxes != null) 
+               if ($item_taxes == null || $fully_exempt) 
                {
+                         $ret_tax_array['exempt']['Value'] += round2(0, $dec);
+                         $ret_tax_array['exempt']['Net'] += $prices[$i];
+               }
+               else
+               {
+                       $tax_multiplier = 0;
+                       foreach ($item_taxes as $taxitem) 
+                       {
+                               $tax_multiplier += $taxitem['rate'];
+                       }
                        foreach ($item_taxes as $item_tax) 
                        {
                                if ($item_tax['rate'] !== null) {
                                        $index = $item_tax['tax_type_id'];
-                                       if($tax_included==1) {// 2008-11-26 Joe Hunt Taxes are stored without roundings
-                                         $nprice = get_tax_free_price_for_item($items[$i], $prices[$i], $tax_group, $tax_included, null, $item_tax['tax_type_id']);
-                                         $ret_tax_array[$index]['Value'] += $nprice*$item_tax['rate']/100;
-                                         $ret_tax_array[$index]['Net'] += $nprice;
+                                       if ($tax_included == 1) {
+                                               $ret_tax_array[$index]['Value'] += round2($prices[$i]*$item_tax['rate']/(100+$tax_multiplier), $dec);
+                                               $ret_tax_array[$index]['Net'] += round2($prices[$i]*100/(100+$tax_multiplier), $dec);
                                        } else {
-                                         $ret_tax_array[$index]['Value'] += ($prices[$i] * $item_tax['rate'] / 100);
-                                         $ret_tax_array[$index]['Net'] += $prices[$i];
+                                               $ret_tax_array[$index]['Value'] += round2($prices[$i] * $item_tax['rate'] / 100, $dec);
+                                               $ret_tax_array[$index]['Net'] += $prices[$i];
                                        }
                                }
                        }
                }
        }
-       
        // add the shipping taxes, only if non-zero, and only if tax group taxes shipping
        if ($shipping_cost != 0) 
        {
@@ -194,24 +210,24 @@ function get_tax_for_items($items, $prices, $shipping_cost, $tax_group, $tax_inc
                                                $tax_rate += $item_tax['rate'];
                                        }
                                }
-                               $shipping_net = round2($shipping_cost / (1 + ($tax_rate / 100)), $dec);
-                       }       
+                               $shipping_net = round2($shipping_cost*100/(100+$tax_rate), $dec);
+                       }
                        foreach ($item_taxes as $item_tax) 
                        {
                                $index = $item_tax['tax_type_id'];
                                if ($item_tax['rate'] !== null && $ret_tax_array[$index]['rate'] !== null) {
-                                         if($tax_included==1) {// 2008-11-26 Joe Hunt Taxes are stored without roundings
-                                               $ret_tax_array[$index]['Value'] += ($shipping_net * $item_tax['rate'] / 100);
-                                           $ret_tax_array[$index]['Net'] += $shipping_net;
-                                         } else {
-                                               $ret_tax_array[$index]['Value'] += ($shipping_cost * $item_tax['rate'] / 100);
-                                           $ret_tax_array[$index]['Net'] += $shipping_cost;
-                                         }
+                                       if($tax_included==1) {
+                                               $ret_tax_array[$index]['Value'] += round2($shipping_cost*$item_tax['rate']/(100+$tax_rate), $dec);
+                                               $ret_tax_array[$index]['Net'] += $shipping_net;
+                                       } else {
+                                               $ret_tax_array[$index]['Value'] += round2($shipping_cost * $item_tax['rate'] / 100, $dec);
+                                               $ret_tax_array[$index]['Net'] += $shipping_cost;
+                                       }
                                }
                        }
                }
        }
-       
+
        if ($tax_algorithm == TCA_TOTALS ) {
                // update taxes with 
                foreach($ret_tax_array as $index => $item_tax) {
@@ -222,4 +238,3 @@ function get_tax_for_items($items, $prices, $shipping_cost, $tax_group, $tax_inc
        return $ret_tax_array;
 }
 
-?>
\ No newline at end of file