Bug in gl/includes/db/gl_journal.inc. Fixed by @barbarian.
authorJoe Hunt <joe.hunt.consulting@gmail.com>
Sun, 8 Aug 2021 10:29:42 +0000 (12:29 +0200)
committerJoe Hunt <joe.hunt.consulting@gmail.com>
Sun, 8 Aug 2021 10:29:42 +0000 (12:29 +0200)
gl/includes/db/gl_journal.inc

index c44cb335b3328b8fd15179cecb5259439ed66d5a..56ec39c31ab5063209cae4d34d257117af7ff485 100644 (file)
@@ -71,12 +71,10 @@ function write_cust_journal($trans_type, $trans_no, $branch_id, $date, $ref, $am
 {
        // we have to select any branch_id for given AR_act - in fact w
        $sql = "INSERT INTO ".TB_PREF."debtor_trans (trans_no, type, debtor_no, branch_code, tran_date, reference, ov_amount, rate)
-               SELECT "
-               .db_escape($trans_no).", ".db_escape($trans_type).", debtor_no,"
-               .db_escape($branch_id).",'".date2sql($date)."', ".db_escape($ref).","
-               .db_escape($amount).", ".db_escape($rate)."
-               FROM ".TB_PREF."cust_branch WHERE branch_code=".db_escape($branch_id);
-
+        VALUES (".db_escape($trans_no).", ".db_escape($trans_type).", 
+                       (SELECT debtor_no FROM ".TB_PREF."cust_branch WHERE branch_code=".db_escape($branch_id). ") ,"
+                       .db_escape($branch_id).",'".date2sql($date)."', ".db_escape($ref).","
+                       .db_escape($amount).", ".db_escape($rate).")";
        return db_query($sql, 'cannot write cust_journal');
 }