From: Joe Hunt Date: Tue, 15 Jun 2021 11:12:14 +0000 (+0200) Subject: More php8 deprecation fixes about required parameters following optional parameters. X-Git-Url: https://delta.frontaccounting.com/gitweb/?p=fa-stable.git;a=commitdiff_plain;h=3663b9dc3763c91e4dc76cc791420af853daded6 More php8 deprecation fixes about required parameters following optional parameters. --- diff --git a/gl/includes/db/gl_db_banking.inc b/gl/includes/db/gl_db_banking.inc index 1a6aed3e..14c7f14f 100644 --- a/gl/includes/db/gl_db_banking.inc +++ b/gl/includes/db/gl_db_banking.inc @@ -143,7 +143,7 @@ function get_account_home_balance($person_id, $person_type, $rec_account, $to_da // Note: in 2.4.9 sparse 'ref' argument was removed (generated transactions use // next references from default refline). // -function add_exchange_variation_all($date=null, $memo) +function add_exchange_variation_all($date, $memo) { begin_transaction(); $exchanged = false; diff --git a/gl/includes/db/gl_db_rates.inc b/gl/includes/db/gl_db_rates.inc index 4118492e..705c57d8 100644 --- a/gl/includes/db/gl_db_rates.inc +++ b/gl/includes/db/gl_db_rates.inc @@ -126,7 +126,7 @@ function retrieve_exrate($curr_b, $date) } //----------------------------------------------------------------------------- -function get_extern_rate($curr_b, $provider = 'ECB', $date) +function get_extern_rate($curr_b, $provider, $date) { global $path_to_root; diff --git a/includes/current_user.inc b/includes/current_user.inc index 82c8daaf..0ee56899 100644 --- a/includes/current_user.inc +++ b/includes/current_user.inc @@ -377,7 +377,7 @@ if (!function_exists('money_format')) // 2008-06-15. Added extra parameter $stock_id and reference for $dec //-------------------------------------------------------------------- -function qty_format($number, $stock_id=null, &$dec) { +function qty_format($number, $stock_id, &$dec) { $dec = get_qty_dec($stock_id); return number_format2($number, $dec); } diff --git a/includes/db/class.data_set.inc b/includes/db/class.data_set.inc index 93846d0d..e81b8ba3 100644 --- a/includes/db/class.data_set.inc +++ b/includes/db/class.data_set.inc @@ -97,7 +97,7 @@ abstract class record_set { * @key - record key (u/d) * @data - data to be validated (i/u) **/ - function _validate($key=null, $data) + function _validate($key, $data) { $mode = isset($data) ? (isset($key) ? 'u' : 'i') : 'd'; diff --git a/includes/ui/ui_lists.inc b/includes/ui/ui_lists.inc index 5ca6a49d..1d804985 100644 --- a/includes/ui/ui_lists.inc +++ b/includes/ui/ui_lists.inc @@ -2310,7 +2310,7 @@ function quick_entries_list($name, $selected_id=null, $type=null, $submit_on_cha } -function quick_entries_list_cells($label, $name, $selected_id=null, $type, $submit_on_change=false) +function quick_entries_list_cells($label, $name, $selected_id, $type, $submit_on_change=false) { if ($label != null) echo "$label\n"; @@ -2319,7 +2319,7 @@ function quick_entries_list_cells($label, $name, $selected_id=null, $type, $subm echo ""; } -function quick_entries_list_row($label, $name, $selected_id=null, $type, $submit_on_change=false) +function quick_entries_list_row($label, $name, $selected_id, $type, $submit_on_change=false) { echo "$label"; quick_entries_list_cells(null, $name, $selected_id, $type, $submit_on_change); diff --git a/includes/ui/ui_view.inc b/includes/ui/ui_view.inc index 99a753d5..d4e1c50b 100644 --- a/includes/ui/ui_view.inc +++ b/includes/ui/ui_view.inc @@ -270,7 +270,7 @@ function check_ui_refresh($name=null) // When there is no exrate for today, // gets it form ECB and stores in local database. // -function exchange_rate_display($from_currency=null, $to_currency=null, $date_, $force_edit=false) +function exchange_rate_display($from_currency, $to_currency, $date_, $force_edit=false) { global $Ajax, $SysPrefs; diff --git a/inventory/includes/db/items_db.inc b/inventory/includes/db/items_db.inc index 07fde0d1..02345a67 100644 --- a/inventory/includes/db/items_db.inc +++ b/inventory/includes/db/items_db.inc @@ -10,7 +10,7 @@ See the License here . ***********************************************************************/ function update_item($stock_id, $description, $long_description, $category_id, - $tax_type_id, $units='', $mb_flag='', $sales_account, $inventory_account, + $tax_type_id, $units, $mb_flag, $sales_account, $inventory_account, $cogs_account, $adjustment_account, $wip_account, $dimension_id, $dimension2_id, $no_sale, $editable, $no_purchase, $depreciation_method = 'D', $depreciation_rate=100, $depreciation_factor=1, diff --git a/purchasing/includes/db/suppalloc_db.inc b/purchasing/includes/db/suppalloc_db.inc index e8506bb0..ad83e7e4 100644 --- a/purchasing/includes/db/suppalloc_db.inc +++ b/purchasing/includes/db/suppalloc_db.inc @@ -100,7 +100,7 @@ function clear_supp_alloctions($type, $type_no, $person_id=null, $date="") } //------------------------------------------------------------------------------------------------------------- -function get_allocatable_from_supp_sql($supplier_id=null, $settled) +function get_allocatable_from_supp_sql($supplier_id, $settled) { $sql = "SELECT trans.type, diff --git a/sales/includes/db/custalloc_db.inc b/sales/includes/db/custalloc_db.inc index a1f6a61c..6dc3ee04 100644 --- a/sales/includes/db/custalloc_db.inc +++ b/sales/includes/db/custalloc_db.inc @@ -98,7 +98,7 @@ function clear_cust_alloctions($type, $type_no, $person_id=null, $date="") } //------------------------------------------------------------------------------------------------------------- -function get_allocatable_from_cust_sql($customer_id=null, $settled) +function get_allocatable_from_cust_sql($customer_id, $settled) { $sql = "SELECT trans.type,