From: Joe <joe.hunt.consulting@gmail.com>
Date: Wed, 15 Nov 2023 07:58:24 +0000 (+0100)
Subject: Better sql construct in sales/includes/db/sales_order_db.inc
X-Git-Url: https://delta.frontaccounting.com/gitweb/?p=fa-stable.git;a=commitdiff_plain;h=6c40a3be4a79826087d7abbdd11b483f19decc2a

Better sql construct in sales/includes/db/sales_order_db.inc
---

diff --git a/sales/includes/db/sales_order_db.inc b/sales/includes/db/sales_order_db.inc
index d144995d..f2c62840 100644
--- a/sales/includes/db/sales_order_db.inc
+++ b/sales/includes/db/sales_order_db.inc
@@ -642,14 +642,11 @@ function last_sales_order_detail($order, $field)
 {
         $sql = "SELECT $field
             FROM ".TB_PREF."sales_order_details d
-            WHERE order_no =
-            (SELECT order_no FROM ".TB_PREF."sales_orders o
+            LEFT JOIN " .TB_PREF."sales_orders o on d.order_no=o.order_no
             WHERE debtor_no=" . db_escape($order->customer_id) . "
-            ORDER BY order_no DESC LIMIT 1)
-            ORDER BY d.id DESC LIMIT 1";        
+            ORDER BY d.id DESC LIMIT 1";
 
         $last_query=db_query($sql, "Could not retrieve last order detail");
         $row = db_fetch_row($last_query);
         return $row == false ? false : $row[0];
 }
-