From: Joe Hunt <joe.hunt.consulting@gmail.com>
Date: Wed, 16 Jun 2021 07:41:04 +0000 (+0200)
Subject: Bug 5460: Inventory valuation report does not discard zero quantity items for items... 
X-Git-Url: https://delta.frontaccounting.com/gitweb/?p=fa-stable.git;a=commitdiff_plain;h=94bf04846cc052990ff3086c2e6f6fc1e2058f17

Bug 5460: Inventory valuation report does not discard zero quantity items for items with decimal quantity units. Fixed.
---

diff --git a/reporting/rep301.php b/reporting/rep301.php
index 16e96191..5d04754b 100644
--- a/reporting/rep301.php
+++ b/reporting/rep301.php
@@ -97,24 +97,27 @@ function getTransactions($category, $location, $date)
 			item.units,
 			item.description, item.inactive,
 			move.loc_code,
+			units.decimals,
 			SUM(move.qty) AS QtyOnHand, 
 			item.material_cost AS UnitCost,
 			SUM(move.qty) * item.material_cost AS ItemTotal 
 			FROM "
 			.TB_PREF."stock_master item,"
 			.TB_PREF."stock_category category,"
-			.TB_PREF."stock_moves move
+			.TB_PREF."stock_moves move,"
+			.TB_PREF."item_units units
 		WHERE item.stock_id=move.stock_id
 		AND item.category_id=category.category_id
 		AND item.mb_flag<>'D' AND mb_flag <> 'F' 
 		AND move.tran_date <= '$date'
+		AND item.units=units.abbr
 		GROUP BY item.category_id,
 			category.description, ";
 		if ($location != 'all')
 			$sql .= "move.loc_code, ";
 		$sql .= "item.stock_id,
 			item.description
-		HAVING SUM(move.qty) != 0";
+		HAVING ROUND(SUM(move.qty), units.decimals) != 0";
 		if ($category != 0)
 			$sql .= " AND item.category_id = ".db_escape($category);
 		if ($location != 'all')