From: Janusz Dobrowolski <janusz@frontaccounting.eu>
Date: Wed, 10 Oct 2018 13:47:28 +0000 (+0200)
Subject: [0004212] Work Order Entry: fixed error when voided WO refence is reused.
X-Git-Url: https://delta.frontaccounting.com/gitweb/?p=fa-stable.git;a=commitdiff_plain;h=da7df35c61205d0b1af47d286be591b8a3194b0c

[0004212] Work Order Entry: fixed error when voided WO refence is reused.
---

diff --git a/manufacturing/includes/db/work_orders_db.inc b/manufacturing/includes/db/work_orders_db.inc
index f6d4400d..e1b0329e 100644
--- a/manufacturing/includes/db/work_orders_db.inc
+++ b/manufacturing/includes/db/work_orders_db.inc
@@ -287,7 +287,8 @@ function void_work_order($woid)
 	void_wo_requirements($woid);
 
 	// close workorder
-	$sql = "UPDATE ".TB_PREF."workorders SET closed=1,units_reqd=0,units_issued=0 WHERE id = "
+	// FIXME: due to bug in 2.4 db scheme (conflicting wo_ref unique key) we have to fix wo_ref here:
+	$sql = "UPDATE ".TB_PREF."workorders SET closed=1,units_reqd=0,units_issued=0, wo_ref=CONCAT(wo_ref, ' ', '".uniqid()."') WHERE id = "
 		.db_escape($woid);
 	db_query($sql, "The work order couldn't be voided");