From: Joe Hunt Date: Tue, 6 Jul 2021 07:19:44 +0000 (+0200) Subject: Mysqli errors: Trying to access array offset on value of type bool. Fixed. Please... X-Git-Url: https://delta.frontaccounting.com/gitweb/?p=fa-stable.git;a=commitdiff_plain;h=df671df0181c7b578bb75e07e581c5e9878e2aaa Mysqli errors: Trying to access array offset on value of type bool. Fixed. Please report any remains. --- diff --git a/admin/db/tags_db.inc b/admin/db/tags_db.inc index b33de825..40602a94 100644 --- a/admin/db/tags_db.inc +++ b/admin/db/tags_db.inc @@ -65,7 +65,7 @@ function get_tag_type($id) $result = db_query($sql, "could not get tag type"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } //-------------------------------------------------------------------------------------- @@ -105,7 +105,7 @@ function get_tag_description($id) $result = db_query($sql, "could not get tag description"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } //-------------------------------------------------------------------------------------- diff --git a/fixed_assets/includes/fa_classes_db.inc b/fixed_assets/includes/fa_classes_db.inc index 37fb5ceb..8bbf8405 100644 --- a/fixed_assets/includes/fa_classes_db.inc +++ b/fixed_assets/includes/fa_classes_db.inc @@ -27,7 +27,7 @@ function get_fixed_asset_classname($class) $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function update_fixed_asset_class($fa_class_id, $parent_id, $description, $long_description, $depreciation_rate) diff --git a/gl/bank_account_reconcile.php b/gl/bank_account_reconcile.php index a5738946..6875e068 100644 --- a/gl/bank_account_reconcile.php +++ b/gl/bank_account_reconcile.php @@ -175,7 +175,7 @@ if ($id != -1) change_tpl_flag($id); -if (isset($_POST['Reconcile'])) { +if (isset($_POST['last']) && isset($_POST['Reconcile'])) { set_focus('bank_date'); foreach($_POST['last'] as $id => $value) if ($value != check_value('rec_'.$id)) @@ -184,7 +184,7 @@ if (isset($_POST['Reconcile'])) { $Ajax->activate('_page_body'); } -if (isset($_POST['ReconcileAll'])) { +if (isset($_POST['last']) && isset($_POST['ReconcileAll'])) { set_focus('bank_date'); foreach($_POST['last'] as $id => $value) set_tpl_flag($id); diff --git a/gl/includes/db/gl_db_account_types.inc b/gl/includes/db/gl_db_account_types.inc index 4d6d58e8..04fd9e99 100644 --- a/gl/includes/db/gl_db_account_types.inc +++ b/gl/includes/db/gl_db_account_types.inc @@ -98,7 +98,7 @@ function get_account_type_name($id) $result = db_query($sql, "could not get account type"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function delete_account_type($id) diff --git a/gl/includes/db/gl_db_rates.inc b/gl/includes/db/gl_db_rates.inc index 705c57d8..525a6e2e 100644 --- a/gl/includes/db/gl_db_rates.inc +++ b/gl/includes/db/gl_db_rates.inc @@ -32,7 +32,7 @@ function get_date_exchange_rate($curr_code, $date_) if(db_num_rows($result) == 0) return 0; $row = db_fetch($result); - return $row[0]; + return $row[0]; } /* diff --git a/gl/includes/ui/gl_bank_ui.inc b/gl/includes/ui/gl_bank_ui.inc index 34a4fed9..a4a95b85 100644 --- a/gl/includes/ui/gl_bank_ui.inc +++ b/gl/includes/ui/gl_bank_ui.inc @@ -74,7 +74,7 @@ function display_bank_header(&$order) hidden('PersonDetailID'); } $trans = get_customer_habit($_POST['person_id']); // take care of customers on hold - if ($trans['dissallow_invoices'] != 0) + if (is_array($trans) && $trans['dissallow_invoices'] != 0) { if ($payment) { @@ -230,14 +230,14 @@ function gl_edit_item_controls(&$order, $dim, $Index=null) if ($_POST['PayType'] == PT_CUSTOMER) { $acc = get_branch_accounts($_POST['PersonDetailID']); - $_POST['code_id'] = $acc['receivables_account']; + $_POST['code_id'] = is_array($acc) ? $acc['receivables_account'] : ''; } elseif ($_POST['PayType'] == PT_SUPPLIER) { $acc = get_supplier_accounts($_POST['person_id']); - $_POST['code_id'] = $acc['payable_account']; - $_POST['dimension_id'] = $acc['dimension_id']; - $_POST['dimension2_id'] = $acc['dimension2_id']; + $_POST['code_id'] = is_array($acc) ? $acc['payable_account'] : ''; + $_POST['dimension_id'] = is_array($acc) ? $acc['dimension_id'] : ''; + $_POST['dimension2_id'] = is_array($acc) ? $acc['dimension2_id'] : ''; } else { $_POST['code_id'] = diff --git a/includes/data_checks.inc b/includes/data_checks.inc index 4b968904..d6e5261a 100644 --- a/includes/data_checks.inc +++ b/includes/data_checks.inc @@ -567,7 +567,7 @@ function check_empty_result($sql) $result = db_query($sql, "could not do check empty query"); $myrow = db_fetch_row($result); - return $myrow[0] > 0; + return is_array($myrow) ? $myrow[0] > 0 : false; } // // Integer input check diff --git a/includes/db/crm_contacts_db.inc b/includes/db/crm_contacts_db.inc index e5a91fb1..98862b73 100644 --- a/includes/db/crm_contacts_db.inc +++ b/includes/db/crm_contacts_db.inc @@ -242,7 +242,7 @@ function get_crm_category_name($id) $result = db_query($sql, "could not get sales type"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } //---------------------------------------------------------------------------------------- diff --git a/includes/db/inventory_db.inc b/includes/db/inventory_db.inc index 4ffda2e7..9032e085 100644 --- a/includes/db/inventory_db.inc +++ b/includes/db/inventory_db.inc @@ -94,7 +94,7 @@ function get_item_edit_info($stock_id) $result = db_query($sql, "The standard cost cannot be retrieved"); $row = db_fetch($result); - if ($row['decimals'] == -1) + if (is_array($row) && $row['decimals'] == -1) $row['decimals'] = user_qty_dec(); return $row; } @@ -110,7 +110,7 @@ function get_unit_cost($stock_id) $myrow = db_fetch_row($result); - return $myrow[0]; + return is_array($myrow) ? $myrow[0] : false; } //-------------------------------------------------------------------------------------- @@ -124,7 +124,7 @@ function get_purchase_cost($stock_id) $myrow = db_fetch_row($result); - return $myrow[0]; + return is_array($myrow) ? $myrow[0] : false; } //-------------------------------------------------------------------------------------- @@ -170,7 +170,7 @@ function get_already_delivered($stock_id, $location, $trans_no) AND type=".ST_CUSTDELIVERY." AND trans_no=".db_escape($trans_no); $result = db_query($sql, "Could not get stock moves"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } /* Returns start move_id in latest negative status period for $stock_id @@ -348,7 +348,7 @@ function get_purchase_value($stock_id) $result = db_query($sql,"retreive stock purchase price"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function update_purchase_value($stock_id, $price) diff --git a/includes/db_pager.inc b/includes/db_pager.inc index affb9e09..e3f3b167 100644 --- a/includes/db_pager.inc +++ b/includes/db_pager.inc @@ -349,7 +349,8 @@ class db_pager { if ($result == false) return false; $row = db_fetch_row($result); - $this->rec_count = $row[0]; + $this->rec_count = is_array($row) ? $row[0] : 0; +; $this->max_page = $this->page_len ? ceil($this->rec_count/$this->page_len) : 0; diff --git a/inventory/includes/db/items_category_db.inc b/inventory/includes/db/items_category_db.inc index 8b6d872a..2c79d137 100644 --- a/inventory/includes/db/items_category_db.inc +++ b/inventory/includes/db/items_category_db.inc @@ -98,6 +98,6 @@ function get_category_name($id) $result = db_query($sql, "could not get sales type"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } diff --git a/inventory/includes/db/items_units_db.inc b/inventory/includes/db/items_units_db.inc index d90b03b3..486db562 100644 --- a/inventory/includes/db/items_units_db.inc +++ b/inventory/includes/db/items_units_db.inc @@ -48,7 +48,7 @@ function get_unit_descr($unit) $result = db_query($sql, "could not retrieve unit description"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function item_unit_used($unit) { @@ -72,6 +72,6 @@ function get_unit_dec($stock_id) $result = db_query($sql, "could not get unit decimals"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } diff --git a/inventory/manage/sales_kits.php b/inventory/manage/sales_kits.php index c8a80687..849564dd 100644 --- a/inventory/manage/sales_kits.php +++ b/inventory/manage/sales_kits.php @@ -224,8 +224,8 @@ if (get_post('item_code') == '') { if (get_post('item_code') == '') { // new kit/alias if ($Mode!='ADD_ITEM' && $Mode!='UPDATE_ITEM') { - $_POST['description'] = $props['description']; - $_POST['category'] = $props['category_id']; + $_POST['description'] = is_array($props) ? $props['description'] : ''; + $_POST['category'] = is_array($props) ? $props['category_id'] : ''; } text_row(_("Description:"), 'description', null, 50, 200); stock_categories_list_row(_("Category:"), 'category', null); diff --git a/purchasing/includes/db/suppliers_db.inc b/purchasing/includes/db/suppliers_db.inc index 602b86bf..dff68c12 100644 --- a/purchasing/includes/db/suppliers_db.inc +++ b/purchasing/includes/db/suppliers_db.inc @@ -144,7 +144,7 @@ function get_supplier_name($supplier_id) $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function get_supplier_accounts($supplier_id) diff --git a/reporting/rep306.php b/reporting/rep306.php index 3ce3a860..9dc886a1 100644 --- a/reporting/rep306.php +++ b/reporting/rep306.php @@ -85,10 +85,7 @@ function get_supp_inv_reference($supplier_id, $stock_id, $date) AND trans.tran_date=".db_escape($date); $result = db_query($sql,"No transactions were returned"); $row = db_fetch_row($result); - if (isset($row[0])) - return $row[0]; - else - return ''; + return is_array($row) ? $row[0] : ''; } //---------------------------------------------------------------------------------------------------- diff --git a/reporting/rep307.php b/reporting/rep307.php index 18cfc6ea..d9d9c29e 100644 --- a/reporting/rep307.php +++ b/reporting/rep307.php @@ -45,7 +45,7 @@ function fetch_items($category=0) return db_query($sql,"No transactions were returned"); } -function trans_qty($stock_id, $location=null, $from_date, $to_date, $inward = true) +function trans_qty($stock_id, $location, $from_date, $to_date, $inward = true) { if ($from_date == null) $from_date = Today(); diff --git a/reporting/rep308.php b/reporting/rep308.php index 0981c2ad..ffd880eb 100644 --- a/reporting/rep308.php +++ b/reporting/rep308.php @@ -64,7 +64,7 @@ function fetch_items($category=0) return db_query($sql,"No transactions were returned"); } -function trans_qty($stock_id, $location=null, $from_date, $to_date, $inward = true) +function trans_qty($stock_id, $location, $from_date, $to_date, $inward = true) { if ($from_date == null) $from_date = Today(); @@ -97,7 +97,7 @@ function trans_qty($stock_id, $location=null, $from_date, $to_date, $inward = tr } -function avg_unit_cost($stock_id, $location=null, $to_date) +function avg_unit_cost($stock_id, $location, $to_date) { if ($to_date == null) $to_date = Today(); @@ -139,7 +139,7 @@ function avg_unit_cost($stock_id, $location=null, $to_date) //---------------------------------------------------------------------------------------------------- -function trans_qty_unit_cost($stock_id, $location=null, $from_date, $to_date, $inward = true) +function trans_qty_unit_cost($stock_id, $location, $from_date, $to_date, $inward = true) { if ($from_date == null) $from_date = Today(); diff --git a/reporting/rep310.php b/reporting/rep310.php index ff17aa27..54de32e8 100644 --- a/reporting/rep310.php +++ b/reporting/rep310.php @@ -86,10 +86,7 @@ function get_supp_inv_reference($supplier_id, $stock_id, $date) AND trans.tran_date=".db_escape($date); $result = db_query($sql,"No transactions were returned"); $row = db_fetch_row($result); - if (isset($row[0])) - return $row[0]; - else - return ''; + return is_array($row) ? $row[0] : ''; } //---------------------------------------------------------------------------------------------------- diff --git a/reporting/rep451.php b/reporting/rep451.php index ece0519b..28bdae6a 100644 --- a/reporting/rep451.php +++ b/reporting/rep451.php @@ -33,7 +33,7 @@ function find_last_location($stock_id, $end_date) tran_date <= '$end_date' ORDER BY tran_date DESC LIMIT 1"; $res = db_query($sql,"No stock moves were returned"); $row = db_fetch_row($res); - return $row[0]; + return is_array($row) ? $row[0] : false; } //---------------------------------------------------------------------------------------------------- diff --git a/sales/includes/db/cust_trans_db.inc b/sales/includes/db/cust_trans_db.inc index 401c7a54..a68063b8 100644 --- a/sales/includes/db/cust_trans_db.inc +++ b/sales/includes/db/cust_trans_db.inc @@ -244,7 +244,7 @@ function get_customer_trans_order($type, $type_no) $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } //---------------------------------------------------------------------------------------- diff --git a/sales/includes/db/customers_db.inc b/sales/includes/db/customers_db.inc index f9b111a0..3f16159e 100644 --- a/sales/includes/db/customers_db.inc +++ b/sales/includes/db/customers_db.inc @@ -132,7 +132,7 @@ function get_customer_name($customer_id) $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function get_customer_habit($customer_id) @@ -165,6 +165,8 @@ function get_current_cust_credit($customer_id) { $custdet = get_customer_details($customer_id); + if (!is_array($custdet)) + return 0; return $custdet['credit_limit']-$custdet['Balance']; } diff --git a/sales/includes/db/sales_delivery_db.inc b/sales/includes/db/sales_delivery_db.inc index 9f0ecbca..ebb04860 100644 --- a/sales/includes/db/sales_delivery_db.inc +++ b/sales/includes/db/sales_delivery_db.inc @@ -210,7 +210,7 @@ function adjust_shipping_charge(&$delivery, $trans_no) $sql = "SELECT sum(ov_freight) as freight FROM ".TB_PREF."debtor_trans WHERE order_ = $trans_no AND type = " . ST_CUSTDELIVERY . " AND debtor_no = " . $delivery->customer_id; $result = db_query($sql, "Can not find delivery notes"); $row = db_fetch_row($result); - if (!$row[0]) $freight = 0; + if (!is_array($row)) $freight = 0; else $freight = $row[0]; if ($freight < $delivery->freight_cost) $delivery->freight_cost = $delivery->freight_cost - $freight; else $delivery->freight_cost = 0; diff --git a/sales/includes/db/sales_groups_db.inc b/sales/includes/db/sales_groups_db.inc index f68a3bb6..6f926d7e 100644 --- a/sales/includes/db/sales_groups_db.inc +++ b/sales/includes/db/sales_groups_db.inc @@ -49,7 +49,7 @@ function get_sales_group_name($group_no) $sql = "SELECT description FROM ".TB_PREF."groups WHERE id = ".db_escape($group_no); $result = db_query($sql, "could not get group"); $row = db_fetch($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function add_sales_area($description) @@ -92,7 +92,7 @@ function get_area_name($id) $result = db_query($sql, "could not get sales type"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function add_salesman($salesman_name, $salesman_phone, $salesman_fax, @@ -151,7 +151,7 @@ function get_salesman_name($id) $result = db_query($sql, "could not get sales type"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } diff --git a/sales/includes/db/sales_invoice_db.inc b/sales/includes/db/sales_invoice_db.inc index c17e9214..b1cbfa3f 100644 --- a/sales/includes/db/sales_invoice_db.inc +++ b/sales/includes/db/sales_invoice_db.inc @@ -291,7 +291,7 @@ function get_cust_prepayment_invoice_factor($trans_no) LEFT JOIN ".TB_PREF."sales_orders so ON so.trans_type=".ST_SALESORDER." AND so.order_no=dt.order_ WHERE dt.type=".ST_SALESINVOICE." AND trans_no=".db_escape($trans_no); $row = db_fetch(db_query($sql, 'cannot retrieve prepaid invoice factor')); - return $row[0]; + return is_array($row) ? $row[0] : false; } /* diff --git a/sales/includes/db/sales_points_db.inc b/sales/includes/db/sales_points_db.inc index b5abaef7..9537a913 100644 --- a/sales/includes/db/sales_points_db.inc +++ b/sales/includes/db/sales_points_db.inc @@ -61,7 +61,7 @@ function get_sales_point_name($id) $result = db_query($sql, "could not get POS name"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function delete_sales_point($id) diff --git a/sales/includes/db/sales_types_db.inc b/sales/includes/db/sales_types_db.inc index a0279d3e..6007eb25 100644 --- a/sales/includes/db/sales_types_db.inc +++ b/sales/includes/db/sales_types_db.inc @@ -50,7 +50,7 @@ function get_sales_type_name($id) $result = db_query($sql, "could not get sales type"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function delete_sales_type($id) diff --git a/taxes/db/tax_types_db.inc b/taxes/db/tax_types_db.inc index ce73935f..b927bb05 100644 --- a/taxes/db/tax_types_db.inc +++ b/taxes/db/tax_types_db.inc @@ -73,7 +73,7 @@ function get_tax_type_rate($type_id) $result = db_query($sql, "could not get tax type rate"); $row = db_fetch_row($result); - return $row[0]; + return is_array($row) ? $row[0] : false; } function delete_tax_type($type_id)