From 1f0c0dd5711510de8fb1d405d15a380def6e818e Mon Sep 17 00:00:00 2001
From: Joe <unknown>
Date: Tue, 10 Dec 2013 08:21:07 +0100
Subject: [PATCH] Avoiding redundant passes in Fiscal Year deletion.

---
 admin/db/fiscalyears_db.inc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/admin/db/fiscalyears_db.inc b/admin/db/fiscalyears_db.inc
index c605c064..29e826dc 100644
--- a/admin/db/fiscalyears_db.inc
+++ b/admin/db/fiscalyears_db.inc
@@ -190,11 +190,16 @@ function delete_attachments_and_comments($type_no, $trans_no)
 	
 	$sql = "SELECT * FROM ".TB_PREF."attachments WHERE type_no = $type_no AND trans_no = $trans_no";
 	$result = db_query($sql, "Could not retrieve attachments");
+	$delflag = false;
 	while ($row = db_fetch($result))
 	{
+		$delflag = true;
 		$dir =  company_path(). "/attachments";
 		if (file_exists($dir."/".$row['unique_name']))
 			unlink($dir."/".$row['unique_name']);
+	}
+	if ($delflag)
+	{
 		$sql = "DELETE FROM ".TB_PREF."attachments WHERE  type_no = $type_no AND trans_no = $trans_no";
 		db_query($sql, "Could not delete attachment");
 	}	
-- 
2.30.2