[0004212] Work Order Entry: fixed error when voided WO refence is reused.
[fa-stable.git] / manufacturing / work_order_entry.php
index c2560b47c2a86e8a95c3bfdcbb4a8d26df487bc7..aa13e8d5a145150765c775b812b617f918404179 100644 (file)
@@ -9,24 +9,23 @@
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  
     See the License here <http://www.gnu.org/licenses/gpl-3.0.html>.
 ***********************************************************************/
-$page_security = 10;
-$path_to_root="..";
+$page_security = 'SA_WORKORDERENTRY';
+$path_to_root = "..";
 
 include_once($path_to_root . "/includes/session.inc");
 
 include_once($path_to_root . "/includes/date_functions.inc");
-include_once($path_to_root . "/includes/manufacturing.inc");
 include_once($path_to_root . "/includes/data_checks.inc");
 
 include_once($path_to_root . "/manufacturing/includes/manufacturing_db.inc");
 include_once($path_to_root . "/manufacturing/includes/manufacturing_ui.inc");
 
 $js = "";
-if ($use_popup_windows)
+if ($SysPrefs->use_popup_windows)
        $js .= get_js_open_window(900, 500);
-if ($use_date_picker)
+if (user_use_date_picker())
        $js .= get_js_date_picker();
-page(_("Work Order Entry"), false, false, "", $js);
+page(_($help_context = "Work Order Entry"), false, false, "", $js);
 
 
 check_db_has_manufacturable_items(_("There are no manufacturable items defined in the system."));
@@ -49,22 +48,23 @@ elseif(isset($_POST['selected_id']))
 if (isset($_GET['AddedID']))
 {
        $id = $_GET['AddedID'];
-       $stype = systypes::work_order();
+       $stype = ST_WORKORDER;
 
        display_notification_centered(_("The work order been added."));
 
-    display_note(get_trans_view_str($stype, $id, _("View this Work Order")));
+    display_note(get_trans_view_str($stype, $id, _("View this Work Order")), 0, 1);
 
-       if ($_GET['type'] != wo_types::advanced())
+       if ($_GET['type'] != WO_ADVANCED)
        {
                include_once($path_to_root . "/reporting/includes/reporting.inc");
-       $ar = array('PARAM_0' => $id, 'PARAM_1' => $id, 'PARAM_2' => 0); 
-       display_note(print_link(_("Print this Work Order"), 409, $ar), 1);
-       $ar['PARAM_2'] = 1;
-       display_note(print_link(_("Email this Work Order"), 409, $ar), 1);
+
+               submenu_print(_("&Print This Work Order"), ST_WORKORDER, $id, 'prtopt');
+               submenu_print(_("&Email This Work Order"), ST_WORKORDER, $id, null, 1);
        display_note(get_gl_view_str($stype, $id, _("View the GL Journal Entries for this Work Order")), 1);
-       $ar = array('PARAM_0' => $_GET['date'], 'PARAM_1' => $_GET['date'], 'PARAM_2' => $stype); 
+       $ar = array('PARAM_0' => $_GET['date'], 'PARAM_1' => $_GET['date'], 'PARAM_2' => $stype, 'PARAM_3' => '',
+               'PARAM_4' => (user_def_print_orientation() == 1 ? 1 : 0)); 
        display_note(print_link(_("Print the GL Journal Entries for this Work Order"), 702, $ar), 1);
+               hyperlink_params("$path_to_root/admin/attachments.php", _("Add an Attachment"), "filterType=$stype&trans_no=$id");
        }
        
        safe_exit();
@@ -122,26 +122,18 @@ if (!isset($_POST['date_']))
 
 function can_process()
 {
-       global $selected_id;
+       global $selected_id, $SysPrefs;
 
        if (!isset($selected_id))
        {
-       if (!references::is_valid($_POST['wo_ref']))
+       if (!check_reference($_POST['wo_ref'], ST_WORKORDER))
        {
-               display_error(_("You must enter a reference."));
-                       set_focus('wo_ref');
-               return false;
-       }
-
-       if (!is_new_reference($_POST['wo_ref'], systypes::work_order()))
-       {
-               display_error(_("The entered reference is already in use."));
                        set_focus('wo_ref');
                return false;
        }
        }
 
-       if (!check_num('quantity', 0))
+       if (!check_num('quantity', 1))
        {
                display_error( _("The quantity entered is invalid or less than zero."));
                set_focus('quantity');
@@ -156,12 +148,12 @@ function can_process()
        }
        elseif (!is_date_in_fiscalyear($_POST['date_']))
        {
-               display_error(_("The entered date is not in fiscal year."));
+               display_error(_("The entered date is out of fiscal year or is closed for further data entry."));
                set_focus('date_');
                return false;
        }
        // only check bom and quantites if quick assembly
-       if (!($_POST['type'] == wo_types::advanced()))
+       if (!($_POST['type'] == WO_ADVANCED))
        {
         if (!has_bom($_POST['stock_id']))
         {
@@ -187,9 +179,9 @@ function can_process()
                return false;
        }
 
-        if (!sys_prefs::allow_negative_stock())
+        if (!$SysPrefs->allow_negative_stock())
         {
-               if ($_POST['type'] == wo_types::assemble())
+               if ($_POST['type'] == WO_ASSEMBLY)
                {
                        // check bom if assembling
                 $result = get_bom($_POST['stock_id']);
@@ -202,8 +194,7 @@ function can_process()
 
                                $quantity = $bom_item["quantity"] * input_num('quantity');
 
-                        $qoh = get_qoh_on_date($bom_item["component"], $bom_item["loc_code"], $_POST['date_']);
-                               if (-$quantity + $qoh < 0)
+                        if (check_negative_stock($bom_item["component"], -$quantity, $bom_item["loc_code"], $_POST['date_']))
                                {
                                        display_error(_("The work order cannot be processed because there is an insufficient quantity for component:") .
                                                " " . $bom_item["component"] . " - " .  $bom_item["description"] . ".  " . _("Location:") . " " . $bom_item["location_name"]);
@@ -213,11 +204,10 @@ function can_process()
                        }
                }
                }
-               elseif ($_POST['type'] == wo_types::unassemble())
+               elseif ($_POST['type'] == WO_UNASSEMBLY)
                {
                        // if unassembling, check item to unassemble
-                               $qoh = get_qoh_on_date($_POST['stock_id'], $_POST['StockLocation'], $_POST['date_']);
-                       if (-input_num('quantity') + $qoh < 0)
+                if (check_negative_stock($_POST['stock_id'], -input_num('quantity'), $_POST['StockLocation'], $_POST['date_']))
                        {
                                display_error(_("The selected item cannot be unassembled because there is insufficient stock."));
                                        return false;
@@ -233,15 +223,8 @@ function can_process()
                display_error( _("The date entered is in an invalid format."));
                return false;
                }
-               //elseif (!is_date_in_fiscalyear($_POST['RequDate']))
-               //{
-               //      display_error(_("The entered date is not in fiscal year."));
-               //      return false;
-               //}
        if (isset($selected_id))
        {
-               $myrow = get_work_order($selected_id, true);
-
                if ($_POST['units_issued'] > input_num('quantity'))
                {
                                set_focus('quantity');
@@ -302,7 +285,7 @@ if (isset($_POST['delete']))
        { //ie not cancelled the delete as a result of above tests
 
                // delete the actual work order
-               delete_work_order($selected_id);
+               delete_work_order($selected_id, $_POST['stock_id'], $_POST['quantity'], $_POST['date_']);
                meta_forward($_SERVER['PHP_SELF'], "DeletedID=$selected_id");
        }
 }
@@ -326,7 +309,7 @@ if (get_post('_type_update'))
 
 start_form();
 
-start_table($table_style2);
+start_table(TABLESTYLE2);
 
 $existing_comments = "";
 
@@ -351,7 +334,8 @@ if (isset($selected_id))
 
        $_POST['wo_ref'] = $myrow["wo_ref"];
        $_POST['stock_id'] = $myrow["stock_id"];
-       $_POST['quantity'] = qty_format($myrow["units_reqd"], $_POST['stock_id'], $dec);
+       //$_POST['quantity'] = qty_format($myrow["units_reqd"], $_POST['stock_id'], $dec);
+       $_POST['quantity'] = $myrow["units_reqd"];
        $_POST['StockLocation'] = $myrow["loc_code"];
        $_POST['released'] = $myrow["released"];
        $_POST['closed'] = $myrow["closed"];
@@ -359,28 +343,26 @@ if (isset($selected_id))
        $_POST['date_'] = sql2date($myrow["date_"]);
        $_POST['RequDate'] = sql2date($myrow["required_by"]);
        $_POST['released_date'] = sql2date($myrow["released_date"]);
-       $_POST['memo_'] = "";
        $_POST['units_issued'] = $myrow["units_issued"];
        $_POST['Costs'] = price_format($myrow["additional_costs"]);
 
-       $_POST['memo_'] = get_comments_string(systypes::work_order(), $selected_id);
+       $_POST['memo_'] = get_comments_string(ST_WORKORDER, $selected_id);
 
        hidden('wo_ref', $_POST['wo_ref']);
        hidden('units_issued', $_POST['units_issued']);
        hidden('released', $_POST['released']);
        hidden('released_date', $_POST['released_date']);
        hidden('selected_id',  $selected_id);
-       hidden('old_qty', $myrow["units_reqd"]);
-       hidden('old_stk_id', $myrow["stock_id"]);
 
        label_row(_("Reference:"), $_POST['wo_ref']);
-       label_row(_("Type:"), wo_types::name($_POST['type']));
+       label_row(_("Type:"), $wo_types_array[$_POST['type']]);
        hidden('type', $myrow["type"]);
 }
 else
 {
        $_POST['units_issued'] = $_POST['released'] = 0;
-       ref_row(_("Reference:"), 'wo_ref', '', references::get_next(systypes::work_order()));
+
+       ref_row(_("Reference:"), 'wo_ref', '', $Refs->get_next(ST_WORKORDER, null, get_post('date_')), false, ST_WORKORDER);
 
        wo_types_list_row(_("Type:"), 'type', null);
 }
@@ -409,13 +391,13 @@ else
        $_POST['quantity'] = qty_format($_POST['quantity'], $_POST['stock_id'], $dec);
        
 
-if (get_post('type') == wo_types::advanced())
+if (get_post('type') == WO_ADVANCED)
 {
     qty_row(_("Quantity Required:"), 'quantity', null, null, null, $dec);
     if ($_POST['released'])
        label_row(_("Quantity Manufactured:"), number_format($_POST['units_issued'], get_qty_dec($_POST['stock_id'])));
     date_row(_("Date") . ":", 'date_', '', true);
-       date_row(_("Date Required By") . ":", 'RequDate', '', null, sys_prefs::default_wo_required_by());
+       date_row(_("Date Required By") . ":", 'RequDate', '', null, $SysPrefs->default_wo_required_by());
 }
 else
 {
@@ -423,24 +405,22 @@ else
     date_row(_("Date") . ":", 'date_', '', true);
        hidden('RequDate', '');
 
-       $sql = "SELECT DISTINCT account_code FROM ".TB_PREF."bank_accounts";
-       $rs = db_query($sql,"could not get bank accounts");
-       $r = db_fetch_row($rs);
-       if (!isset($_POST['Labour']))
+       if (!isset($_POST['Labour']) || list_updated('stock_id') || list_updated('type'))
        {
-               $_POST['Labour'] = price_format(0);
-               $_POST['cr_lab_acc'] = $r[0];
+               $bank_act = get_default_bank_account();
+               $item = get_item(get_post('stock_id'));
+               $_POST['Labour'] = price_format(get_post('type') == WO_ASSEMBLY ? $item['labour_cost'] : 0);
+               $_POST['cr_lab_acc'] = $bank_act['account_code'];
+               $_POST['Costs'] = price_format(get_post('type') == WO_ASSEMBLY ? $item['overhead_cost'] : 0);
+               $_POST['cr_acc'] = $bank_act['account_code'];
+               $Ajax->activate('_page_body');
        }
+
        amount_row($wo_cost_types[WO_LABOUR], 'Labour');
        gl_all_accounts_list_row(_("Credit Labour Account"), 'cr_lab_acc', null);
-       if (!isset($_POST['Costs']))
-       {
-               $_POST['Costs'] = price_format(0);
-               $_POST['cr_acc'] = $r[0];
-       }
        amount_row($wo_cost_types[WO_OVERHEAD], 'Costs');
        gl_all_accounts_list_row(_("Credit Overhead Account"), 'cr_acc', null);
-       
+
 }
 
 if (get_post('released'))
@@ -471,4 +451,3 @@ else
 end_form();
 end_page();
 
-?>
\ No newline at end of file