Secon Rerun of voiding Customer Payment. Of course test for type first.
authorJoe <joe.hunt.consulting@gmail.com>
Thu, 3 Nov 2022 16:07:42 +0000 (17:07 +0100)
committerJoe <joe.hunt.consulting@gmail.com>
Thu, 3 Nov 2022 16:07:42 +0000 (17:07 +0100)
admin/db/voiding_db.inc

index b3bba8b6e4082a592cf7f13de3de390a3cae8bc6..7f3ddc21c432d69b22da0cd518bc8ab407cf5799 100644 (file)
@@ -45,7 +45,7 @@ function void_transaction($type, $type_no, $date_, $memo_)
                        if (!check_void_bank_trans($type, $type_no))
                                return _('This transaction cannot be voided because the operation would decrease account balance below allowed limit in some point of account history.');
                case ST_SALESINVOICE : // it's a customer invoice
-                       if (is_cust_invoice_credited($type_no) && $type == ST_SALESINVOICE)
+                       if ($type == ST_SALESINVOICE && is_cust_invoice_credited($type_no))
                                return _('This invoice cannot be voided because it was already credited.');
                case ST_CUSTCREDIT : // it's a customer credit note
                case ST_CUSTDELIVERY : // it's a customer dispatch