0004847: FA allows reconciliation of closed transactions. Fixed by @Braath Waathe.
authorJoe Hunt <joe.hunt.consulting@gmail.com>
Fri, 22 Feb 2019 09:01:34 +0000 (10:01 +0100)
committerJoe Hunt <joe.hunt.consulting@gmail.com>
Fri, 22 Feb 2019 09:01:34 +0000 (10:01 +0100)
gl/bank_account_reconcile.php

index 81ebc7a0ee06f3b34c552749815ae92d3f7a7098..a5738946451ea7385e6890a128de1b3dd48d939b 100644 (file)
@@ -52,8 +52,8 @@ function rec_checkbox($row)
        $value = $row['reconciled'] != '';
 
 // save also in hidden field for testing during 'Reconcile'
-       return checkbox(null, $name, $value, true, _('Reconcile this transaction'))
-               . hidden($hidden, $value, false);
+       return is_closed_trans($row['type'], $row['trans_no']) ? "--" : checkbox(null, $name, $value, true, _('Reconcile this transaction'))
+               . hidden($hidden, $value, false);
 }
 
 function systype_name($dummy, $type)