Sales type potential bug in tax_included (persistent on)
authorJoe Hunt <joe.hunt.consulting@gmail.com>
Fri, 19 May 2017 19:53:28 +0000 (21:53 +0200)
committerJoe Hunt <joe.hunt.consulting@gmail.com>
Fri, 19 May 2017 19:53:28 +0000 (21:53 +0200)
sales/manage/sales_types.php

index f356b4e44b52b8c54362f73356ddd2d02da5a8c0..8749f221fa263cd96a70b717b43a2f9109e298a8 100644 (file)
@@ -43,7 +43,7 @@ function can_process()
 
 if ($Mode=='ADD_ITEM' && can_process())
 {
-       add_sales_type($_POST['sales_type'], isset($_POST['tax_included']) ? 1:0,
+       add_sales_type($_POST['sales_type'], check_value('tax_included'),
            input_num('factor'));
        display_notification(_('New sales type has been added'));
        $Mode = 'RESET';
@@ -54,7 +54,7 @@ if ($Mode=='ADD_ITEM' && can_process())
 if ($Mode=='UPDATE_ITEM' && can_process())
 {
 
-       update_sales_type($selected_id, $_POST['sales_type'], isset($_POST['tax_included']) ? 1:0,
+       update_sales_type($selected_id, $_POST['sales_type'], check_value('tax_included'),
             input_num('factor'));
        display_notification(_('Selected sales type has been updated'));
        $Mode = 'RESET';