Missing check for supplier selection.
authorJanusz Dobrowolski <janusz@frontaccounting.eu>
Mon, 15 Mar 2010 18:03:27 +0000 (18:03 +0000)
committerJanusz Dobrowolski <janusz@frontaccounting.eu>
Mon, 15 Mar 2010 18:03:27 +0000 (18:03 +0000)
purchasing/po_entry_items.php
purchasing/supplier_invoice.php
purchasing/supplier_payment.php

index 34cce5534c1a26f8a2a54eef8c62858fa5b66b89..df67182db583834ef6bc98c5663c9932db7a3384 100644 (file)
@@ -66,22 +66,22 @@ if (isset($_GET['AddedID']))
 
 function copy_from_cart()
 {
-       $_POST['supplier_id'] = $_SESSION['PO']->supplier_id;   
-       $_POST['OrderDate'] = $_SESSION['PO']->orig_order_date; 
+       $_POST['supplier_id'] = $_SESSION['PO']->supplier_id;
+       $_POST['OrderDate'] = $_SESSION['PO']->orig_order_date;
     $_POST['Requisition'] = $_SESSION['PO']->requisition_no;
     $_POST['ref'] = $_SESSION['PO']->reference;
        $_POST['Comments'] = $_SESSION['PO']->Comments;
     $_POST['StkLocation'] = $_SESSION['PO']->Location;
-    $_POST['delivery_address'] = $_SESSION['PO']->delivery_address;    
+    $_POST['delivery_address'] = $_SESSION['PO']->delivery_address;
 }
 
 function copy_to_cart()
 {
-       $_SESSION['PO']->supplier_id = $_POST['supplier_id'];   
+       $_SESSION['PO']->supplier_id = $_POST['supplier_id'];
        $_SESSION['PO']->orig_order_date = $_POST['OrderDate'];
        $_SESSION['PO']->reference = $_POST['ref'];
        $_SESSION['PO']->requisition_no = $_POST['Requisition'];
-       $_SESSION['PO']->Comments = $_POST['Comments']; 
+       $_SESSION['PO']->Comments = $_POST['Comments'];
        $_SESSION['PO']->Location = $_POST['StkLocation'];
        $_SESSION['PO']->delivery_address = $_POST['delivery_address'];
 }
@@ -268,6 +268,13 @@ function can_commit()
 {
        global $Refs;
 
+       if (!get_post('supplier_id')) 
+       {
+               display_error(_("There is no supplier selected."));
+               set_focus('supplier_id');
+               return false;
+       } 
+       
        if (!is_date($_POST['OrderDate'])) 
        {
                display_error(_("The entered order date is invalid."));
index 13402c62ecb10c4fcbb5c1e8c9032dcb0db1c933..3dde32cddf02662221a154f8ebcf7f2e3766b47e 100644 (file)
@@ -381,7 +381,7 @@ start_form();
 invoice_header($_SESSION['supp_trans']);
 
 if ($_POST['supplier_id']=='') 
-       display_error('No supplier found for entered search text');
+               display_error(_("There is no supplier selected."));
 else {
        display_grn_items($_SESSION['supp_trans'], 1);
 
index e0aa2d08bd2f2b77ea82eb6e97582f6ea33d7a03..ddc1bf437060b1419890b79987b50f77630e50f7 100644 (file)
@@ -17,7 +17,6 @@ include_once($path_to_root . "/includes/date_functions.inc");
 include_once($path_to_root . "/includes/ui.inc");
 include_once($path_to_root . "/includes/banking.inc");
 include_once($path_to_root . "/includes/data_checks.inc");
-//include_once($path_to_root . "/purchasing/includes/ui/supp_alloc_ui.inc");
 include_once($path_to_root . "/purchasing/includes/purchasing_db.inc");
 include_once($path_to_root . "/reporting/includes/reporting.inc");
 
@@ -88,6 +87,13 @@ function check_inputs()
 {
        global $Refs;
 
+       if (!get_post('supplier_id')) 
+       {
+               display_error(_("There is no supplier selected."));
+               set_focus('supplier_id');
+               return false;
+       } 
+       
        if ($_POST['amount'] == "") 
        {
                $_POST['amount'] = price_format(0);