Redundant sql sentences in Report Filters.
authorJoe Hunt <joe.hunt.consulting@gmail.com>
Sat, 18 Aug 2018 06:28:38 +0000 (08:28 +0200)
committerJoe Hunt <joe.hunt.consulting@gmail.com>
Sat, 18 Aug 2018 06:28:38 +0000 (08:28 +0200)
reporting/includes/reports_classes.inc

index 96134f95e21c05f6949f574566c5fed8938dd1f2..1b9694d3890783ddd6acd5bb3a4625744b34627e 100644 (file)
@@ -299,7 +299,6 @@ class BoxReports
 
                                case 'CUSTOMERS_NO_FILTER':
                                case 'CUSTOMERS':
 
                                case 'CUSTOMERS_NO_FILTER':
                                case 'CUSTOMERS':
-                                       $sql = "SELECT debtor_no, name FROM ".TB_PREF."debtors_master";
                                        if ($type == 'CUSTOMERS_NO_FILTER')
                                                return customer_list($name, null, _("No Customer Filter"));
                                        else
                                        if ($type == 'CUSTOMERS_NO_FILTER')
                                                return customer_list($name, null, _("No Customer Filter"));
                                        else
@@ -307,7 +306,6 @@ class BoxReports
 
                                case 'SUPPLIERS_NO_FILTER':
                                case 'SUPPLIERS':
 
                                case 'SUPPLIERS_NO_FILTER':
                                case 'SUPPLIERS':
-                                       $sql = "SELECT supplier_id, supp_name FROM ".TB_PREF."suppliers";
                                        if ($type == 'SUPPLIERS_NO_FILTER')
                                                return supplier_list($name, null, _("No Supplier Filter"));
                                        else
                                        if ($type == 'SUPPLIERS_NO_FILTER')
                                                return supplier_list($name, null, _("No Supplier Filter"));
                                        else