Bugs in sales_db.inc and sales_order_ui.inc fixed by @kvvaradha.
authorJoe Hunt <joe.hunt.consulting@gmail.com>
Thu, 24 Jan 2019 22:28:25 +0000 (23:28 +0100)
committerJoe Hunt <joe.hunt.consulting@gmail.com>
Thu, 24 Jan 2019 22:28:25 +0000 (23:28 +0100)
sales/includes/sales_db.inc
sales/includes/ui/sales_order_ui.inc

index d58d8cf76988ab7fec955717a503bf9e88e1b573..bdc449d83623f0d1a5973767189acbbfcacdf4d3 100644 (file)
@@ -231,7 +231,7 @@ function read_sales_trans($doc_type, $trans_no, &$cart)
        } else {
                // read header data from first document
                $myrow = get_customer_trans($trans_no[0],$doc_type);
-               if (count($trans_no)>1)
+               if (count_array($trans_no)>1)
                        $cart->trans_no = get_customer_trans_version($doc_type, $trans_no);
                else
                        $cart->trans_no = array($trans_no[0]=>$myrow["version"]);
@@ -371,7 +371,7 @@ function get_sales_child_documents($trans_type, $trans_no)
        if (!count_array($trans_no))
                return false;
        $childs = get_sales_child_numbers($trans_type, $trans_no, false);
-       if (!count($childs))
+       if (!count_array($childs))
                return false;
                
        $sql = "SELECT * FROM ".TB_PREF."debtor_trans
index 1980f9f7f81cbb7eeb66202e709858abbf16b973..b8d70866788e11163edcc2a5f244aa88d6c5530d 100644 (file)
@@ -502,14 +502,14 @@ function sales_order_item_controls(&$order, &$rowcounter, $line_no=-1)
                if ($order->fixed_asset)
                        stock_disposable_fa_list_cells(null,'stock_id', null, _('[Select item]'), true, $order->line_items);
                else
+                       sales_items_list_cells(null,'stock_id', null, false, true, true);
                if (list_updated('stock_id')) {
-            sales_items_list_cells(null,'stock_id', null, false, true, true);
-                   $Ajax->activate('price');
-                   $Ajax->activate('units');
-                   $Ajax->activate('qty');
-                   $Ajax->activate('line_total');
+                       $Ajax->activate('price');
+                       $Ajax->activate('units');
+                       $Ajax->activate('qty');
+                       $Ajax->activate('line_total');
                } else
-                        sales_items_list_cells(null,'stock_id', last_sales_order_detail($order, 'stk_code'), false, true, true);
+                       sales_items_list_cells(null,'stock_id', last_sales_order_detail($order, 'stk_code'), false, true, true);
 
                $item_info = get_item_edit_info($_POST['stock_id']);
                $units = $item_info["units"];